aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Grammar fix in ActionView docs/commentsEdward Ocampo-Gooding2012-08-121-1/+1
|
* Ensure option_html_attributes does not modify the given option hashesCarlos Antonio da Silva2012-08-111-1/+1
| | | | We can avoid creating extra hashes with #merge, and use #merge! instead.
* Simplify html attributes generation for options_for_selectCarlos Antonio da Silva2012-08-111-3/+5
| | | | | | | Further simplify the option_html_attributes method after the changes introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the html options here (since they're going to be escaped down the chain in content tag).
* check for nil or empty record in form_forschneems2012-08-101-0/+1
| | | | if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
* Do not mark strip_tags result as html_safeSantiago Pastorino2012-08-091-1/+1
| | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465
* Allow data attributes to be set as a first-level option for form_for, so you ↵David Heinemeier Hansson2012-08-081-0/+19
| | | | can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
* Modernize the documentation for view caching somewhatDavid Heinemeier Hansson2012-08-081-16/+16
|
* Deprecate `button_to_function` and `link_to_function` helpers.Rafael Mendonça França2012-08-071-0/+40
| | | | | | | | | | | | | | | | | | | | | | We recommend the use of Unobtrusive JavaScript instead. For example: link_to "Greeting", "#", :class => "nav_link" $(function() { $('.nav_link').click(function() { // Some complex code return false; }); }); or link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link" for simple cases. This reverts commit 3acdd652e9fe99481c879c84c5807a84eb9ad724.
* Revert "Merge pull request #7033 from kron4eg/master". Not a a fan at all of ↵David Heinemeier Hansson2012-08-071-10/+4
| | | | | | | what this makes ERB files look like. This reverts commit 46b8bceedd3e47169c50a04c93161424909c75fb, reversing changes made to 2f58795e783150f2e1b1f6c64e305703f0061129.
* Restoring the '%' trim mode for ERb templates, allowing for a leading ↵Artiom Di2012-08-071-4/+10
| | | | percent sign on a line to indicate non-inserted Ruby code.
* Rearrange example output of javascript_include_tagPrem Sichanugrist2012-08-061-2/+2
|
* Do not include application.js if it doesn't existsPrem Sichanugrist2012-08-061-4/+7
| | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory.
* Use content_tag here instead of manually building HTMLSantiago Pastorino2012-08-031-2/+6
|
* load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
|
* load active_support/core_ext/module/delegation in active_support/railsXavier Noria2012-08-022-2/+0
|
* load active_support/core_ext/class/attribute in active_support/railsXavier Noria2012-08-024-4/+0
|
* load active_support/concern in active_support/railsXavier Noria2012-08-022-2/+0
|
* load active_support/core_ext/object/blank in active_support/railsXavier Noria2012-08-0211-11/+0
|
* Check validity of options[:as] just onceJosé Valim2012-08-021-12/+18
|
* Improve error handling when using partial name with hyphen. Fix #7079kennyj2012-08-031-7/+12
|
* flushing output should write to the stream rather than mutating the response ↵Aaron Patterson2012-07-291-1/+1
| | | | object
* Replace the flush parameter with a Hash.Lucas Mazza2012-07-241-4/+4
|
* Merge pull request #7123 from nashby/data-in-optionsRafael Mendonça França2012-07-221-1/+1
|\ | | | | don't escape options in option_html_attributes method
| * don't escape options in option_html_attributes methodVasiliy Ermolovich2012-07-221-1/+1
| | | | | | | | | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options
* | Add back `:disable_with` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-2/+39
| |
* | Add back `:confirm` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-0/+56
|/
* Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` optionCarlos Galdino2012-07-182-46/+21
| | | | | | | | | This applies to the following helpers: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag`
* Common behavior with adding formats to lookup_context for TemplateRenderer ↵Dmitry Vorotilin2012-07-184-4/+16
| | | | and PartialRenderer
* add second t to overwrittenEvan Travers2012-07-121-2/+2
| | | | fixing a misspelling in the documentation
* Fixed bug creating invalid HTML in select optionsRusty Geldmacher2012-07-102-3/+3
| | | | | | When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-07-071-1/+1
|\
| * use config.action_controller instead of ActionController::Base in example ↵Nick Howard2012-06-301-1/+1
| | | | | | | | code for asset_tag_helper
* | Merge pull request #6904 from guilleiguaran/remove-amo-dependency-in-apCarlos Antonio da Silva2012-06-301-13/+8
|\ \ | |/ |/| Remove Active Model dependency from Action Pack
| * Remove ActiveModel dependency from ActionPackGuillermo Iguaran2012-06-301-13/+8
| | | | | | | | | | | | | | | | ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key).
* | removing the AV::Base.helpers class attribute as it is not needed.Nick Sutterer2012-06-291-1/+0
| |
* | remove AV.prepare and move all helper-related logic into the controller. ↵Nick Sutterer2012-06-291-16/+0
|/ | | | | | this decouples the view since it no longer knows about routes internals. this is a result of an ongoing discussion at https://github.com/rails/rails/pull/6826.
* :update_details method no more exists on @lookup_contextAkira Matsuda2012-06-261-2/+1
| | | | the method has gone in this commit: 119e9e2dafb0cdc5b85613b730333679aef534af
* Do not propagate the :raise option to AS number helpersCarlos Antonio da Silva2012-06-241-7/+19
| | | | | ActiveSupport::NumberHelper does not make use of :raise, so there's no need to propagate it down.
* eliminating another string subclassAaron Patterson2012-06-221-3/+7
|
* fix some accidental nilsAaron Patterson2012-06-222-3/+3
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-06-222-1/+2
|\
| * fixes a few mistakes in api docs [ci skip]Vijay Dev2012-06-221-1/+1
| |
| * Fix misprint in UrlHelper moduleAlexey Vakhov2012-06-181-1/+1
| |
| * Add rdoc to phone_field Gaurish Sharma2012-06-161-0/+1
| | | | | | [API docs](http://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-phone_field) for `phone_field` provide no information on what the method actually does. no description nor access to source code. so added this
* | use mutex_m rather than use a delegate systemAaron Patterson2012-06-211-6/+3
| |
* | Merge pull request #6428 from pinetops/resolver_concurrency_fixYehuda Katz2012-06-211-19/+76
|\ \ | | | | | | Make the Resolver template cache threadsafe
| * | Improve the readability of the Resolver change detection codeTom Clarke2012-05-221-11/+19
| | |
| * | More granular locking of the Resolver template cacheTom Clarke2012-05-211-5/+23
| | | | | | | | | | | | | | | | | | | | | In order to avoid holding a global lock when doing template resolution, instead add individual locks on a per cache entry basis. The global lock is now only used for manipulation of the main cache data structure.
| * | Make the Resolver template cache threadsafe - closes #6404Tom Clarke2012-05-211-19/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access.
* | | stop subclassing stringAaron Patterson2012-06-211-3/+10
| | |