| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | |
|
| | |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using compute_source_path to determine the full path of an
asset, if our source begins with '/', we don't want to include
the directory. Examples are illustrative:
> compute_source_path("foo", "stylesheets", "css")
=> "/Users/steve/src/my_app/public/stylesheets/foo.css"
> compute_source_path("/foo", "stylesheets", "css")
=> "/Users/steve/src/my_app/public/foo.css"
Before this patch, the second example would return the same as the
first.
Fixes #5680.
|
| | | |
|
| |\ \
| | |
| | | |
Accept a block in FormHelper#button
|
| | | | |
|
| |/ / |
|
| | |
| |
| |
| |
| | |
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
|
| | |
| |
| |
| | |
Add some tests for link_to with blocks and escaping content.
|
| | | |
|
| | |
| |
| |
| | |
Prefer Hash#[]= over Hash#merge when setting a value.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make possible to use a block in button_to helper if button text is hard
to fit into the name parameter, e.g.:
<%= button_to [:make_happy, @user] do %>
Make happy <strong><%= @user.name %></strong>
<% end %>
# => "<form method="post" action="/users/1/make_happy" class="button_to">
# <div>
# <button type="submit">
# Make happy <strong>Name</strong>
# </button>
# </div>
# </form>"
|
| |\ \ |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some of these requires are now only necessary in
ActiveSupport::NumberHelper. Add hash/keys require due to symbolize_keys
usage in number helpers. Also remove some whitespaces.
Closes #6414
|
| | | |
| | |
| | |
| | |
| | | |
Refactor number helpers output with safety handling to call float
parsing only once. Also remove 'erb' require.
|
| |/ / |
|
| | |
| |
| |
| | |
This options can be used to not escape the result by default.
|
| | | |
|
| | |
| |
| |
| | |
Refactoring the truncate method to not do a sort-circuit return
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
rails helpers.
This way if my text is long I don't have to do something like this:
.text
= truncate(@text, :length => 27)
if @text.size >= 27
= link_to "continue", notes_path, ....."")
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit fa6d921e11363e9b8c4bc10f7aed0b9faffdc33a.
Reason: Not a fan of such massive changes. We usually close such changes
if made to Rails master as a pull request. Following the same principle
here and reverting.
[ci skip]
|
| | | |
| | |
| | |
| | | |
anything.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace
with the first match, and voilà! Note that the regex matches a little bit too
much, so you probably want to `git add -i .` and go through every single diff
to check if it actually should be changed.
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Add HTML5 color and date/time inputs
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The input types added are:
- input[type="month"]
- input[type="week"]
- input[type="datetime"]
- input[type="datetime-local"]
|
| | | | | |
|
| | |_|/
|/| |
| | |
| | |
| | | |
* Added tests for 'else' case in ActionView::Helpers::TranslationHelper#wrap_translate_defaults
* Also updated the testing syntax of translation.html_safe? asserts to provide better output upon failure.
|
| | | |
| | |
| | |
| | |
| | | |
This reverts commit 254c04286c5916ae7f91eb6e173b312e7a74e364, reversing
changes made to 513a0525c24c2944630acfa465b22cd2f4601adf.
|
| |\ \ \
| |/ /
|/| | |
Resolver concurrency fix
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
In order to avoid holding a global lock when doing template
resolution, instead add individual locks on a per cache entry
basis. The global lock is now only used for manipulation of the main
cache data structure.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The Template cache in the Resolver can be accessed by multiple threads
similtaneously in multi-threaded environments. The cache is implemented
using a Hash, which isn't threadsafe in all VMs (notably JRuby).
This commit extracts the cache to a new Cache class and adds mutexes to
prevent concurrent access.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Template concurrency fixes
Conflicts:
actionpack/lib/action_view/template.rb
|
| | |/
|/| |
|
| |\ \ |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
one, added blank hash before that in the args list
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make the method API more clear by explicitly showing the expected
arguments. This means that the options cannot be passed as second
argument because we are not relying on extract_options! anymore,
you are expected to give a selected key or `nil` if you want to pass
options, as it is the last argument.
Notice that this does not change the current method arguments contract
available in 3.2, it just brings back the same functionality with the
divider addition.
|
| |\ \ \
| | | |
| | | | |
Tidied and standardised text_helper implementations.
|
| | | | | |
|
| |/ / /
| | |
| | |
| | | |
escaping of delimiters and separators
|
| |\ \ \
| | | |
| | | | |
Render img tag with empty src if empty string is passed to image_tag.
|
| | | |/
| |/| |
|
| |/ / |
|
| | | |
|
| |\ \
| | |
| | | |
TagHelper creates invalid data attributes when value is a BigDecimal
|
| | |/ |
|
| |\ \
| |/
|/| |
Created a Raw handler for templates.
|
