aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
...
* | Remove comment about getting rid of old AV::Base.new behaviorPiotr Sarnacki2012-08-281-2/+0
| | | | | | | | | | | | | | | | | | I've talked to José Valim, who added this comment, and there is no need to remove old API. It's good to have a simple way to instantiate ActionView::Base, by just passing view paths as a first argument, instead of constructing LookupContext and then the Renderer. [ci skip]
* | Move action_controller/vendor/html-scanner to action_viewPiotr Sarnacki2012-08-288-1/+1757
| | | | | | | | | | | | This is another step in moving Action View's dependencies in Action Pack to Action View itself. Also, HtmlScanner seems to be better suited for views rather than controllers.
* | Add ActionView::ModelNamingPiotr Sarnacki2012-08-283-4/+16
| | | | | | | | | | | | | | It's just a duplicate of ActionController::ModelNaming. These are just a simple helpers for decoupling Active Model, so it does not make sense to extract it to Active Support, but the point is to decouple also Action View and Action Pack
* | Move ActionController::RecordIdentifier to ActionViewPiotr Sarnacki2012-08-283-4/+85
| | | | | | | | | | | | | | Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round.
* | Remove dependency on actionpack in ActionView::AssetPathsPiotr Sarnacki2012-08-281-5/+3
| | | | | | | | | | | | Since Action View should not depend on actionpack, it's best to delegate invalid_asset_host! to controller and just rely on such simple contract instead of raising ActionController::RoutingError directly.
* | correct handling of date selects when using both disabled and discard optionsVasiliy Ermolovich2012-08-251-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | we should take disabled option not only from `html_options` hash but from `options` hash too like `build_select` method does it. So datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true }) datetime_select("post", "updated_at", :discard_minute => true , :disabled => true) both these variants work now closes #7431
* | copy edit the time_ago_in_words helper docsVijay Dev2012-08-231-4/+4
| |
* | Merge pull request #7398 from iamvery/time_ago_in_words-docsVijay Dev2012-08-221-0/+7
|\ \ | |/ |/| Extended documentation for `time_ago_in_words` helper
| * Extended documentation for `time_ago_in_words` helperJay Hayes2012-08-201-0/+7
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-221-4/+4
|\ \
| * | Make a doc example output in match actual outputEvan Farrar2012-08-151-4/+4
| |/ | | | | | | | | Make doc output in grouped_options_for_select divider example match actual output. The options groups were in backwards order of actual.
* | Get rid of config.preload_frameworks in favor of config.eager_load_namespacesJosé Valim2012-08-211-0/+2
| | | | | | | | | | | | | | The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly.
* | option_tags coerced to "" instead of nilSandeep2012-08-211-0/+1
| |
* | Fix documentation mistakesJanko Marohnić2012-08-212-45/+45
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-08-161-1/+13
|\
| * copy edits [ci skip]Vijay Dev2012-08-161-6/+7
| |
| * Document the namespacing of controller actions per this discussion:schneems2012-08-091-0/+11
| | | | | | https://github.com/rails/journey/issues/40
* | Indentation should consider line number character count.Lucas Uyezu2012-08-131-2/+2
| |
* | Add support for start_hour and end_hour options in select_hour helperEvan Tann2012-08-131-1/+11
| | | | | | | | Updated documentation to demonstrate start_hour and end_hour options
* | Grammar fix in ActionView docs/commentsEdward Ocampo-Gooding2012-08-121-1/+1
| |
* | Ensure option_html_attributes does not modify the given option hashesCarlos Antonio da Silva2012-08-111-1/+1
| | | | | | | | We can avoid creating extra hashes with #merge, and use #merge! instead.
* | Simplify html attributes generation for options_for_selectCarlos Antonio da Silva2012-08-111-3/+5
| | | | | | | | | | | | | | Further simplify the option_html_attributes method after the changes introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the html options here (since they're going to be escaped down the chain in content tag).
* | check for nil or empty record in form_forschneems2012-08-101-0/+1
| | | | | | | | if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem.
* | Do not mark strip_tags result as html_safeSantiago Pastorino2012-08-091-1/+1
| | | | | | | | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465
* | Allow data attributes to be set as a first-level option for form_for, so you ↵David Heinemeier Hansson2012-08-081-0/+19
| | | | | | | | can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH*
* | Modernize the documentation for view caching somewhatDavid Heinemeier Hansson2012-08-081-16/+16
| |
* | Deprecate `button_to_function` and `link_to_function` helpers.Rafael Mendonça França2012-08-071-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We recommend the use of Unobtrusive JavaScript instead. For example: link_to "Greeting", "#", :class => "nav_link" $(function() { $('.nav_link').click(function() { // Some complex code return false; }); }); or link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link" for simple cases. This reverts commit 3acdd652e9fe99481c879c84c5807a84eb9ad724.
* | Revert "Merge pull request #7033 from kron4eg/master". Not a a fan at all of ↵David Heinemeier Hansson2012-08-071-10/+4
| | | | | | | | | | | | | | what this makes ERB files look like. This reverts commit 46b8bceedd3e47169c50a04c93161424909c75fb, reversing changes made to 2f58795e783150f2e1b1f6c64e305703f0061129.
* | Restoring the '%' trim mode for ERb templates, allowing for a leading ↵Artiom Di2012-08-071-4/+10
| | | | | | | | percent sign on a line to indicate non-inserted Ruby code.
* | Rearrange example output of javascript_include_tagPrem Sichanugrist2012-08-061-2/+2
| |
* | Do not include application.js if it doesn't existsPrem Sichanugrist2012-08-061-4/+7
|/ | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory.
* Use content_tag here instead of manually building HTMLSantiago Pastorino2012-08-031-2/+6
|
* load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
|
* load active_support/core_ext/module/delegation in active_support/railsXavier Noria2012-08-022-2/+0
|
* load active_support/core_ext/class/attribute in active_support/railsXavier Noria2012-08-024-4/+0
|
* load active_support/concern in active_support/railsXavier Noria2012-08-022-2/+0
|
* load active_support/core_ext/object/blank in active_support/railsXavier Noria2012-08-0211-11/+0
|
* Check validity of options[:as] just onceJosé Valim2012-08-021-12/+18
|
* Improve error handling when using partial name with hyphen. Fix #7079kennyj2012-08-031-7/+12
|
* flushing output should write to the stream rather than mutating the response ↵Aaron Patterson2012-07-291-1/+1
| | | | object
* Replace the flush parameter with a Hash.Lucas Mazza2012-07-241-4/+4
|
* Merge pull request #7123 from nashby/data-in-optionsRafael Mendonça França2012-07-221-1/+1
|\ | | | | don't escape options in option_html_attributes method
| * don't escape options in option_html_attributes methodVasiliy Ermolovich2012-07-221-1/+1
| | | | | | | | | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options
* | Add back `:disable_with` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-2/+39
| |
* | Add back `:confirm` and change deprecation horizon to 4.1Carlos Galdino + Rafael Mendonça França2012-07-212-0/+56
|/
* Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` optionCarlos Galdino2012-07-182-46/+21
| | | | | | | | | This applies to the following helpers: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag`
* Common behavior with adding formats to lookup_context for TemplateRenderer ↵Dmitry Vorotilin2012-07-184-4/+16
| | | | and PartialRenderer
* add second t to overwrittenEvan Travers2012-07-121-2/+2
| | | | fixing a misspelling in the documentation
* Fixed bug creating invalid HTML in select optionsRusty Geldmacher2012-07-102-3/+3
| | | | | | When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-07-071-1/+1
|\