Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | These are already required through AS/rails | Akira Matsuda | 2013-01-06 | 2 | -2/+0 |
| | | | | | | | * core_ext/object/blank * concern * core_ext/class/attribute * deprecation | ||||
* | Merge pull request #8777 from goshakkk/delegate-class | Andrew White | 2013-01-06 | 1 | -1/+1 |
|\ | | | | | Delegate to :class rather than 'self.class' | ||||
| * | delegate to :class rather than 'self.class' | Gosha Arinich | 2013-01-06 | 1 | -1/+1 |
| | | |||||
* | | Refactor the logic that checks whether or not to emit the hidden id field | Carlos Antonio da Silva | 2013-01-06 | 1 | -7/+6 |
| | | | | | | | | | | By checking for object.persisted? first, we avoid the hash lookups for new objects. | ||||
* | | Move the hidden :id field logic to where it belongs to | Carlos Antonio da Silva | 2013-01-06 | 1 | -6/+9 |
| | | | | | | | | | | | | | | | | When dealing with nested forms, Rails automatically generates a hidden field with the id value of the current object being generated by fields_for. This logic was inside the method that's available from the template object, but we just need it when really dealing with nested attributes, so moving the code to here makes more sense. | ||||
* | | Eliminate the usage of parent_builder option from form_for | Carlos Antonio da Silva | 2013-01-06 | 1 | -19/+15 |
| | | | | | | | | Just use it internally from fields_for until we come up with a better solution. | ||||
* | | Do not call fields_for from form_for, to avoid instantiating two builders | Carlos Antonio da Silva | 2013-01-06 | 1 | -5/+5 |
| | | |||||
* | | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 1 | -8/+6 |
|/ | |||||
* | Fix documentation to content_tag_for [ci skip] | Rafael Mendonça França | 2013-01-05 | 1 | -2/+2 |
| | |||||
* | Merge pull request #8705 from amparo-luna/change_update_attributes_to_update | Guillermo Iguaran | 2013-01-03 | 3 | -6/+6 |
|\ | | | | | Rename update_attributes method to update | ||||
| * | Change docs to use update instead of update_attributes | Amparo Luna + Guillermo Iguaran | 2013-01-03 | 3 | -6/+6 |
| | | |||||
* | | Fix typo on form_tag_helper.rb | Paulo Luis Franchini Casaretto | 2013-01-03 | 1 | -1/+1 |
| | | | | | | | | The inline documentantion had a typo that was somewhat confusing. | ||||
* | | take into account multipart when calculating tag attributes | Aaron Patterson | 2013-01-02 | 1 | -4/+7 |
| | | |||||
* | | ask the form builder for form tag attributes | Aaron Patterson | 2013-01-02 | 1 | -2/+3 |
| | | |||||
* | | do not mutate the options hash (when we do not need to) | Aaron Patterson | 2013-01-02 | 1 | -2/+2 |
|/ | |||||
* | Make content_tag_for work without block | Rafael Mendonça França | 2013-01-02 | 1 | -1/+5 |
| | | | | This is version of #8640 for master | ||||
* | formatted_code_for should be private | Guillermo Iguaran | 2012-12-31 | 1 | -12/+12 |
| | |||||
* | Add style to AV::Template::Error exception page | Guillermo Iguaran | 2012-12-31 | 1 | -4/+12 |
| | |||||
* | Inherit from MiniTest::Unit::TestCase instead of MiniTest::Spec | Rafael Mendonça França | 2012-12-31 | 1 | -3/+0 |
| | |||||
* | Extract the component rendering of collection_radio_buttons and | Rafael Mendonça França | 2012-12-26 | 2 | -2/+14 |
| | | | | | | | | | | | | | | | | | | | | | | collection_check_boxes to a private method. It will make easier to extend. Example: class CollectionRadioButtons < ActionView::Helpers::Tags::CollectionRadioButtons include CollectionExtensions def render wrap_rendered_collection(super, @options) end private def render_component(builder) builder.radio_button + builder.label(:class => "collection_radio_buttons") end end | ||||
* | Fix collection_radio_buttons with the option `:checked` with value of | Rafael Mendonça França | 2012-12-26 | 1 | -1/+2 |
| | | | | `false` | ||||
* | fetch highlighter option only when needed | Nihad Abbasov | 2012-12-24 | 1 | -2/+2 |
| | |||||
* | Digestor explicit dependency should not contain trailing whitespace | Brian Alexander | 2012-12-21 | 1 | -1/+1 |
| | | | | test for rails/rails#8586 | ||||
* | Remove obfuscation support from mail_to helper | Nick Reed | 2012-12-18 | 1 | -54/+12 |
| | | | | | | Removes support for :encode, :replace_at, and :replace_dot options from the mail_to helper. Support for these options has been extracted to the 'actionview-encoded_mail_to' gem. | ||||
* | handle protocol option in stylesheet_link_tag and javascript_include_tag | Vasiliy Ermolovich | 2012-12-18 | 1 | -2/+6 |
| | | | | closes #8388 | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-12-15 | 1 | -0/+412 |
|\ | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_helper.rb railties/lib/rails/info_controller.rb | ||||
| * | repeating documentation for form helpers | Thiago Pinto | 2012-12-09 | 1 | -18/+406 |
| | | |||||
* | | Merge pull request #8510 from thedarkone/thread_safety_improvements | Aaron Patterson | 2012-12-14 | 4 | -48/+41 |
|\ \ | | | | | | | Thread safety improvements | ||||
| * | | Replace some global Hash usages with the new thread safe cache. | thedarkone | 2012-12-14 | 4 | -48/+41 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler. | ||||
* | | | Improve the documentation of cache_if and cache_unless | Rafael Mendonça França | 2012-12-14 | 1 | -4/+7 |
| | | | |||||
* | | | Merge pull request #8497 from acapilleri/conditional_cache | Rafael Mendonça França | 2012-12-14 | 1 | -12/+24 |
|\ \ \ | | | | | | | | | | | | | Removed :if / :unless conditions to fragment cache in favour of *cache_i... | ||||
| * | | | Removed :if and :unless from fragment cache option in favour of | Angelo capilleri | 2012-12-14 | 1 | -12/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | cache_if(condition, option, &block) and cache_unless(condition, option, &block). In the PR #8371 was introduced conditional options :if and :unless in the cache method. Example: <%= cache @model, if: some_condition(@model) do %> ... <%end%> This is a good feature but *cache_if* and and *cache_unless* are more concise and close to the standard of rails view helpers (ex: link_to_if and link_to_unless). Example: <%= cache_if condition, @model do %> ... <%end%> | ||||
* | | | | Add missing require. | Rafael Mendonça França | 2012-12-13 | 2 | -0/+3 |
|/ / / | | | | | | | | | | | | | I was trying to use those files without Rails and that require was missing. | ||||
* / / | Remove deprecation message from Action Pack | Carlos Antonio da Silva | 2012-12-11 | 1 | -1/+1 |
|/ / | | | | | | | | | Related to the deprecation of Time.utc_time in favor of Time.utc, in 48583f8bf74d1cefefea3cd6591bd546a9eaff6c. | ||||
* / | Revert "API reader should look elsewhere for helper instructions" | Vijay Dev | 2012-12-09 | 1 | -24/+0 |
|/ | | | | | | | | | This reverts commit ba2d867b2961b5ef72aad353c2d647b04654cbe3. Reason: https://github.com/lifo/docrails/commit/ba2d867b2961b5ef72aad353c2d647b04654cbe3#commitcomment-2276670 [ci skip] | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-12-08 | 2 | -2/+40 |
|\ | |||||
| * | API reader should look elsewhere for helper instructions | Thiago Pinto | 2012-12-06 | 1 | -0/+24 |
| | | |||||
| * | complementary options guidelines for f.file_field and file_field_tag | Thiago Pinto | 2012-12-06 | 2 | -0/+8 |
| | | |||||
| * | adding example for f.file_input | Thiago Pinto | 2012-12-06 | 1 | -0/+3 |
| | | |||||
| * | adding example for f.file_input | Thiago Pinto | 2012-12-06 | 1 | -0/+3 |
| | | |||||
| * | correct bad jquery syntax | Thiago Pinto | 2012-12-06 | 1 | -2/+2 |
| | | |||||
* | | Allow fragment cache to accept :if and :unless options | Fabrizio Regini | 2012-12-05 | 1 | -1/+13 |
|/ | | | | [Stephen Ausman + Fabrizio Regini] | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-12-04 | 13 | -263/+228 |
|\ | | | | | | | | | Conflicts: guides/source/migrations.md | ||||
| * | copy edits [ci skip] | Vijay Dev | 2012-12-04 | 4 | -27/+18 |
| | | |||||
| * | Cleans and removes 'Examples' tag [ci skip] | Alvaro Pereyra | 2012-12-01 | 1 | -2/+0 |
| | | |||||
| * | Cleans and removes useless 'Examples' tag [ci skip] | Alvaro Pereyra | 2012-12-01 | 1 | -48/+43 |
| | | |||||
| * | Add documentation to AssetTagHelper#image_alt [ci skip] | Florent Guilleux | 2012-12-01 | 1 | -0/+3 |
| | | |||||
| * | Fixes wrong typo on FormHelper [ci skip] | Alvaro Pereyra | 2012-12-01 | 1 | -1/+1 |
| | | |||||
| * | Cleans documentation from Helpers [ci skip] | Alvaro Pereyra | 2012-12-01 | 5 | -121/+98 |
| | | |||||
| * | Improves documentation of Capture helper [ci skip] | Alvaro Pereyra | 2012-12-01 | 2 | -14/+13 |
| | |