aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
...
| * Remove ActiveModel dependency from ActionPackGuillermo Iguaran2012-06-301-13/+8
| | | | | | | | | | | | | | | | ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key).
* | removing the AV::Base.helpers class attribute as it is not needed.Nick Sutterer2012-06-291-1/+0
| |
* | remove AV.prepare and move all helper-related logic into the controller. ↵Nick Sutterer2012-06-291-16/+0
|/ | | | | | this decouples the view since it no longer knows about routes internals. this is a result of an ongoing discussion at https://github.com/rails/rails/pull/6826.
* :update_details method no more exists on @lookup_contextAkira Matsuda2012-06-261-2/+1
| | | | the method has gone in this commit: 119e9e2dafb0cdc5b85613b730333679aef534af
* Do not propagate the :raise option to AS number helpersCarlos Antonio da Silva2012-06-241-7/+19
| | | | | ActiveSupport::NumberHelper does not make use of :raise, so there's no need to propagate it down.
* eliminating another string subclassAaron Patterson2012-06-221-3/+7
|
* fix some accidental nilsAaron Patterson2012-06-222-3/+3
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-06-222-1/+2
|\
| * fixes a few mistakes in api docs [ci skip]Vijay Dev2012-06-221-1/+1
| |
| * Fix misprint in UrlHelper moduleAlexey Vakhov2012-06-181-1/+1
| |
| * Add rdoc to phone_field Gaurish Sharma2012-06-161-0/+1
| | | | | | [API docs](http://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-phone_field) for `phone_field` provide no information on what the method actually does. no description nor access to source code. so added this
* | use mutex_m rather than use a delegate systemAaron Patterson2012-06-211-6/+3
| |
* | Merge pull request #6428 from pinetops/resolver_concurrency_fixYehuda Katz2012-06-211-19/+76
|\ \ | | | | | | Make the Resolver template cache threadsafe
| * | Improve the readability of the Resolver change detection codeTom Clarke2012-05-221-11/+19
| | |
| * | More granular locking of the Resolver template cacheTom Clarke2012-05-211-5/+23
| | | | | | | | | | | | | | | | | | | | | In order to avoid holding a global lock when doing template resolution, instead add individual locks on a per cache entry basis. The global lock is now only used for manipulation of the main cache data structure.
| * | Make the Resolver template cache threadsafe - closes #6404Tom Clarke2012-05-211-19/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access.
* | | stop subclassing stringAaron Patterson2012-06-211-3/+10
| | |
* | | add :nodoc: to AV StylesheetIncludeTag, JavascriptIncludeTag and AssetIncludeTagFrancesco Rodriguez2012-06-193-4/+4
| | |
* | | Respect absolute paths in compute_source_path.Steve Klabnik2012-06-161-1/+7
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using compute_source_path to determine the full path of an asset, if our source begins with '/', we don't want to include the directory. Examples are illustrative: > compute_source_path("foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/stylesheets/foo.css" > compute_source_path("/foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/foo.css" Before this patch, the second example would return the same as the first. Fixes #5680.
* | One-liner code for logger in ActionView::Helpers::ControllerHelperDmitry Vorotilin2012-06-051-5/+1
| |
* | Merge pull request #6631 from yuki24/use_block_in_button_helperJosé Valim2012-06-051-2/+13
|\ \ | | | | | | Accept a block in FormHelper#button
| * | accept a block in button helper.Yuki Nishijima2012-06-051-2/+13
| | |
* | | Metal controller doesn't have logger method, check it and then delegateDmitry Vorotilin2012-06-051-2/+8
|/ /
* | Allow to use mounted helpers in ActionView::TestCasePiotr Sarnacki2012-06-011-1/+2
| | | | | | | | | | Similarly to 6525002, this allows to use routes helpers for mounted helpers, but this time in ActionView::TestCase
* | Simplify link_to using content_tagCarlos Antonio da Silva2012-05-311-12/+6
| | | | | | | | Add some tests for link_to with blocks and escaping content.
* | Make link_to arguments explicitCarlos Antonio da Silva2012-05-311-8/+4
| |
* | Make button_to arguments explicit and refactor a bitCarlos Antonio da Silva2012-05-311-10/+6
| | | | | | | | Prefer Hash#[]= over Hash#merge when setting a value.
* | accept a block in button_to helperSergey Nartimov2012-05-301-3/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use a block in button_to helper if button text is hard to fit into the name parameter, e.g.: <%= button_to [:make_happy, @user] do %> Make happy <strong><%= @user.name %></strong> <% end %> # => "<form method="post" action="/users/1/make_happy" class="button_to"> # <div> # <button type="submit"> # Make happy <strong>Name</strong> # </button> # </div> # </form>"
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-301-1/+1
|\ \
| * | fix typo in render_template [ci skip]Brent Vatne2012-05-291-1/+1
| | |
* | | Review requires from number helperCarlos Antonio da Silva2012-05-281-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | Some of these requires are now only necessary in ActiveSupport::NumberHelper. Add hash/keys require due to symbolize_keys usage in number helpers. Also remove some whitespaces. Closes #6414
* | | Parse float value only once in number helpersCarlos Antonio da Silva2012-05-281-11/+11
| | | | | | | | | | | | | | | Refactor number helpers output with safety handling to call float parsing only once. Also remove 'erb' require.
* | | Moving NumberHelpers from ActionView to ActiveSupportAndrew Mutz2012-05-272-285/+38
|/ /
* | Add `:escape` option for `truncate`Rafael Mendonça França2012-05-261-2/+5
| | | | | | | | This options can be used to not escape the result by default.
* | Update the documentation and add CHANGELOG entryRafael Mendonça França2012-05-261-3/+3
| |
* | Test that the block used in truncate is escaped if it is not HTML safeRafael Mendonça França2012-05-261-13/+12
| | | | | | | | Refactoring the truncate method to not do a sort-circuit return
* | Truncate now has the ability to receive a html option that allows it to call ↵Li Ellis Gallardo2012-05-261-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | rails helpers. This way if my text is long I don't have to do something like this: .text = truncate(@text, :length => 27) if @text.size >= 27 = link_to "continue", notes_path, ....."")
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-231-1/+1
|\ \
| * | Revert "Remove blank trailing comments"Vijay Dev2012-05-2313-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit fa6d921e11363e9b8c4bc10f7aed0b9faffdc33a. Reason: Not a fan of such massive changes. We usually close such changes if made to Rails master as a pull request. Following the same principle here and reverting. [ci skip]
| * | Fix incorrect example for fields_for - without the '=' it will not output ↵David Morton2012-05-221-1/+1
| | | | | | | | | | | | anything.
| * | Remove blank trailing commentsHenrik Hodne2012-05-2013-39/+0
| | | | | | | | | | | | | | | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed.
* | | Refactor date related helpersCarlos Galdino2012-05-226-50/+26
| | |
* | | Merge pull request #6359 from carlosgaldino/add-html5-inputsJeremy Kemper2012-05-228-0/+248
|\ \ \ | | | | | | | | Add HTML5 color and date/time inputs
| * | | Add several HTML5 input helpersCarlos Galdino2012-05-217-0/+205
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The input types added are: - input[type="month"] - input[type="week"] - input[type="datetime"] - input[type="datetime-local"]
| * | | Add HTML5 input[type="color"] helperCarlos Galdino2012-05-214-0/+43
| | | |
* | | | Fixed typo new_defautls -> new_defaults.Philip Arndt2012-05-231-2/+2
| |_|/ |/| | | | | | | | | | | * Added tests for 'else' case in ActionView::Helpers::TranslationHelper#wrap_translate_defaults * Also updated the testing syntax of translation.html_safe? asserts to provide better output upon failure.
* | | Revert "Merge pull request #6425 from pinetops/resolver_concurrency_fix"José Valim2012-05-211-68/+19
| | | | | | | | | | | | | | | This reverts commit 254c04286c5916ae7f91eb6e173b312e7a74e364, reversing changes made to 513a0525c24c2944630acfa465b22cd2f4601adf.
* | | Merge pull request #6425 from pinetops/resolver_concurrency_fixAaron Patterson2012-05-211-19/+68
|\ \ \ | |/ / |/| | Resolver concurrency fix
| * | More granular locking of the Resolver template cacheTom Clarke2012-05-211-5/+23
| | | | | | | | | | | | | | | | | | | | | In order to avoid holding a global lock when doing template resolution, instead add individual locks on a per cache entry basis. The global lock is now only used for manipulation of the main cache data structure.
| * | Make the Resolver template cache threadsafe - closes #6404Tom Clarke2012-05-211-19/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access.