aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Unify routes naming by renaming router to routesPiotr Sarnacki2010-07-023-7/+7
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* s/escape_once/html_escape/, since html safety is the contract that now says ↵Xavier Noria2010-06-303-16/+19
| | | | whether something has to be escaped
* url_for no longer escapes HTML, the :escape option is also goneXavier Noria2010-06-303-17/+8
| | | | Rationale: url_for is just a path/URL generator, it is the responsability of the caller to escape conveniently HTML needs it, JavaScript needs different escaping, a text mail needs no escaping at all, etc.
* Revert "Revert "Name compiled render methods". This caused several failures ↵Jeremy Kemper2010-06-291-8/+11
| | | | | | | | on AP test suite for 1.9.2." This reverts commit 9013227e00895ac95f29077229ec2fb156f450b0. minitest was 'running' compiled templates beginning with test!
* Rename _snowman_ to _snowman to be in sync with _method and _csrf_token.José Valim2010-06-291-1/+1
|
* Revert "Name compiled render methods". This caused several failures on AP ↵José Valim2010-06-291-11/+8
| | | | | | test suite for 1.9.2. This reverts commit 2c4f8aae5ca8489bb3e47712f50b3f57015811d9.
* Slice new buffer from beginning of old buffer to skip encoding special caseJeremy Kemper2010-06-281-3/+1
|
* Name compiled render methodsJeremy Kemper2010-06-281-8/+11
|
* returning -> tapJeremy Kemper2010-06-281-5/+4
|
* Restores the escaping of urls generated from hashes. [#4765 state:resolved]Andrew White2010-06-281-1/+1
| | | | | | | | | | | | | | HTML specifications recommend the escaping of urls in web pages, which url_for does by default for string urls and consquently urls generated by path helpers as these return strings. Hashes passed to url_for are not escaped by default and this commit reverses this default so that they are escaped. Undoes the changes of this commit: http://github.com/rails/rails/commit/1b3195b63ca44f0a70b61b75fcf4991cb2fbb944 Signed-off-by: José Valim <jose.valim@gmail.com>
* Convert instance_variables to symbols before excluding internal vars [#4965 ↵rohit2010-06-281-1/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Small typowycats2010-06-271-1/+1
|
* Fix several known web encoding issues:wycats2010-06-271-3/+12
| | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test
* AV::logger returns AC::logger if it's defined, workaround meanwhile AV ↵Santiago Pastorino2010-06-281-2/+3
| | | | | | doesn't have it's own logger Signed-off-by: José Valim <jose.valim@gmail.com>
* Do not wrap hidden fields with error proc [#4962 state:resolved]Carlos Antonio da Silva2010-06-252-3/+16
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵José Valim2010-06-244-30/+28
| | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
* Avoid using Pathname on Resolver and AS::Dependencies.José Valim2010-06-241-1/+1
|
* Expose view via the view() method in AV::TestCase::BehaviorDavid Chelimsky2010-06-231-5/+8
| | | | | | | | | | - was exposed as _view, which suggested it was private - left _view as an alias of view as not to break any extensions that are relying on _view [#4932 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* In ActionView::TestCase::Behavior, assign variables right beforeDavid Chelimsky2010-06-232-2/+7
| | | | | | | | | | | rendering the view. - Previously, _assigns were locked down the first time _view was referenced. [#4931 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* make text_field and hidden_field omit the value attribute if the developer ↵Jeff Dean2010-06-231-4/+4
| | | | | | explicitly passes in :value => nil [#4839 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Tidy up asset tag a bit and make railties tests green again.José Valim2010-06-232-27/+22
|
* refactored the javascript asset tag helpers and moved the default scripts ↵Josh Kalderimis2010-06-232-14/+14
| | | | | | setup within the railtie Signed-off-by: José Valim <jose.valim@gmail.com>
* update the list of instance variables that are excluded from assigns in view ↵David Chelimsky2010-06-221-9/+10
| | | | | | | | tests [#4930 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* adds minus to value part of id [#4862 state:resolved]RainerBlessing2010-06-221-1/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add support for specifying locals in view tests with assert template [#4927 ↵David Chelimsky2010-06-221-0/+15
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* removed 'unless const_defined?' code smellJosh Kalderimis2010-06-215-24/+20
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-06-206-19/+26
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * Fixed date_select date_separator when discard_month and/or discard_day are ↵Thibaud Guillaume-Gentil2010-06-201-2/+4
| | | | | | | | | | | | true [#4856 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Make sure a namespaced <%= render form %> still renders the _form partial ↵Jan De Poorter2010-06-201-1/+1
| | | | | | | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * Support render_template in view tests. Useful for specifying whichDavid Chelimsky2010-06-201-0/+1
| | | | | | | | | | | | | | | | partials are rendered under different conditions. [#4903 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * option_groups_from_collection_for_select should return HTML-safe string ↵Wincent Colaiuta2010-06-191-1/+1
| | | | | | | | | | | | [#4879 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com>
| * form_for without :html and with :remote should not errorDavid Genord II2010-06-181-1/+1
| | | | | | | | | | | | [#4902 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
| * Make text_helpers methods which return valid html to return it as safe and ↵Santiago Pastorino2010-06-171-6/+14
| | | | | | | | | | | | | | | | sanitize the input always unless :sanitize => false is set [#4825 state:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
| * truncate() should not try to produce HTML-safe outputWincent Colaiuta2010-06-171-8/+4
| | | | | | | | | | | | | | | | | | | | As discussed in Lighthouse ticket #4825 and ticket #4878, the truncate() method cannot guarantee safe output for all possible inputs/offsets, so it is best to leave the output unsafe so that it gets escaped when used in a view. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
* | Final touches and fixes.Rizwan Reza2010-06-217-1/+9
| |
* | Action View is now titled.Rizwan Reza2010-06-211-1/+1
| |
* | Action View is now titled.Rizwan Reza2010-06-213-0/+5
| |
* | Added title to some other files in actionpack/lib/action_viewRizwan Reza2010-06-167-0/+9
| |
* | Added titles and description.Rizwan Reza2010-06-167-17/+37
| |
* | Adds title and description where needed.Rizwan Reza2010-06-1615-22/+48
| |
* | Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-157-11/+11
|\ \ | |/ |/|
| * Fix a bunch of minor spelling mistakesEvgeniy Dolzhenko2010-06-117-11/+11
| |
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵Xavier Noria2010-06-143-5/+5
| | | | | | | | not "ActiveRecord"
* | truncate safe method description changesNeeraj Singh2010-06-141-1/+1
| |
* | Merge branch 'master' of git://github.com/rails/railsRizwan Reza2010-06-142-2/+2
|\ \
| * | render(:inline) in a layout before yield replaces original contentNeeraj Singh2010-06-131-1/+1
| | | | | | | | | | | | | | | | | | [#4777 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
| * | removes spurious .rb in requireXavier Noria2010-06-121-1/+1
| | |
* | | truncate documentation an examples added for :safe optionSantiago Pastorino2010-06-131-0/+10
|/ /
* | Merge remote branch 'docrails/master'Xavier Noria2010-06-121-1/+9
|\ \
| * | adds missing require for having ActiveSupport::InheritableOptions definedXavier Noria2010-06-111-0/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 07:42:14 +0000