aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-101-1/+1
|\
| * Update capture_helper.rbJess Brown2013-03-061-1/+1
| | | | | | if there's content for the right column, then we need the two-column class, if not the one-column
* | Fix incorrectly appended square brackets to a multiple select boxOlek Janiszewski2013-03-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If an explicit name has been given and it already ends with "[]" Before: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][][]" ...> After: select(:category, [], {}, multiple: true, name: "post[category][]") # => <select name="post[category][]" ...>
* | Fix hash spaces and use 1.9 style hash [ci skip]Carlos Antonio da Silva2013-03-071-1/+1
| |
* | Merge pull request #9464 from jcoyne/assert_template_fileRafael Mendonça França2013-03-072-1/+2
|\ \ | | | | | | Allow use of assert_template with the :file option.
| * | Allow use of assert_template with the :file option.Justin Coyne2013-03-012-1/+2
| | | | | | | | | | | | This worked in Rails 3.2, but was a regression in 4.0.0.beta1
* | | Typo in comment to ActionView::Resolver#find_allRKushnir2013-03-061-1/+1
| | |
* | | Use gsub intead of tr when the to_str is longer than the from_strrobertomiranda2013-03-051-1/+1
| |/ |/|
* | change useless gsub to trrobertomiranda2013-03-051-1/+1
| |
* | change useless gsub to deleteBenjamin Sullivan2013-03-051-1/+1
|/
* Merge pull request #9366 from killthekitten/fix-content_for-regressionRafael Mendonça França2013-02-281-1/+1
|\ | | | | Fix for #9360 content_for regression
| * Fix #9360 regression in content_forNikolay Shebanov2013-02-251-1/+1
| |
* | remove private attribute? warningFrancesco Rodriguez2013-02-261-1/+3
| |
* | Merge pull request #8530 from dasch/dependency-trackersDavid Heinemeier Hansson2013-02-252-44/+98
|\ \ | | | | | | Custom dependency trackers for the template digestor
| * | Register trackers on extensions, not handlersDaniel Schierbeck2013-02-201-6/+11
| | |
| * | Rename ErbTracker to ERBTrackerDaniel Schierbeck2013-02-201-2/+2
| | |
| * | Return an empty array if no tracker is foundDaniel Schierbeck2013-02-201-2/+7
| | |
| * | Use a thread safe hashDaniel Schierbeck2013-02-201-1/+3
| | |
| * | Allow registering custom dependency trackersDaniel Schierbeck2013-02-201-1/+14
| | |
| * | Extract dependency tracking from DigestorDaniel Schierbeck2013-02-202-44/+73
| | |
* | | Fix debug helper not inspecting on ExceptionBouke van der Bijl2013-02-231-1/+1
| | | | | | | | | The debug helper should inspect the object when it can't be converted to YAML, this behavior was changed in 8f8d8eb1465069e2ed9b6f2404aa9d02e785f534.
* | | Merge pull request #9334 from NARKOZ/time_tagAndrew White2013-02-211-1/+3
|\ \ \ | | | | | | | | use ISO 8601 format in time_tag helper
| * | | document setting custom datetime attribute for time_tag helperNihad Abbasov2013-02-221-0/+2
| | | |
| * | | fix time_tag helper and update tests to not rely on dynamically generated valuesNihad Abbasov2013-02-221-1/+1
| |/ / | | | | | | | | | | | | | | | | | | Before `time_tag Date.today` will return `<time datetime="2013-02-14T00:00:00+00:00">February 14, 2013</time>`. This commit fixes time_tag helper to use RFC-3339 full-date format (Y-m-d) in datetime attribute.
* | | completes pass over the AP changelog [ci skip]Xavier Noria2013-02-211-1/+1
| | |
* | | Revert "Revert "Merge pull request #4803 from lucascaton/master""Santiago Pastorino2013-02-211-2/+2
| |/ |/| | | | | This reverts commit 6871bd9818a9a7d9d8c7e21e253d64c0410fde1d.
* | Use #grep to filter priority zones when a regexp is givenCarlos Antonio da Silva2013-02-211-1/+1
| |
* | Use Array Difference to calculate the zones array, instead of iteratingCarlos Antonio da Silva2013-02-211-2/+2
| | | | | | | | It's faster, and doesn't force us to dup the timezones array.
* | Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-201-2/+2
|/ | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-191-1/+1
| | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-152-3/+3
|\ | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * Correct bullet content line wrappingTim "Roger" Harvey2013-02-121-1/+1
| | | | | | | | | | | | The `:prefix` bullet content was not properly wrapping, dropping to the following line because the additional content was not indented properly. With this change, it will now display properly the way `:discard_type` does.
| * Fixing the examples for button_toMarc Baumbach2013-02-061-2/+2
| | | | | | The examples do not generate the output they intend to due to not explicitly declaring the hash separations. This causes it to be treated as one parameter instead of the intended two parameters.
* | Improve changelog entry from #9221 [ci skip]Carlos Antonio da Silva2013-02-111-3/+3
| |
* | Improve img alt attribute for screen readersthenickcox2013-02-091-3/+17
| | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method
* | partials inside directory work with `assert_template`Yves Senn2013-02-041-1/+1
| | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'.
* | descriptive `assert_template` error when partial wasn't renderedYves Senn2013-02-041-0/+4
|/ | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error.
* Missing or unneeded require extract_optionsAkira Matsuda2013-02-013-1/+2
|
* Fix `content_tag_for` with array html option.Semyon Perepelitsa2013-01-311-1/+1
| | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item [&quot;foo&quot;, &quot;bar&quot;]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>'
* Merge pull request #9096 from tricknotes/fix-code-commentRafael Mendonça França2013-01-281-4/+4
|\ | | | | Fix code comment
| * Fix JavaScript syntax in code comment [ci skip]Ryunosuke SATO2013-01-291-4/+4
| |
* | Make current_url? work with a HEAD methodMichiel Sikkes2013-01-281-1/+1
|/ | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves.
* Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-281-2/+2
|
* Use already defined Encoding constants rather than creating one-trip StringsAkira Matsuda2013-01-282-2/+2
|
* Merge remote-tracking branch 'docrails/master'Xavier Noria2013-01-264-2/+75
|\ | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
| * generic pass before merging docrailsXavier Noria2013-01-263-417/+55
| |
| * :scissors: "raise" duplicationAkira Matsuda2013-01-261-2/+1
| |
| * fix broken examples format in image_tag helper [ci skip]Francesco Rodriguez2013-01-181-0/+2
| |
| * repeating documentation for option form helpersThiago Pinto2013-01-171-0/+286
| |
| * repeating documentation for date and time form helpersThiago Pinto2013-01-171-0/+148
| |