Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 11 | -11/+0 |
| | |||||
* | Check validity of options[:as] just once | José Valim | 2012-08-02 | 1 | -12/+18 |
| | |||||
* | Improve error handling when using partial name with hyphen. Fix #7079 | kennyj | 2012-08-03 | 1 | -7/+12 |
| | |||||
* | flushing output should write to the stream rather than mutating the response ↵ | Aaron Patterson | 2012-07-29 | 1 | -1/+1 |
| | | | | object | ||||
* | Replace the flush parameter with a Hash. | Lucas Mazza | 2012-07-24 | 1 | -4/+4 |
| | |||||
* | Merge pull request #7123 from nashby/data-in-options | Rafael Mendonça França | 2012-07-22 | 1 | -1/+1 |
|\ | | | | | don't escape options in option_html_attributes method | ||||
| * | don't escape options in option_html_attributes method | Vasiliy Ermolovich | 2012-07-22 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options | ||||
* | | Add back `:disable_with` and change deprecation horizon to 4.1 | Carlos Galdino + Rafael Mendonça França | 2012-07-21 | 2 | -2/+39 |
| | | |||||
* | | Add back `:confirm` and change deprecation horizon to 4.1 | Carlos Galdino + Rafael Mendonça França | 2012-07-21 | 2 | -0/+56 |
|/ | |||||
* | Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` option | Carlos Galdino | 2012-07-18 | 2 | -46/+21 |
| | | | | | | | | | This applies to the following helpers: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag` | ||||
* | Common behavior with adding formats to lookup_context for TemplateRenderer ↵ | Dmitry Vorotilin | 2012-07-18 | 4 | -4/+16 |
| | | | | and PartialRenderer | ||||
* | add second t to overwritten | Evan Travers | 2012-07-12 | 1 | -2/+2 |
| | | | | fixing a misspelling in the documentation | ||||
* | Fixed bug creating invalid HTML in select options | Rusty Geldmacher | 2012-07-10 | 2 | -3/+3 |
| | | | | | | When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-07-07 | 1 | -1/+1 |
|\ | |||||
| * | use config.action_controller instead of ActionController::Base in example ↵ | Nick Howard | 2012-06-30 | 1 | -1/+1 |
| | | | | | | | | code for asset_tag_helper | ||||
* | | Merge pull request #6904 from guilleiguaran/remove-amo-dependency-in-ap | Carlos Antonio da Silva | 2012-06-30 | 1 | -13/+8 |
|\ \ | |/ |/| | Remove Active Model dependency from Action Pack | ||||
| * | Remove ActiveModel dependency from ActionPack | Guillermo Iguaran | 2012-06-30 | 1 | -13/+8 |
| | | | | | | | | | | | | | | | | ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key). | ||||
* | | removing the AV::Base.helpers class attribute as it is not needed. | Nick Sutterer | 2012-06-29 | 1 | -1/+0 |
| | | |||||
* | | remove AV.prepare and move all helper-related logic into the controller. ↵ | Nick Sutterer | 2012-06-29 | 1 | -16/+0 |
|/ | | | | | | this decouples the view since it no longer knows about routes internals. this is a result of an ongoing discussion at https://github.com/rails/rails/pull/6826. | ||||
* | :update_details method no more exists on @lookup_context | Akira Matsuda | 2012-06-26 | 1 | -2/+1 |
| | | | | the method has gone in this commit: 119e9e2dafb0cdc5b85613b730333679aef534af | ||||
* | Do not propagate the :raise option to AS number helpers | Carlos Antonio da Silva | 2012-06-24 | 1 | -7/+19 |
| | | | | | ActiveSupport::NumberHelper does not make use of :raise, so there's no need to propagate it down. | ||||
* | eliminating another string subclass | Aaron Patterson | 2012-06-22 | 1 | -3/+7 |
| | |||||
* | fix some accidental nils | Aaron Patterson | 2012-06-22 | 2 | -3/+3 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-22 | 2 | -1/+2 |
|\ | |||||
| * | fixes a few mistakes in api docs [ci skip] | Vijay Dev | 2012-06-22 | 1 | -1/+1 |
| | | |||||
| * | Fix misprint in UrlHelper module | Alexey Vakhov | 2012-06-18 | 1 | -1/+1 |
| | | |||||
| * | Add rdoc to phone_field | Gaurish Sharma | 2012-06-16 | 1 | -0/+1 |
| | | | | | | [API docs](http://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-phone_field) for `phone_field` provide no information on what the method actually does. no description nor access to source code. so added this | ||||
* | | use mutex_m rather than use a delegate system | Aaron Patterson | 2012-06-21 | 1 | -6/+3 |
| | | |||||
* | | Merge pull request #6428 from pinetops/resolver_concurrency_fix | Yehuda Katz | 2012-06-21 | 1 | -19/+76 |
|\ \ | | | | | | | Make the Resolver template cache threadsafe | ||||
| * | | Improve the readability of the Resolver change detection code | Tom Clarke | 2012-05-22 | 1 | -11/+19 |
| | | | |||||
| * | | More granular locking of the Resolver template cache | Tom Clarke | 2012-05-21 | 1 | -5/+23 |
| | | | | | | | | | | | | | | | | | | | | | In order to avoid holding a global lock when doing template resolution, instead add individual locks on a per cache entry basis. The global lock is now only used for manipulation of the main cache data structure. | ||||
| * | | Make the Resolver template cache threadsafe - closes #6404 | Tom Clarke | 2012-05-21 | 1 | -19/+50 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The Template cache in the Resolver can be accessed by multiple threads similtaneously in multi-threaded environments. The cache is implemented using a Hash, which isn't threadsafe in all VMs (notably JRuby). This commit extracts the cache to a new Cache class and adds mutexes to prevent concurrent access. | ||||
* | | | stop subclassing string | Aaron Patterson | 2012-06-21 | 1 | -3/+10 |
| | | | |||||
* | | | add :nodoc: to AV StylesheetIncludeTag, JavascriptIncludeTag and AssetIncludeTag | Francesco Rodriguez | 2012-06-19 | 3 | -4/+4 |
| | | | |||||
* | | | Respect absolute paths in compute_source_path. | Steve Klabnik | 2012-06-16 | 1 | -1/+7 |
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using compute_source_path to determine the full path of an asset, if our source begins with '/', we don't want to include the directory. Examples are illustrative: > compute_source_path("foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/stylesheets/foo.css" > compute_source_path("/foo", "stylesheets", "css") => "/Users/steve/src/my_app/public/foo.css" Before this patch, the second example would return the same as the first. Fixes #5680. | ||||
* | | One-liner code for logger in ActionView::Helpers::ControllerHelper | Dmitry Vorotilin | 2012-06-05 | 1 | -5/+1 |
| | | |||||
* | | Merge pull request #6631 from yuki24/use_block_in_button_helper | José Valim | 2012-06-05 | 1 | -2/+13 |
|\ \ | | | | | | | Accept a block in FormHelper#button | ||||
| * | | accept a block in button helper. | Yuki Nishijima | 2012-06-05 | 1 | -2/+13 |
| | | | |||||
* | | | Metal controller doesn't have logger method, check it and then delegate | Dmitry Vorotilin | 2012-06-05 | 1 | -2/+8 |
|/ / | |||||
* | | Allow to use mounted helpers in ActionView::TestCase | Piotr Sarnacki | 2012-06-01 | 1 | -1/+2 |
| | | | | | | | | | | Similarly to 6525002, this allows to use routes helpers for mounted helpers, but this time in ActionView::TestCase | ||||
* | | Simplify link_to using content_tag | Carlos Antonio da Silva | 2012-05-31 | 1 | -12/+6 |
| | | | | | | | | Add some tests for link_to with blocks and escaping content. | ||||
* | | Make link_to arguments explicit | Carlos Antonio da Silva | 2012-05-31 | 1 | -8/+4 |
| | | |||||
* | | Make button_to arguments explicit and refactor a bit | Carlos Antonio da Silva | 2012-05-31 | 1 | -10/+6 |
| | | | | | | | | Prefer Hash#[]= over Hash#merge when setting a value. | ||||
* | | accept a block in button_to helper | Sergey Nartimov | 2012-05-30 | 1 | -3/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make possible to use a block in button_to helper if button text is hard to fit into the name parameter, e.g.: <%= button_to [:make_happy, @user] do %> Make happy <strong><%= @user.name %></strong> <% end %> # => "<form method="post" action="/users/1/make_happy" class="button_to"> # <div> # <button type="submit"> # Make happy <strong>Name</strong> # </button> # </div> # </form>" | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-30 | 1 | -1/+1 |
|\ \ | |||||
| * | | fix typo in render_template [ci skip] | Brent Vatne | 2012-05-29 | 1 | -1/+1 |
| | | | |||||
* | | | Review requires from number helper | Carlos Antonio da Silva | 2012-05-28 | 1 | -4/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | Some of these requires are now only necessary in ActiveSupport::NumberHelper. Add hash/keys require due to symbolize_keys usage in number helpers. Also remove some whitespaces. Closes #6414 | ||||
* | | | Parse float value only once in number helpers | Carlos Antonio da Silva | 2012-05-28 | 1 | -11/+11 |
| | | | | | | | | | | | | | | | Refactor number helpers output with safety handling to call float parsing only once. Also remove 'erb' require. | ||||
* | | | Moving NumberHelpers from ActionView to ActiveSupport | Andrew Mutz | 2012-05-27 | 2 | -285/+38 |
|/ / | |||||
* | | Add `:escape` option for `truncate` | Rafael Mendonça França | 2012-05-26 | 1 | -2/+5 |
| | | | | | | | | This options can be used to not escape the result by default. |