| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It would embed array as string instead of joining it like `content_tag` does:
content_tag(:td, class: ["foo", "bar"]){}
#=> '<td class="foo bar"></td>'
Before:
content_tag_for(:td, item, class: ["foo", "bar"]){}
#=> '<td class="item ["foo", "bar"]" id="item_1"></td>'
After:
content_tag_for(:td, item, class: ["foo", "bar"]){}
#=> '<td class="item foo bar" id="item_1"></td>'
|
| |\
| |
| | |
Fix code comment
|
| | | |
|
| |/
|
|
|
|
| |
ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head
does not convert GET requests to HEAD requests so we need to do
checking for HEAD requests ourselves.
|
| | |
|
| | |
|
| |\
| |
| |
| |
| |
| | |
Conflicts:
actionpack/lib/action_view/helpers/form_options_helper.rb
guides/code/getting_started/app/controllers/comments_controller.rb
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The [following pull request](https://github.com/rails/rails/pull/8916) fixed
the block being passed to the appropriate helper method. However, the content
being passed into the block is generating repeated markup on the page due to
some weird ERb evaluation.
This commit tries to capture the block's generated output so the page isn't
flooded with markup.
[Rafael França + José Mota]
Closes #8936
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Historically serving assets from a mountable engine could be achieved by
running ActionDispatch::Static as a part of engine middleware stack or
to copy assets prefixed with an engine name. After introduction of
assets pipeline this is not needed as all of the assets are served or
compiled into main application's assets.
This commit removes the obsolete line making asset_path always generate
paths relative to the root or config.relative_url_root if it's set.
(closes #8119)
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
date.order is the only key in rails i18n that is required to be a
symbol. This patch allows for symbols or strings which means:
* No requirement for symbol type in .yml files. A future
YAML.safe_load wouldn't need to load symbols
* Rails could actually use json rather than yml as the backend
|
| | | |
|
| |\ \
| | |
| | | |
Rename :value to :selected for date_select, and add missing tests/docs
|
| | | |
| | |
| | |
| | |
| | | |
Add tests for time & datetime.
Add documentation.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
block. Breaks benchmark calls that return non-String values otherwise.
Revert "add benchmark helper that works in erb"
This reverts commit 904e544cc8f5846de7c31827bb5556c6a238c0de.
Conflicts:
actionpack/lib/action_view/helpers.rb
actionpack/lib/action_view/helpers/benchmark_helper.rb
actionpack/test/template/benchmark_helper_test.rb
|
| |\ \ \
| |/ /
|/| |
| | |
| | | |
Collection radio buttons and collection check boxes through FormBuilder render the provided block.
Closes #8897
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
the provided block.
In the case of having a form_for method being called, the block for each
collection would not be passed and thus the result expected was always the same.
This patch passes the block to the original method like it would be assumed.
|
| |/ / |
|
| |\ \
| | |
| | | |
Fixed nested fields bug when called with AssociationProxy
|
| | | |
| | |
| | |
| | | |
support in form helper
|
| | |/
|/| |
|
| |\ \
| | |
| | |
| | |
| | | |
Conflicts:
guides/source/getting_started.md
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 1a59a6dfdca217e31a52779d92aa56b67c6689cb.
I guess it's not a typo: https://github.com/jorlhuda/exceptron
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A declarative API for specifying dependencies that affect template
cache digest computation. In your controller, specify any of said
dependencies:
view_cache_dependency { "phone" if using_phone? }
When the block is evaluated, the resulting value is included in the
cache digest calculation, allowing you to generate different digests
for effectively the same template. (Mostly useful if you're mucking
with template load paths.)
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously rendering a partial without giving :object or :collection
would generate a local variable with the partial name by default.
This was noticed due to warnings in Ruby 2.0 of not used variables,
which turned out to be the generation of not used variables inside
partials that do not contain objects related to them.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
* core_ext/object/blank
* concern
* core_ext/class/attribute
* deprecation
|
| |\ \ \
| | | |
| | | | |
Delegate to :class rather than 'self.class'
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
By checking for object.persisted? first, we avoid the hash lookups for
new objects.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When dealing with nested forms, Rails automatically generates a hidden
field with the id value of the current object being generated by
fields_for. This logic was inside the method that's available from the
template object, but we just need it when really dealing with nested
attributes, so moving the code to here makes more sense.
|
| | | | |
| | | |
| | | |
| | | | |
Just use it internally from fields_for until we come up with a better solution.
|
| | | | | |
|
| |/ / / |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Rename update_attributes method to update
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | | |
The inline documentantion had a typo that was somewhat confusing.
|
| | | | | |
|
| | | | | |
|
| |/ / / |
|
