| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/
|
|
|
|
| |
Rails were including 'application.js' to the pack when using
`javascript_include_tag :all` even there's no application.js in the
public directory.
|
|
|
|
| |
This reverts commit 9dc57fe9c4807fc0ad4b1590a931891d9faa3164.
|
|
|
|
|
|
|
| |
This reverts commit 1aff7725c7a04cde202cca906208560a55409e6a.
Conflicts:
actionpack/CHANGELOG.md
|
|
|
|
|
|
|
|
|
|
|
| |
option"
Revert "Deprecate `:disable_with` in favor of `'data-disable-with'` option for `button_to` and `submit_tag` helpers."
This reverts commit fc092a9cba5fceec38358072e50e09250cf58840.
This reverts commit e9051e20aeb2c666db06b6217954737665878db7.
This reverts commit d47d6e7eda3aa3e6aa28d0c17ac6801234bb97d1.
This reverts commit 21141e777bdce8534e3755c8de7268324b3d8714.
|
|
|
|
|
|
|
|
|
| |
When a select tag is created for a field with errors, and that select
tag has :prompt or :include_blank options, then the inserted first
option will errantly have a <div class="field_with_errors"> wrapping
it.
See https://github.com/rails/rails/issues/7017
|
|
|
|
|
|
|
|
|
|
| |
instead of line continuations. While I'm at it, wrap long comment lines consistently.
Conflicts:
actionpack/lib/action_view/helpers/number_helper.rb
There was just one conflict related to the addition of the :format
option to number_to_percentage.
|
|\
| |
| | |
Logger in metal backport for 3.2
|
| | |
|
|/
|
|
| |
Respect absolute paths in compute_source_path.
|
|
|
|
|
|
|
|
|
|
|
|
| |
This deprecation applies to:
`button_to`
`button_tag`
`image_submit_tag`
`link_to`
`submit_tag`
As :confirm is an UI specific option is better to use the data attributes,
teaching users about unobtrusive JavaScript and how Rails works with it.
|
|
|
|
|
| |
Similarly to 6525002, this allows to use routes helpers for mounted
helpers, but this time in ActionView::TestCase
|
|\
| |
| | |
TagHelper creates invalid data attributes when value is a BigDecimal
|
| | |
|
|\ \
| |/
|/| |
Template concurrency fixes
|
| | |
|
| |
| |
| |
| | |
Closes #5632
|
| |
| |
| |
| |
| | |
If embedding auth_token in remote forms is off and we
pass a value for auth_token it should respect it.
|
| |
| |
| |
| | |
Embed auth token in remote forms
|
| |
| |
| |
| | |
Textarea newline fix breaks haml (3-2-stable)
|
| |
| |
| |
| |
| |
| |
| | |
`excerpt` text helper uses `:radius`, not `line_width` (that is used by
`word_wrap` helper).
Also cleanup some whitespaces.
|
| |
| |
| |
| | |
Render img tag with empty src if empty string is passed to image_tag.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
`button_to` and `submit_tag` helpers.
|
| | |
|
| |
| |
| |
| | |
Support data: url scheme
|
| | |
|
| | |
|
| |
| |
| |
| | |
closes #3341
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Conflicts:
actionpack/test/template/render_test.rb
|
| | |
|
| |
| |
| |
| | |
Closes #5632
|
| |
| |
| |
| |
| | |
If embedding auth_token in remote forms is off and we
pass a value for auth_token it should respect it.
|
| |
| |
| |
| |
| |
| |
| |
| | |
There is a regression introduced in 16ee611fa, which breaks
remote forms that should also work without javascript. This commit
introduces config option that allows to configure this behavior
defaulting to the old behavior (ie. include authenticity token
in remote forms by default)
|
|\ \
| | |
| | | |
[3-2-stable] Fix label_tag to merge the options hash with the object hash
|
| | |
| | |
| | |
| | |
| | |
| | | |
hash.
Closes #2492 and #5614
|
| |/
| |
| |
| |
| |
| | |
objectify_options method should be applied to the proper options arg.
See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example
|
|\ \
| |/
|/| |
Textarea newline fix breaks haml (3-2-stable)
|
| |
| |
| |
| |
| |
| | |
See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.)
Also fix 6 more tests that didn't yet have the newline expectation.
|
|/
|
|
|
|
|
|
|
| |
Previously `rendered_format` was set only based on mime types
passed in Accept header, which was wrong if first type from
Accept was different than rendered partial. The fix is to simply
move setting rendered_format to the place where template
is available and grab format from the template. If it fails
we can fallback to formats passed by Accept header.
|
| |
|
|
|
|
| |
forms if you pass true
|
|
|
|
| |
forms use the meta-tag value
|
| |
|
| |
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* 3-2-2:
bumping to 3.2.2
Ensure [] respects the status of the buffer.
Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare
Merge pull request #5084 from johndouthat/patch-1
updating RAILS_VERSION
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* 3-2-stable-security:
Ensure [] respects the status of the buffer.
delete vulnerable AS::SafeBuffer#[]
use AS::SafeBuffer#clone_empty for flushing the output_buffer
add AS::SafeBuffer#clone_empty
fix output safety issue with select options
|