aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* Update the HTML boolean attributes per the HTML 5.1 specAlex Peattie2013-06-141-2/+5
| | | | | | | - Add attributes `allowfullscreen`, `default`, `inert`, `sortable`, `truespeed`, `typemustmatch`. - Fix attribute `seamless` (previously misspelled `seemless`). - Use `assert_dom_equal` instead of `assert_equal` in test.
* fixed typo in action_view templatediatmpravin2013-06-081-1/+1
|
* Fix mismatching variable names when using an underscoreDrew Ulmer2013-06-041-1/+1
| | | | | | | | The ERBTracker template digest helper class was using a regex to match render calls and it was incorrectly not matching against variables with underscores in the name. This caused it to use the wrong regex match data to populate the template dependency. Because underscore is a valid character for a variable, this fixes the ERBTracker to match it properly.
* Raise ArgumentError to fix Rails 4.1 deprecation warn message.kennyj2013-06-021-5/+1
|
* Remove ActionView::Template#mime_type was deprecated.kennyj2013-06-011-6/+0
|
* Remove :confirm and :disable_with options from ↵kennyj2013-06-011-41/+0
| | | | ActionView::Helpers::FormTagHelper were deprecated.
* Remove link_to_function / button_to_function from ↵kennyj2013-06-011-42/+0
| | | | ActionView::Helpers::JavascriptHelper were deprecated.
* Remove :confirm and :disable_with options for ↵kennyj2013-06-011-18/+0
| | | | ActionView::Helpers::UrlHelper#link_to and #button_to were deprecated.
* Merge pull request #10527 from zenspider/squishy_minitest5Aaron Patterson2013-05-161-1/+3
|\ | | | | Squishy minitest5
| * Updates to make rails 4 happy with minitest 5:Ryan Davis2013-05-061-1/+3
| | | | | | | | | | | | | | | | | | | | + Namespace changes, overhaul of runners. + Internal ivar name changes - Removed a logger globally applied to tests that spew everywhere?!? + Override Minitest#__run to sort tests by name. + Reworked testing isolation to work with the new cleaner architecture. - Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago. - Minor report output differences.
* | restore ability to return nil from asset_host proc, add testSean Walbran2013-05-151-1/+2
| |
* | sort => sort! on new arrayVipul A M2013-05-101-1/+1
| |
* | Merge pull request #10377 from bricker/template_digest_ending_with_numberRafael Mendonça França2013-05-061-1/+1
|\ \ | | | | | | Allow numbers in partial name for digesting
| * | Allow numbers in partial name for digestingBryan Ricker2013-05-061-1/+1
| |/ | | | | | | | | | | | | | | | | | | Add failing test for template with number at the end Use \w for RENDER_DEPENDENCY regex Spacing Add CHANGELOG entry
* | Merge pull request #10446 from dasch/instrument-template-compilationRafael Mendonça França2013-05-061-2/+9
|\ \ | |/ |/| Instrument template compilation
| * Instrument template compilationDaniel Schierbeck2013-05-061-2/+9
| |
* | remove unused variableVipul A M2013-05-061-1/+0
| |
* | Fix typo in documentation commentJunya Ogura2013-05-061-1/+1
| |
* | Added missing `require` to ActionView::LookupContextVladimir Strakhov2013-05-051-0/+1
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-011-1/+1
|\
| * fixed typo in select_tag docsRncrtr2013-04-181-1/+1
| |
* | Revert "Merge pull request #10337 from eimermusic/fix_template_digestor_lookup"Rafael Mendonça França2013-04-251-1/+1
| | | | | | | | | | | | | | | | This reverts commit b4239622afc4f3f73808fd0c97512f3a534e07dd, reversing changes made to f99ce3c188f5dde57e2ff63e6a22363c62f0a4cd. Reason: This broke the build https://travis-ci.org/rails/rails/jobs/6629894
* | AV Digestor correctly passes format to LookupContextMartin Westin2013-04-251-1/+1
| | | | | | | | | | | | | | | | ActionView::Digestor now passes arguments correctly to LookupContext::find method. This makes cache digests respect the format option correctly. FixtureFinder in tests also changed to reflect this.
* | Merge pull request #10267 from vipulnsward/use_destructive_methodRafael Mendonça França2013-04-191-1/+1
|\ \ | | | | | | symbolize_keys => symbolize_keys! on new hash; change sentence
| * | symbolize_keys => symbolize_keys! on new hash;Vipul A M2013-04-191-1/+1
| | | | | | | | | | | | "There're" => There are for better readability
* | | Adding documentation to actionview so that the big picture of thewangjohn2013-04-184-0/+41
|/ / | | | | | | renderer is clearer.
* | Merge pull request #10173 from nashby/element-attributesRafael Mendonça França2013-04-161-1/+1
|\ \ | |/ |/| options_from_collection_for_select helper takes html attributes
| * options_from_collection_for_select helper takes html attributesVasiliy Ermolovich2013-04-111-1/+1
| | | | | | | | as the last element of the array
* | Fix a typoViktar Basharymau2013-04-121-1/+1
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-04-1136-78/+110
|\ \ | |/ |/| | | | | Conflicts: guides/source/action_mailer_basics.md
| * improve accuracy of simple_format documentation. span doesn't get sanitized.RSL2013-04-091-2/+5
| |
| * Typo fixCarson McDonald2013-04-051-3/+3
| |
| * fix broken format in ActionView::Helpers::AssetTagHelper [ci skip]Francesco Rodriguez2013-04-041-4/+9
| |
| * mark ActionView::Helpers::Tags as :nodoc: [ci skip]Francesco Rodriguez2013-04-0433-68/+67
| |
| * fix broken format in ActionView::Helpers::NumberHelper [ci skip]Francesco Rodriguez2013-04-031-0/+25
| |
| * Fix typoCarson McDonald2013-03-311-1/+1
| |
* | Added documentation to the FormBuilder class, should helpwangjohn2013-04-061-2/+55
| | | | | | | | | | clarify issue #10115. Also made the field_helpers an explicit list of methods.
* | change some more merge to merge! on new hashesVipul A M2013-04-061-3/+3
| |
* | Merge pull request #9555 from tmm1/optimize-erbRafael Mendonça França2013-04-052-3/+35
|\ \ | | | | | | Optimize generated ERB to reduce method calls
| * | avoid extra method calls for appending newlinesAman Gupta2013-03-041-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | before: ');@output_buffer.append= ( content_icon row[:content] );@output_buffer.safe_concat(' ');@output_buffer.safe_concat(' ');@output_buffer.append= ( spinner_img );@output_buffer.safe_concat(' ');@output_buffer.safe_concat(' </td> <td class="content"> ');@output_buffer.append= ( content_link row[:content] );@output_buffer.safe_concat(' ');@output_buffer.safe_concat(' </td> <td class="message"> '); after: ';@output_buffer.append=( content_icon row[:content] );@output_buffer.safe_append=' ';@output_buffer.append=( spinner_img );@output_buffer.safe_append=' </td> <td class="content"> ';@output_buffer.append=( content_link row[:content] );@output_buffer.safe_append=' </td> <td class="message"> ';
| * | Use ActionView::OutputBuffer#safe_append= from templatesAman Gupta2013-03-042-3/+9
| | |
* | | Fix explicit names on multiple file fieldsRyan McGeary2013-04-051-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | If a file field tag is passed the multiple option, it is turned into an array field (appending "[]"), but if the file field is passed an explicit name as an option, leave the name alone (do not append "[]"). Fixes #9830
* | | Refactor mail_to to not generate intermediate hashes when adding hrefCarlos Antonio da Silva2013-04-041-5/+6
| | | | | | | | | | | | | | | | | | There's no need to use Hash#merge with a new hash just for setting the href option to pass it through. Since we're always dealing with a new html_options hash, we're free to just set the value instead.
* | | Ensure mail_to helper does not modify the given html options hashCarlos Antonio da Silva2013-04-041-3/+3
| | |
* | | Add block support for the helperSam Pohlenz2013-04-031-5/+16
| | |
* | | Fix grammatical error on JS helper warning messagethenickcox2013-04-021-2/+2
| | | | | | | | | | | | | | | | | | Add changelog entry Delete changelog
* | | typo recomend -> recommendogawaso2013-04-011-2/+2
| | |
* | | Merge pull request #9680 from bdmac/time-zone-options-revert-grep-to-selectCarlos Antonio da Silva2013-03-311-1/+1
|\ \ \ | | | | | | | | Revert grep to select since they are not the same
| * | | Revert grep to select since they are not the sameBrian McManus2013-03-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A previous commit swapped out a call to select for a call to grep in time_zone_options_for_select. This behavior actually causes the regexp priority option to stop working. ActiveSupport::TimeZone overrides the =~ operator which is what the select block was using previously. Enumerable#grep checks pattern === element and in this case that would be /US/ === ActiveSupport::TimeZone which does not work because ActiveSupport::TimeZone does not supply an implicit converting to_str method, only an explicit to_s method. It would be impossible to provide a to_str method that behaves identically to the =~ method provided on ActiveSupport::TimeZone so the only option is to revert back to using select with =~.
* | | | Merge pull request #10015 from vipulnsward/remove_unused_variable_in_getSteve Klabnik2013-03-311-1/+1
|\ \ \ \ | | | | | | | | | | remove unused variable and assignment