Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | two argument String#slice is faster than single argument, also avoid ↵ | Aaron Patterson | 2010-10-03 | 1 | -1/+1 |
| | | | | creating a Range object | ||||
* | PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵ | Santiago Pastorino | 2010-10-03 | 1 | -3/+3 |
| | | | | faster than var.sub('@', '') | ||||
* | Rename _assigns to view_assigns in AV::TC | David Chelimsky | 2010-10-03 | 1 | -9/+21 |
| | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Fixing search_field to remove object attribute from options hash [#5730 ↵ | Aditya Sanghi | 2010-10-02 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵ | José Valim | 2010-10-02 | 1 | -1/+5 |
| | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9. | ||||
* | Revert "removing crazy finalizer code until there is proof that we need it" | José Valim | 2010-09-30 | 1 | -0/+11 |
| | | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78. | ||||
* | tag value can be false, so nil? check is necessary | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | another case of extra nil? check | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | removing crazy finalizer code until there is proof that we need it | Aaron Patterson | 2010-09-29 | 1 | -9/+0 |
| | |||||
* | removing useless code | Aaron Patterson | 2010-09-29 | 1 | -1/+0 |
| | |||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 2 | -25/+28 |
| | | | | everyone calls super as expected. | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 4 | -3/+11 |
|\ | |||||
| * | Initialize @path. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | |||||
| * | Ask if the instance variable is defined before asking for it, avoid *many* ↵ | Emilio Tagua | 2010-09-28 | 1 | -1/+5 |
| | | | | | | | | warnings. | ||||
| * | Initialize @sub_templates | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | |||||
| * | Don't define _test_case method if already defined. | Emilio Tagua | 2010-09-28 | 1 | -2/+4 |
| | | |||||
* | | convert inject to map + join | Aaron Patterson | 2010-09-28 | 1 | -5/+5 |
|/ | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 4 | -5/+7 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | ||||
| * | Remove method previous method if already defined. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | | |||||
| * | Define @emitted_hidden_id if it doesn't exists and reuse it if it does. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | |||||
| * | Avoid uninitialized variable warning. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | | |||||
| * | Don't shadow outer local variables. | Emilio Tagua | 2010-09-27 | 1 | -4/+4 |
| | | |||||
* | | Assume compute_asset_host returns reasonable values. | thedarkone | 2010-09-27 | 1 | -1/+1 |
| | | |||||
* | | Performance: refactor convert_options_to_data_attributes. | thedarkone | 2010-09-27 | 1 | -10/+14 |
| | | |||||
* | | Remove dead code. | thedarkone | 2010-09-27 | 1 | -2/+2 |
| | | |||||
* | | Clean up url_for. | thedarkone | 2010-09-27 | 1 | -3/+1 |
| | | |||||
* | | Do a single string interpolation. | thedarkone | 2010-09-27 | 1 | -1/+1 |
| | | |||||
* | | Simple .empty? test will do fine here (rails_asset_id returns nice strings). | thedarkone | 2010-09-27 | 1 | -1/+1 |
| | | |||||
* | | Make asset extension rewriting faster. | thedarkone | 2010-09-27 | 1 | -5/+11 |
| | | |||||
* | | Optimize relative_url_root rewriting code. | thedarkone | 2010-09-27 | 1 | -3/+5 |
| | | |||||
* | | Compile ActionController::Base.config's methods to avoid method_missing ↵ | thedarkone | 2010-09-27 | 1 | -2/+1 |
|/ | | | | overhead. | ||||
* | We don't need to check if the format exists to generate the url, it already ↵ | Carlos Antonio da Silva | 2010-09-26 | 1 | -8/+7 |
| | | | | does it internally | ||||
* | More cleanup on form helpers | Carlos Antonio da Silva | 2010-09-26 | 1 | -11/+12 |
| | |||||
* | Remove last tests with deprecated form_for and cleanup form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -4/+2 |
| | | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before. | ||||
* | Select tags with array options are deprecated, removing | Carlos Antonio da Silva | 2010-09-26 | 1 | -4/+0 |
| | |||||
* | Refactor form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -21/+11 |
| | |||||
* | There is no DeprecatedBlockHelpers in AV, so remove it | Carlos Antonio da Silva | 2010-09-26 | 1 | -1/+0 |
| | |||||
* | Changed documentation for auto_link so that the truncate example works ↵ | Kevin Hughes | 2010-09-24 | 1 | -1/+1 |
| | | | | | | [#5694 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | resolves rdoc conflict | Xavier Noria | 2010-09-23 | 4 | -10/+12 |
|\ | |||||
| * | Document form_for behaviour when using file_field inside the block | Joost Baaij | 2010-09-21 | 1 | -1/+3 |
| | | |||||
| * | Tiny fixes to rdoc | Alexey Mahotkin | 2010-09-16 | 3 | -6/+6 |
| | | |||||
| * | Typos | rspeicher | 2010-09-15 | 1 | -3/+3 |
| | | |||||
* | | Refactor decode_credentials to avoid inject and use map instead. | Emilio Tagua | 2010-09-22 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Perf: refactor _assign method to avoid inject and defining unneeded local var. | Emilio Tagua | 2010-09-22 | 1 | -5/+1 |
| | | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | file_field propagates up multipart property even inside of fields_for | Santiago Pastorino | 2010-09-20 | 1 | -8/+13 |
| | | |||||
* | | application.js should be the last file on javascript_include_tag(:all) | Santiago Pastorino | 2010-09-19 | 1 | -1/+1 |
| | | |||||
* | | removing some warnings | Aaron Patterson | 2010-09-18 | 1 | -2/+2 |
| | | |||||
* | | freeze is not necessary | Aaron Patterson | 2010-09-18 | 1 | -3/+3 |
| | | |||||
* | | argument error is done for us | Aaron Patterson | 2010-09-18 | 1 | -2/+0 |
| | |