aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view
Commit message (Collapse)AuthorAgeFilesLines
* dry up some crazy codesAaron Patterson2010-10-041-8/+6
|
* two argument String#slice is faster than single argument, also avoid ↵Aaron Patterson2010-10-031-1/+1
| | | | creating a Range object
* PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵Santiago Pastorino2010-10-031-3/+3
| | | | faster than var.sub('@', '')
* Rename _assigns to view_assigns in AV::TCDavid Chelimsky2010-10-031-9/+21
| | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fixing search_field to remove object attribute from options hash [#5730 ↵Aditya Sanghi2010-10-021-1/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵José Valim2010-10-021-1/+5
| | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9.
* Revert "removing crazy finalizer code until there is proof that we need it"José Valim2010-09-301-0/+11
| | | | This reverts commit a40e3c1a9604ab3737ad2465c8f6a6db0fe0cc78.
* tag value can be false, so nil? check is necessaryAaron Patterson2010-09-291-1/+1
|
* another case of extra nil? checkNeeraj Singh2010-09-301-1/+1
|
* no need to check for nil?Neeraj Singh2010-09-301-2/+2
|
* removing crazy finalizer code until there is proof that we need itAaron Patterson2010-09-291-9/+0
|
* removing useless codeAaron Patterson2010-09-291-1/+0
|
* Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵José Valim2010-09-292-25/+28
| | | | everyone calls super as expected.
* Merge remote branch 'miloops/warnings'José Valim2010-09-294-3/+11
|\
| * Initialize @path.Emilio Tagua2010-09-281-0/+1
| |
| * Ask if the instance variable is defined before asking for it, avoid *many* ↵Emilio Tagua2010-09-281-1/+5
| | | | | | | | warnings.
| * Initialize @sub_templatesEmilio Tagua2010-09-281-0/+1
| |
| * Don't define _test_case method if already defined.Emilio Tagua2010-09-281-2/+4
| |
* | convert inject to map + joinAaron Patterson2010-09-281-5/+5
|/
* Merge remote branch 'miloops/warnings'José Valim2010-09-274-5/+7
|\ | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| * Remove method previous method if already defined.Emilio Tagua2010-09-271-0/+1
| |
| * Define @emitted_hidden_id if it doesn't exists and reuse it if it does.Emilio Tagua2010-09-271-1/+1
| |
| * Avoid uninitialized variable warning.Emilio Tagua2010-09-271-0/+1
| |
| * Don't shadow outer local variables.Emilio Tagua2010-09-271-4/+4
| |
* | Assume compute_asset_host returns reasonable values.thedarkone2010-09-271-1/+1
| |
* | Performance: refactor convert_options_to_data_attributes.thedarkone2010-09-271-10/+14
| |
* | Remove dead code.thedarkone2010-09-271-2/+2
| |
* | Clean up url_for.thedarkone2010-09-271-3/+1
| |
* | Do a single string interpolation.thedarkone2010-09-271-1/+1
| |
* | Simple .empty? test will do fine here (rails_asset_id returns nice strings).thedarkone2010-09-271-1/+1
| |
* | Make asset extension rewriting faster.thedarkone2010-09-271-5/+11
| |
* | Optimize relative_url_root rewriting code.thedarkone2010-09-271-3/+5
| |
* | Compile ActionController::Base.config's methods to avoid method_missing ↵thedarkone2010-09-271-2/+1
|/ | | | overhead.
* We don't need to check if the format exists to generate the url, it already ↵Carlos Antonio da Silva2010-09-261-8/+7
| | | | does it internally
* More cleanup on form helpersCarlos Antonio da Silva2010-09-261-11/+12
|
* Remove last tests with deprecated form_for and cleanup form_for helperCarlos Antonio da Silva2010-09-261-4/+2
| | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before.
* Select tags with array options are deprecated, removingCarlos Antonio da Silva2010-09-261-4/+0
|
* Refactor form_for helperCarlos Antonio da Silva2010-09-261-21/+11
|
* There is no DeprecatedBlockHelpers in AV, so remove itCarlos Antonio da Silva2010-09-261-1/+0
|
* Changed documentation for auto_link so that the truncate example works ↵Kevin Hughes2010-09-241-1/+1
| | | | | | [#5694 state:resolved] Signed-off-by: Xavier Noria <fxn@hashref.com>
* resolves rdoc conflictXavier Noria2010-09-234-10/+12
|\
| * Document form_for behaviour when using file_field inside the blockJoost Baaij2010-09-211-1/+3
| |
| * Tiny fixes to rdocAlexey Mahotkin2010-09-163-6/+6
| |
| * Typosrspeicher2010-09-151-3/+3
| |
* | Refactor decode_credentials to avoid inject and use map instead.Emilio Tagua2010-09-221-1/+1
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Perf: refactor _assign method to avoid inject and defining unneeded local var.Emilio Tagua2010-09-221-5/+1
| | | | | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | file_field propagates up multipart property even inside of fields_forSantiago Pastorino2010-09-201-8/+13
| |
* | application.js should be the last file on javascript_include_tag(:all)Santiago Pastorino2010-09-191-1/+1
| |
* | removing some warningsAaron Patterson2010-09-181-2/+2
| |
* | freeze is not necessaryAaron Patterson2010-09-181-3/+3
| |