Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Don't require action_dispatch in ActionView::UrlHelpers | Piotr Sarnacki | 2012-08-28 | 1 | -0/+1 |
| | | | | | | | | | | ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required. | ||||
* | Move ActionController::RecordIdentifier to ActionView | Piotr Sarnacki | 2012-08-28 | 1 | -1/+1 |
| | | | | | | | Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round. | ||||
* | load active_support/core_ext/module/delegation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | Allow to use mounted helpers in ActionView::TestCase | Piotr Sarnacki | 2012-06-01 | 1 | -1/+2 |
| | | | | | Similarly to 6525002, this allows to use routes helpers for mounted helpers, but this time in ActionView::TestCase | ||||
* | Revert usage of safe constantize | José Valim | 2012-01-26 | 1 | -1/+3 |
| | |||||
* | Move render_to_body logic to return a spaced string to AC::Rendering | Carlos Antonio da Silva | 2012-01-17 | 1 | -2/+0 |
| | | | | | | | | | | | This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this. | ||||
* | instance_variables method returns symbols in 1.9 ruby | Sergey Nartimov | 2012-01-07 | 1 | -26/+26 |
| | |||||
* | Merge pull request #3196 from avakhov/patch-am-av-tests-2 | José Valim | 2011-10-09 | 1 | -1/+6 |
|\ | | | | | Improve tests method for ActionView::TestCase and ActionMailer::TestCase | ||||
| * | normalize arg for ActionView::TestCase tests method | Alexey Vakhov | 2011-10-03 | 1 | -1/+6 |
| | | |||||
* | | missed underscore in AV::TestCase helper_method documentation | Alexey Vakhov | 2011-10-03 | 1 | -1/+1 |
|/ | |||||
* | Use safe_constantize where possible. | José Valim | 2011-09-23 | 1 | -3/+1 |
| | |||||
* | removed deprecated methods, and related tests, from ActionPack | Josh Kalderimis | 2011-05-24 | 1 | -6/+0 |
| | |||||
* | Use remove possible method here. | José Valim | 2011-05-04 | 1 | -1/+2 |
| | |||||
* | Move prefixes to view paths as they are now a lookup context dependency. | José Valim | 2011-05-04 | 1 | -0/+2 |
| | |||||
* | Remove dependency from _template. | José Valim | 2011-05-01 | 1 | -3/+13 |
| | |||||
* | renames response_from_page_or_rjs -> response_from_page, and extracts the ↵ | Xavier Noria | 2011-04-13 | 1 | -1/+1 |
| | | | | RJS in it | ||||
* | test/unit in ruby trunk adds a new instance variable. YAY! | Aaron Patterson | 2011-03-08 | 1 | -0/+1 |
| | |||||
* | minitest added @__io__, so we should ignore it too | Aaron Patterson | 2011-01-17 | 1 | -0/+1 |
| | |||||
* | Reuse the view_context from the controller, this make the test environment ↵ | Santiago Pastorino | 2011-01-12 | 1 | -4/+1 |
| | | | | more similar to the code applications uses | ||||
* | Allow view in AV::TestCase to access it's controller helpers methods | Santiago Pastorino | 2011-01-12 | 1 | -0/+1 |
| | |||||
* | two argument String#slice is faster than single argument, also avoid ↵ | Aaron Patterson | 2010-10-03 | 1 | -1/+1 |
| | | | | creating a Range object | ||||
* | PERF: Hash[] + map is faster than this silly inject, and var[1..-1] is ↵ | Santiago Pastorino | 2010-10-03 | 1 | -3/+3 |
| | | | | faster than var.sub('@', '') | ||||
* | Rename _assigns to view_assigns in AV::TC | David Chelimsky | 2010-10-03 | 1 | -9/+21 |
| | | | | | | | | | - also add tests - also deprecate _assigns [#5751 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Revert "Perf: refactor _assign method to avoid inject and defining unneeded ↵ | José Valim | 2010-10-02 | 1 | -1/+5 |
| | | | | | | | | local var." _assigns must return a hash. This reverts commit e66c1cee86aba1c81152f3d0872313e65cec85a9. | ||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -11/+11 |
| | | | | everyone calls super as expected. | ||||
* | Don't define _test_case method if already defined. | Emilio Tagua | 2010-09-28 | 1 | -2/+4 |
| | |||||
* | Remove method previous method if already defined. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | |||||
* | Refactor decode_credentials to avoid inject and use map instead. | Emilio Tagua | 2010-09-22 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Perf: refactor _assign method to avoid inject and defining unneeded local var. | Emilio Tagua | 2010-09-22 | 1 | -5/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Allow view helper's #initialize method to be called. [#5061 state:resolved] | Carl Lerche | 2010-09-13 | 1 | -1/+5 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | Moved PolymorphicRoutes to ActionDispatch::Routing | Piotr Sarnacki | 2010-07-20 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -5/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Convert instance_variables to symbols before excluding internal vars [#4965 ↵ | rohit | 2010-06-28 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Expose view via the view() method in AV::TestCase::Behavior | David Chelimsky | 2010-06-23 | 1 | -5/+8 |
| | | | | | | | | | | - was exposed as _view, which suggested it was private - left _view as an alias of view as not to break any extensions that are relying on _view [#4932 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | In ActionView::TestCase::Behavior, assign variables right before | David Chelimsky | 2010-06-23 | 1 | -1/+2 |
| | | | | | | | | | | | rendering the view. - Previously, _assigns were locked down the first time _view was referenced. [#4931 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | update the list of instance variables that are excluded from assigns in view ↵ | David Chelimsky | 2010-06-22 | 1 | -9/+10 |
| | | | | | | | | tests [#4930 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add support for specifying locals in view tests with assert template [#4927 ↵ | David Chelimsky | 2010-06-22 | 1 | -0/+15 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -0/+1 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | Support render_template in view tests. Useful for specifying which | David Chelimsky | 2010-06-20 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | partials are rendered under different conditions. [#4903 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Final touches and fixes. | Rizwan Reza | 2010-06-21 | 1 | -0/+1 |
|/ | |||||
* | Memoize the object returned by _view in ActionView::TestCase::Behavior | David Chelimsky | 2010-06-08 | 1 | -6/+8 |
| | | | | | | [#4799 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | In AV::TC, move protect_against_forgery? from the test_case to the | David Chelimsky | 2010-06-03 | 1 | -4/+9 |
| | | | | | | | | | | | | | _helper module included in the view. - ensures that protect_against_forgery? is present when a helper included in a partial that is rendered by the template under test calls it (which happens in FormTagHelper#extra_tags_for_form, for example). [#4700 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Support configuration of controller.controller_path on instances of | David Chelimsky | 2010-05-26 | 1 | -2/+7 |
| | | | | | | | | | | ActionView::TestCase::TestController without stubs. Just say: @controller.controller_path = "path/i/need/for/this/test" [#4697 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move AV::TC to AV::TC::Behavior [#4678 state:resolved] | David Chelimsky | 2010-05-24 | 1 | -65/+85 |
| | | | | | | | | | | | | - enables alternative testing frameworks to include AV::TC::Behavior instead of subclassing AV::TC - also added tests and code for: - test view delegates :notice to request.flash - useful since generators generate views that use notice - test case doesn't try to include modules that are actually classes Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | refactor evals and adds some __FILE__ and __LINE__ | Santiago Pastorino | 2010-05-20 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Clean up the config object in ActionPack. Create config_accessor which just ↵ | José Valim | 2010-04-22 | 1 | -1/+1 |
| | | | | delegates to the config object, reducing the number of deprecations and add specific tests. | ||||
* | Missing requires | wycats | 2010-04-16 | 1 | -0/+1 |
| | |||||
* | Refactored url_for in AV to have its own instances of the helpers instead of ↵ | wycats | 2010-04-03 | 1 | -1/+6 |
| | | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win) |