Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Update template to allow handlers to more cleanly handle encodings (ht: nex3) | wycats | 2010-05-30 | 2 | -27/+26 | |
| | ||||||
* | Make sure encoding changes don't break 1.8 | wycats | 2010-05-17 | 1 | -1/+3 | |
| | ||||||
* | Significantly improved internal encoding heuristics and support. | wycats | 2010-05-16 | 3 | -4/+64 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Default Encoding.default_internal to UTF-8 * Eliminated the use of file-wide magic comments to coerce code evaluated inside the file * Read templates as BINARY, use default_external or template-wide magic comments inside the Template to set the initial encoding * This means that template handlers in Ruby 1.9 will receive Strings encoded in default_internal (UTF-8 by default) * Create a better Exception for encoding issues, and use it when the template source has bytes that are not compatible with the specified encoding * Allow template handlers to opt-into handling BINARY. If they do so, they need to do some of their own manual encoding work * Added a "Configuration Gotchas" section to the intro Rails Guide instructing users to use UTF-8 for everything * Use config.encoding= in Ruby 1.8, and raise if a value that is an invalid $KCODE value is used Also: * Fixed a few tests that were assert() rather than assert_equal() and were caught by Minitest requiring a String for the message * Fixed a test where an assert_select was misformed, also caught by Minitest being more restrictive * Fixed a test where a Rack response was returning a String rather than an Enumerable | |||||
* | Initial work to improve the state of encodings for templates | wycats | 2010-05-16 | 1 | -45/+53 | |
| | ||||||
* | Check blocks are not incorrectly detected when compiling erubis templates ↵ | Simon Jefford | 2010-05-16 | 1 | -1/+1 | |
| | | | | | | [#4575 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use annoted source code in Template:Error to avoid special cases in the show ↵ | José Valim | 2010-05-09 | 1 | -3/+2 | |
| | | | | exceptions middleware. | |||||
* | Make backtrace_cleaner work as expected. Prior to this patch, the Full Trace ↵ | José Valim | 2010-05-03 | 1 | -26/+6 | |
| | | | | rarely showed the full trace. Also, increase performance considerably. | |||||
* | yield always return an array, so we don't need to use .key? | José Valim | 2010-03-31 | 1 | -6/+1 | |
| | ||||||
* | Eliminate an error from an implicit dependency on AV::Base | wycats | 2010-03-19 | 1 | -2/+22 | |
| | ||||||
* | Improve performance of the rendering stack by freezing formats as a sign ↵ | José Valim | 2010-03-19 | 1 | -7/+12 | |
| | | | | that they shouldn't be further modified. | |||||
* | Sending the partial as info is no longer required. | José Valim | 2010-03-18 | 1 | -3/+3 | |
| | ||||||
* | Move more normalization up to the lookup context, so it does not have to ↵ | José Valim | 2010-03-16 | 1 | -23/+1 | |
| | | | | repeat in every resolver. | |||||
* | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 1 | -1/+18 | |
| | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | |||||
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 2 | -10/+7 | |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | |||||
* | %= works for content_tag and does not require parenthesis on method call | José Valim | 2010-03-12 | 1 | -47/+6 | |
| | ||||||
* | Delegate #encoding to SafeBuffer too | Jeremy Kemper | 2010-03-11 | 1 | -0/+4 | |
| | ||||||
* | Merge branch 'master' of github.com:rails/rails | wycats | 2010-03-10 | 2 | -24/+18 | |
|\ | ||||||
| * | Optimize and clean up how details key get expired. | José Valim | 2010-03-10 | 1 | -0/+5 | |
| | | ||||||
| * | Clean up the API required from ActionView::Template. | José Valim | 2010-03-09 | 2 | -24/+13 | |
| | | ||||||
* | | Make form helpers work with <%= | wycats | 2010-03-09 | 1 | -0/+8 | |
| | | ||||||
* | | Deprecate block_called_from_erb? pending a solution for getting it into apps | Carlhuda | 2010-03-09 | 1 | -5/+41 | |
|/ | ||||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -6/+10 | |
| | ||||||
* | Move details to lookup_context and make resolvers use the cache key. | José Valim | 2010-03-08 | 1 | -34/+12 | |
| | ||||||
* | Speed up performance in resolvers by adding fallbacks just when required. | José Valim | 2010-03-08 | 1 | -24/+7 | |
| | ||||||
* | Rename Template::Lookup to LookupContext. | José Valim | 2010-03-08 | 1 | -56/+0 | |
| | ||||||
* | Finally moved the find template logic to the views. | José Valim | 2010-03-08 | 1 | -4/+3 | |
| | ||||||
* | Move layout lookup to views. | José Valim | 2010-03-08 | 1 | -0/+8 | |
| | ||||||
* | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -0/+48 | |
| | | | | lookup. | |||||
* | First take on ViewPaths clean up. | José Valim | 2010-03-07 | 1 | -8/+11 | |
| | ||||||
* | Actually, revert previous commit. Having a lot of information is better than ↵ | José Valim | 2010-03-05 | 1 | -9/+3 | |
| | | | | having no information at all. | |||||
* | Define to_s method in ActionView::Resolver, so I'm not required to write it ↵ | José Valim | 2010-03-05 | 1 | -1/+5 | |
| | | | | in inherited classes. | |||||
* | Fix render :file => "#{Rails.root}/public/404.html", :status => :not_found. ↵ | Yehuda Katz | 2010-02-23 | 1 | -1/+1 | |
| | | | | Closes #8994 | |||||
* | Rename erubis_implementation to erb_implementation. | José Valim | 2010-02-22 | 1 | -3/+3 | |
| | ||||||
* | Resolve view paths correctly on CygWin | Sam Ruby | 2010-02-02 | 1 | -1/+1 | |
| | | | | Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com> | |||||
* | Convert to class_attribute | Jeremy Kemper | 2010-02-01 | 2 | -3/+4 | |
| | ||||||
* | Add support for compile-time <%= raw %> | Yehuda Katz | 2010-01-31 | 1 | -1/+5 | |
| | ||||||
* | Deleted all references to ActionView::SafeBuffer in favor of ↵ | Santiago Pastorino | 2010-01-31 | 1 | -1/+1 | |
| | | | | | | ActiveSupport::SafeBuffer Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | |||||
* | deOMGifying Railties, Active Support, and Action Pack | Mikel Lindsaar | 2010-01-31 | 1 | -2/+1 | |
| | ||||||
* | Fix t('.helper'). | José Valim | 2010-01-26 | 1 | -5/+8 | |
| | ||||||
* | Add subscriber for ActionPack and move all logging inside it. | José Valim | 2010-01-13 | 1 | -1/+1 | |
| | ||||||
* | Silence some trivial warnings: shadowed local vars, indentation mismatches | Jeremy Kemper | 2009-12-28 | 2 | -10/+6 | |
| | ||||||
* | Instead of marking raw text in templates as safe, and then putting them ↵ | Yehuda Katz | 2009-12-24 | 1 | -1/+2 | |
| | | | | through String#<< which checks if the String is safe, use safe_concat, which uses the original (internal) String#<< and leaves the safe flag as is. Results in a significant performance improvement. | |||||
* | Add autoloads for ActionView::Template* classes, and an ↵ | Nathan Weizenbaum | 2009-12-10 | 1 | -1/+3 | |
| | | | | | | ActionView::TemplateError alias for ActionView::Template::Error. Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | |||||
* | Reorganize autoloads: | Carlhuda | 2009-12-02 | 9 | -317/+197 | |
| | | | | | | | | | | | | | | | | | | | | | * A new module (ActiveSupport::Autoload) is provide that extends autoloading with new behavior. * All autoloads in modules that have extended ActiveSupport::Autoload will be eagerly required in threadsafe environments * Autoloads can optionally leave off the path if the path is the same as full_constant_name.underscore * It is possible to specify that a group of autoloads live under an additional path. For instance, all of ActionDispatch's middlewares are ActionDispatch::MiddlewareName, but they live under "action_dispatch/middlewares/middleware_name" * It is possible to specify that a group of autoloads are all found at the same path. For instance, a number of exceptions might all be declared there. * One consequence of this is that testing-related constants are not autoloaded. To get the testing helpers for a given component, require "component_name/test_case". For instance, "action_controller/test_case". * test_help.rb, which is automatically required by a Rails application's test helper, requires the test_case.rb for all active components, so this change will not be disruptive in existing or new applications. | |||||
* | Improve AbstractController layouts coverage. | José Valim | 2009-11-01 | 1 | -2/+2 | |
| | ||||||
* | Reduce TextTemplate cost for simple cases | Yehuda Katz | 2009-10-28 | 1 | -1/+3 | |
| | ||||||
* | Make encodings work with Erubis and 1.9 again | Yehuda Katz | 2009-10-16 | 1 | -3/+5 | |
| | ||||||
* | Fix a bug where templates with locales were not being sorted correctly | Yehuda Katz | 2009-10-16 | 1 | -1/+1 | |
| | ||||||
* | Renamed Orchestra to Notifications once again [#3321 state:resolved] | José Valim | 2009-10-15 | 1 | -1/+1 | |
| | ||||||
* | Update Orchestra instrumentations and move part of logging to Orchestra. | José Valim | 2009-10-15 | 1 | -1/+1 | |
| |