Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add subscriber for ActionPack and move all logging inside it. | José Valim | 2010-01-13 | 1 | -1/+1 |
| | |||||
* | Silence some trivial warnings: shadowed local vars, indentation mismatches | Jeremy Kemper | 2009-12-28 | 2 | -10/+6 |
| | |||||
* | Instead of marking raw text in templates as safe, and then putting them ↵ | Yehuda Katz | 2009-12-24 | 1 | -1/+2 |
| | | | | through String#<< which checks if the String is safe, use safe_concat, which uses the original (internal) String#<< and leaves the safe flag as is. Results in a significant performance improvement. | ||||
* | Add autoloads for ActionView::Template* classes, and an ↵ | Nathan Weizenbaum | 2009-12-10 | 1 | -1/+3 |
| | | | | | | ActionView::TemplateError alias for ActionView::Template::Error. Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | Reorganize autoloads: | Carlhuda | 2009-12-02 | 9 | -317/+197 |
| | | | | | | | | | | | | | | | | | | | | | * A new module (ActiveSupport::Autoload) is provide that extends autoloading with new behavior. * All autoloads in modules that have extended ActiveSupport::Autoload will be eagerly required in threadsafe environments * Autoloads can optionally leave off the path if the path is the same as full_constant_name.underscore * It is possible to specify that a group of autoloads live under an additional path. For instance, all of ActionDispatch's middlewares are ActionDispatch::MiddlewareName, but they live under "action_dispatch/middlewares/middleware_name" * It is possible to specify that a group of autoloads are all found at the same path. For instance, a number of exceptions might all be declared there. * One consequence of this is that testing-related constants are not autoloaded. To get the testing helpers for a given component, require "component_name/test_case". For instance, "action_controller/test_case". * test_help.rb, which is automatically required by a Rails application's test helper, requires the test_case.rb for all active components, so this change will not be disruptive in existing or new applications. | ||||
* | Improve AbstractController layouts coverage. | José Valim | 2009-11-01 | 1 | -2/+2 |
| | |||||
* | Reduce TextTemplate cost for simple cases | Yehuda Katz | 2009-10-28 | 1 | -1/+3 |
| | |||||
* | Make encodings work with Erubis and 1.9 again | Yehuda Katz | 2009-10-16 | 1 | -3/+5 |
| | |||||
* | Fix a bug where templates with locales were not being sorted correctly | Yehuda Katz | 2009-10-16 | 1 | -1/+1 |
| | |||||
* | Renamed Orchestra to Notifications once again [#3321 state:resolved] | José Valim | 2009-10-15 | 1 | -1/+1 |
| | |||||
* | Update Orchestra instrumentations and move part of logging to Orchestra. | José Valim | 2009-10-15 | 1 | -1/+1 |
| | |||||
* | Revert "Rename Orchestra to Notifications [#3321 state:resolved]" | José Valim | 2009-10-15 | 1 | -1/+1 |
| | | | | This reverts commit 8cbf825425dc8ad3770881ea4e100b9023c69ce2. | ||||
* | Make the erubis implementation easier for plugins to change. | Michael Koziarski | 2009-10-15 | 1 | -1/+4 |
| | |||||
* | Rename Orchestra to Notifications [#3321 state:resolved] | Joshua Peek | 2009-10-14 | 1 | -1/+1 |
| | |||||
* | Switch to on-by-default XSS escaping for rails. | Michael Koziarski | 2009-10-08 | 1 | -3/+25 |
| | | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration. | ||||
* | Restore split between require-time and runtime load path mungery. Simplifies ↵ | Jeremy Kemper | 2009-09-24 | 1 | -1/+1 |
| | | | | vendor requires. | ||||
* | Clean up log output for rendered templates | Joshua Peek | 2009-09-24 | 3 | -65/+85 |
| | |||||
* | Instrument process_action, render and sql. | José Valim | 2009-09-20 | 1 | -2/+4 |
| | |||||
* | Remove unused code in ActionView. | José Valim | 2009-09-15 | 3 | -130/+0 |
| | | | | Signed-off-by: Yehuda Katz <wycats@gmail.com> | ||||
* | Rollback AS bundler work and improve activation of vendored dependencies | Joshua Peek | 2009-09-13 | 1 | -1/+1 |
| | |||||
* | Replace :formats => ["*/*"] with the default formats set | Yehuda Katz + Carl Lerche | 2009-09-03 | 1 | -0/+2 |
| | |||||
* | Refactor ActionView::Resolver | Yehuda Katz + Carl Lerche | 2009-09-03 | 1 | -77/+95 |
| | |||||
* | Fix the */* with Net::HTTP bug [#3100 state:resolved] | Yehuda Katz + Carl Lerche | 2009-09-01 | 1 | -22/+9 |
| | |||||
* | Add a default parameter for Resolver#initialize | Carl Lerche | 2009-08-26 | 1 | -1/+1 |
| | |||||
* | Got tests to pass with some more changes. | Yehuda Katz | 2009-08-15 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | * request.formats is much simpler now * For XHRs or Accept headers with a single item, we use the Accept header * For other requests, we use params[:format] or fallback to HTML * This is primarily to work around the fact that browsers provide completely broken Accept headers, so we have to whitelist the few cases we can specifically isolate and treat other requests as coming from the browser * For APIs, we can support single-item Accept headers, which disambiguates from the browsers * Requests to an action that only has an XML template from the browser will no longer find the template. This worked previously because most browsers provide a catch-all */*, but this was mostly accidental behavior. If you want to serve XML, either use the :xml format in links, or explicitly specify the XML template: render "template.xml". | ||||
* | Caches and cache clearing seems to actually work, but the actual ↵ | Yehuda Katz | 2009-08-15 | 1 | -1/+16 |
| | | | | architecture is kind of messy. Next: CLEAN UP. | ||||
* | More cleanup of ActionView and reduction in need for blocks in some cases: | Yehuda Katz | 2009-08-15 | 2 | -5/+0 |
| | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine | ||||
* | Clean up ActionView some: | Yehuda Katz | 2009-08-15 | 2 | -3/+11 |
| | | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView | ||||
* | Add some more caching to the lookup | Yehuda Katz | 2009-08-11 | 1 | -12/+18 |
| | |||||
* | This change causes some failing tests, but it should be possible to make ↵ | Yehuda Katz | 2009-08-11 | 1 | -2/+4 |
| | | | | them pass with minimal performance impact. | ||||
* | Rendering a template from ActionView will default to looking for partials ↵ | Yehuda Katz | 2009-08-09 | 1 | -1/+3 |
| | | | | | | | | | only in the current mime type. * The old behavior was tested only as a side-effect of a different test--the original tests remain; a new template in the XML mime was added. * If you are relying on the current behavior and object to this change, please participate in http://groups.google.com/group/rubyonrails-core/browse_thread/thread/6ef25f3c108389bd | ||||
* | Cache some more things to improve partial perf | Yehuda Katz | 2009-08-09 | 1 | -2/+6 |
| | |||||
* | Went from 25% slower partials (vs. 2.3) to 10% faster. More to come. | Yehuda Katz | 2009-08-09 | 1 | -2/+2 |
| | |||||
* | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 1 | -1/+1 |
| | |||||
* | Separate ActionView::Context so something else can easily be made into an AV ↵ | Yehuda Katz | 2009-07-19 | 2 | -5/+5 |
| | | | | context | ||||
* | Fix pattern to match various magic comment formats | Akira Matsuda | 2009-07-01 | 1 | -1/+1 |
| | |||||
* | Try speeding up rails booting | Yehuda Katz + Carl Lerche | 2009-06-25 | 2 | -3/+3 |
| | |||||
* | Cleaning up if defined?(ActionController::Http) blocks from the pre new base ↵ | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -2/+1 |
| | | | | era. | ||||
* | Rename path.rb to resolver.rb | Yehuda Katz + Carl Lerche | 2009-06-17 | 2 | -1/+1 |
| | |||||
* | Rename ActionView::Template::Path ActionView::Resolver | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -125/+124 |
| | |||||
* | Fixing pending tests and fixed some formats / partial rendering semantics | Yehuda Katz + Carl Lerche | 2009-06-17 | 4 | -5/+3 |
| | |||||
* | ActionPack components should no longer have undeclared dependencies. | Yehuda Katz + Carl Lerche | 2009-06-08 | 1 | -0/+2 |
| | | | | | | | * Tests can be run in isolation * Dependencies added * A few tests modified to avoid depending on AS deps not depended on my files they were testing | ||||
* | Ensure ERB source begins with the encoding comment | Jeremy Kemper | 2009-06-01 | 2 | -2/+8 |
| | |||||
* | Ruby 1.9: ERB template encoding using a magic comment at the top of the file | Jeremy Kemper | 2009-05-28 | 2 | -8/+14 |
| | |||||
* | Get controller/render_other_test.rb to pass on new base and fixed a bug in ↵ | Yehuda Katz + Carl Lerche | 2009-05-22 | 1 | -1/+2 |
| | | | | new base with regards to rendering layouts. | ||||
* | Get controller/layout_test.rb running on new base except for ↵ | Yehuda Katz + Carl Lerche | 2009-05-22 | 2 | -1/+5 |
| | | | | ActionController::Base.exempt_from_layout which is going to be deprecated. | ||||
* | Move Safari response-padding fix to Rails2Compatibility. Should be a Rack ↵ | Jeremy Kemper | 2009-05-21 | 1 | -1/+1 |
| | | | | concern. | ||||
* | Added the :rjs render option | Yehuda Katz + Carl Lerche | 2009-05-21 | 1 | -0/+1 |
| | |||||
* | Remove some response content type concepts from ActionView | Yehuda Katz + Carl Lerche | 2009-05-21 | 5 | -7/+23 |
| | |||||
* | Added responds_to to new base. | Yehuda Katz + Carl Lerche | 2009-05-20 | 1 | -1/+6 |
| |