Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Do not generate local vars for partials without object or collection | Carlos Antonio da Silva | 2013-01-08 | 1 | -1/+1 |
| | | | | | | | | | Previously rendering a partial without giving :object or :collection would generate a local variable with the partial name by default. This was noticed due to warnings in Ruby 2.0 of not used variables, which turned out to be the generation of not used variables inside partials that do not contain objects related to them. | ||||
* | Replace some global Hash usages with the new thread safe cache. | thedarkone | 2012-12-14 | 1 | -1/+5 |
| | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler. | ||||
* | More descriptive error when rendering a partial with `:layout => true` | Yves Senn | 2012-12-02 | 1 | -1/+1 |
| | |||||
* | Remove private partial/template renderer methods | Carlos Antonio da Silva | 2012-11-21 | 3 | -14/+3 |
| | | | | | | Since now these objects are not cached anymore, there's no need to have these private methods, just instantiate each of them in the necessary place. | ||||
* | render every partial with a new `PartialRenderer`. | Yves Senn | 2012-11-19 | 1 | -2/+2 |
| | | | | | | | | This resolves issues when rendering nested partials. Previously the `PartialRenderer` was reused which led to situations where the state of the renderer was reset. Closes #8197 | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 1 | -27/+27 |
|\ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | ||||
| * | Hash Syntax to 1.9 related changes | AvnerCohen | 2012-10-29 | 1 | -27/+27 |
| | | |||||
* | | Fix gratuitous use of ternary operator | Caleb Thompson | 2012-10-25 | 1 | -2/+5 |
|/ | |||||
* | Use ActionView::Base.logger instead of AC::Base.logger | Piotr Sarnacki | 2012-08-28 | 1 | -1/+1 |
| | |||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | Check validity of options[:as] just once | José Valim | 2012-08-02 | 1 | -12/+18 |
| | |||||
* | Improve error handling when using partial name with hyphen. Fix #7079 | kennyj | 2012-08-03 | 1 | -7/+12 |
| | |||||
* | Common behavior with adding formats to lookup_context for TemplateRenderer ↵ | Dmitry Vorotilin | 2012-07-18 | 3 | -2/+11 |
| | | | | and PartialRenderer | ||||
* | :update_details method no more exists on @lookup_context | Akira Matsuda | 2012-06-26 | 1 | -2/+1 |
| | | | | the method has gone in this commit: 119e9e2dafb0cdc5b85613b730333679aef534af | ||||
* | fix some accidental nils | Aaron Patterson | 2012-06-22 | 1 | -2/+2 |
| | |||||
* | fix typo in render_template [ci skip] | Brent Vatne | 2012-05-29 | 1 | -1/+1 |
| | |||||
* | Improve and cleanup a bit partial renderer | Carlos Antonio da Silva | 2012-05-12 | 2 | -38/+37 |
| | | | | | | | | | | * Remove template assignment: there is no need for this assignment, given we are rendering a collection with possibly different templates, and a second call to render (with the same instance) would behave differently if the template is set. * Remove segments array in favor of Array#map * Use local vars whenever possible * Cache local template keys, remove defaults from find_template | ||||
* | Adjust error message for partial names starting with an uppercase letter. | Marc-Andre Lafortune | 2012-05-04 | 1 | -2/+2 |
| | |||||
* | Add changelog entry and some docs for collection + layout | Carlos Antonio da Silva | 2012-04-29 | 1 | -3/+7 |
| | |||||
* | Move layout logic with collection to be handled only with explicit template ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -15/+8 |
| | | | | | | | is given Layout is never an available option when rendering with the shortcut `render @collection`. | ||||
* | Allow access to current object_counter variable from layout when rendering ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -1/+2 |
| | | | | with partial + collection | ||||
* | Allow layout to access current object being rendered when using render ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -1/+1 |
| | | | | partial + object | ||||
* | Allow layout rendering to access current object being rendered when using ↵ | Carlos Antonio da Silva | 2012-04-29 | 1 | -6/+11 |
| | | | | partial + collection | ||||
* | converting some tests to assert_raises, and DRY'ing retrieve_variable changes | Tieg Zaharia | 2012-04-16 | 1 | -1/+1 |
| | |||||
* | catch nil.to_sym errors in partial_renderer, and raise ArgumentError instead | Tieg Zaharia | 2012-04-16 | 1 | -1/+1 |
| | |||||
* | Make controller namespace partial prefix optional | Grant Hutchins | 2012-03-28 | 1 | -3/+10 |
| | | | | | | | config.action_view.prefix_partial_path_with_controller_namespace This allows you to choose to render @post using /posts/_post.erb instead of /admin/posts/_post.erb inside Admin::PostsController. | ||||
* | Set proper rendered_format when doing render :inline | Santiago Pastorino | 2012-03-28 | 1 | -2/+2 |
| | | | | Closes #5632 | ||||
* | If partial is rendered in controller, grab format from template | Piotr Sarnacki | 2012-03-27 | 1 | -2/+8 |
| | | | | | | | | | Previously `rendered_format` was set only based on mime types passed in Accept header, which was wrong if first type from Accept was different than rendered partial. The fix is to simply move setting rendered_format to the place where template is available and grab format from the template. If it fails we can fallback to formats passed by Accept header. | ||||
* | Fixed-width font fix for instance variable | Juanjo Bazán | 2012-03-20 | 1 | -1/+1 |
| | |||||
* | Just change the formats on first render, closes #5307, closes #5308. | José Valim | 2012-03-07 | 1 | -2/+7 |
| | |||||
* | Adds line to change log and update documentation. | Sergio Arbeo | 2012-03-07 | 1 | -0/+37 |
| | |||||
* | Adds :layout option to render :partial when a collection is given. | Sergio Arbeo | 2012-03-06 | 1 | -1/+9 |
| | |||||
* | Fix #5238, rendered_format is not set when template is not rendered | Piotr Sarnacki | 2012-03-02 | 1 | -0/+2 |
| | |||||
* | format lookup for partials is derived from the format in which the template ↵ | Santiago Pastorino | 2012-02-22 | 2 | -2/+3 |
| | | | | | | is being rendered Closes #5025 part 2 | ||||
* | to_proper_path -> to_partial_path | José Valim | 2012-01-31 | 1 | -1/+1 |
| | |||||
* | Update actionpack/lib/action_view/renderer/partial_renderer.rb | José Valim | 2012-01-31 | 1 | -2/+1 |
| | |||||
* | Whitespaces :scissors: | Rafael Mendonça França | 2012-01-05 | 1 | -2/+2 |
| | |||||
* | Change more Array.wrap to Kernel#Array | Rafael Mendonça França | 2012-01-05 | 2 | -2/+1 |
| | |||||
* | removes comment obsoleted by 18ed37b | Xavier Noria | 2011-12-31 | 1 | -3/+0 |
| | |||||
* | fiber is available in ruby19 | Vishnu Atrai | 2011-12-31 | 1 | -1/+1 |
| | |||||
* | raises an ArgumentError if no valid options are given to ↵ | Lucas Mazza | 2011-12-21 | 1 | -0/+2 |
| | | | | TemplateRenderer#determine_template | ||||
* | Remove deprecation warnings from Action Pack. | José Valim | 2011-12-20 | 3 | -21/+1 |
| | |||||
* | Update partials documentation, partial_path is no longer generated using ↵ | Piotr Sarnacki | 2011-12-10 | 1 | -10/+13 |
| | | | | RecordIdentifier | ||||
* | Simplify path traversal logic | José Valim | 2011-12-09 | 1 | -7/+7 |
| | |||||
* | Fix another regression related to the layout optimization. | José Valim | 2011-12-08 | 1 | -0/+2 |
| | |||||
* | Fix a regression and also fix broken test. | José Valim | 2011-12-08 | 1 | -4/+9 |
| | |||||
* | Optimize layout lookup to avoid double calls. | José Valim | 2011-12-08 | 1 | -7/+14 |
| | |||||
* | Remove #:nodoc: from partial renderer. | José Valim | 2011-12-07 | 1 | -1/+1 |
| | |||||
* | Meaningful errors for unexpected partial arguments. Fixes #3573 | Tobias Svensson | 2011-11-19 | 1 | -2/+7 |
| | |||||
* | closes #3241 - partial doc fix | Vijay Dev | 2011-10-07 | 1 | -1/+1 |
| |