Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 1 | -29/+8 |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | ||||
* | Allow anything that responds to render to be given as :template and use ↵ | José Valim | 2010-03-12 | 1 | -5/+4 |
| | | | | find_template instead of find in views. | ||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -5/+3 |
| | |||||
* | Bring AM up to date with new rendering stack. | José Valim | 2010-03-08 | 1 | -0/+2 |
| | |||||
* | Speed up performance in resolvers by adding fallbacks just when required. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | |||||
* | Rename Template::Lookup to LookupContext. | José Valim | 2010-03-08 | 1 | -2/+2 |
| | |||||
* | More refactoring on the views side of rendering. | José Valim | 2010-03-08 | 1 | -69/+26 |
| | |||||
* | Finally moved the find template logic to the views. | José Valim | 2010-03-08 | 1 | -16/+24 |
| | |||||
* | More cleanup on the layouts side. | José Valim | 2010-03-08 | 1 | -6/+4 |
| | |||||
* | Move layout lookup to views. | José Valim | 2010-03-08 | 1 | -1/+15 |
| | |||||
* | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -6/+2 |
| | | | | lookup. | ||||
* | Solved a problem that prevented render :file => work in layouts | Jose Fernandez | 2010-03-05 | 1 | -1/+1 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Change AV formats so they can delegate to the controller. Now users (or ↵ | Carlhuda | 2010-03-01 | 1 | -2/+6 |
| | | | | plugins) can override details_for_render in their controllers and add appropriate additional details. Now if only they could *do* something with those details... | ||||
* | More html_safe strings now use the safe_concat method | Santiago Pastorino and José Ignacio Costa | 2010-02-05 | 1 | -1/+1 |
| | | | | | | [#3856 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add missing require for Object#try [#3771 state:resolved] | Xavier Noria | 2010-01-22 | 1 | -0/+2 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Remove URI object from ActiveResource notification, send the :mailer class ↵ | José Valim | 2010-01-15 | 1 | -4/+1 |
| | | | | in AM (like in AP#process_action) and remove locale instrumentation. | ||||
* | Template rendering should include layout time. | José Valim | 2010-01-15 | 1 | -10/+10 |
| | |||||
* | Use underscore in notification namespaces. | José Valim | 2010-01-04 | 1 | -2/+2 |
| | |||||
* | Use namespaces in notifications. | José Valim | 2010-01-03 | 1 | -2/+3 |
| | |||||
* | Make rendering in ActionView happen through _render_template, as the ↵ | José Valim | 2009-12-31 | 1 | -30/+14 |
| | | | | rendering which comes from ActionController. | ||||
* | Remove ActionView inline logging to ActiveSupport::Notifications and create ↵ | José Valim | 2009-12-26 | 1 | -8/+1 |
| | | | | ActionController::Base#log_event, so everything can be logged within one listener. Also expose log_process_action as a hook for different modules to include their own information during the action processing. This allow ActiveRecord to hook and any other ORM. Finally, this commit changes 'Processing' and 'Rendering' in logs to 'Processed' and 'Rendered' because at the point it's logged, everying already happened. | ||||
* | Break instrumentation into several end-points so rendering of partials can ↵ | José Valim | 2009-12-26 | 1 | -7/+17 |
| | | | | be optimized. | ||||
* | Wrap layout rendering in one method: _render_layout (this should make ↵ | José Valim | 2009-12-26 | 1 | -6/+6 |
| | | | | partial instrumentation easier). | ||||
* | Dont introspect inline templates for the logger and cleanup a few styling issues | David Heinemeier Hansson | 2009-12-21 | 1 | -13/+9 |
| | |||||
* | When rendering layouts with blocks, use #capture to avoid assuming that the ↵ | Nathan Weizenbaum | 2009-11-05 | 1 | -4/+2 |
| | | | | | | return value is the block's content. Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | Remove ActionMailer helpers and rely on AbstractController one. | José Valim | 2009-11-01 | 1 | -1/+1 |
| | |||||
* | First pass at cleaning up action caching | Yehuda Katz | 2009-10-28 | 1 | -1/+0 |
| | |||||
* | Fix a bug where render :text could not handle yield :symbol. Fixes guides ↵ | Yehuda Katz | 2009-10-10 | 1 | -9/+13 |
| | | | | generation | ||||
* | Ported the new ActionView::TestCase from 2-3-stable to master [#3260 | Erik Ostrom | 2009-09-28 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | state:resolved] The test case now mimicks the template environment more closely, so it's possible to use render, load helper dependencies. This also fixes assert_select, and similar assertions. Because view tests and helpers generally don't render full templates assert_select looks first in rendered and then in output_buffer to find the rendered output. Additional `master'-only changes: Made the Action Pack Rakefile run the ActionView::TestCase tests, and made ActionView::Rendering#_render_text always return a string. Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Clean up log output for rendered templates | Joshua Peek | 2009-09-24 | 1 | -2/+2 |
| | |||||
* | Fixes ActionMailer regression [#3059 state:resolved] | Yehuda Katz | 2009-08-15 | 1 | -1/+1 |
| | |||||
* | More cleanup of ActionView and reduction in need for blocks in some cases: | Yehuda Katz | 2009-08-15 | 1 | -16/+6 |
| | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine | ||||
* | Clean up ActionView some: | Yehuda Katz | 2009-08-15 | 1 | -43/+18 |
| | | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView | ||||
* | First pass at making partial rendering an Object. More cleanup to come. | Yehuda Katz | 2009-08-08 | 1 | -2/+1 |
| | |||||
* | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 1 | -2/+2 |
| | |||||
* | Whitespace | Yehuda Katz | 2009-08-07 | 1 | -7/+7 |
| | |||||
* | Continue reworking the partial path. | Yehuda Katz | 2009-08-07 | 1 | -3/+6 |
| | | | | * TODO: Review ActionController calling render_template for certain partials. Might we be able to save logic by always delegating to AV's render_partial? | ||||
* | Modify various partial methods to carry along the block that can be passed ↵ | Yehuda Katz | 2009-08-07 | 1 | -10/+23 |
| | | | | | | | | | | in with render * _render_single_template, which renders a template without layout * _render_partial_unknown_type, which renders a partial of unknown type (the entry method for most partial rendering; supports strings, objects, and collections) * _render_partial_object, which renders a partial for a single object. * extracted _render_partial_path so it can be used to render the spacer without going through the public render :partial | ||||
* | Some more AV work: | Yehuda Katz | 2009-08-07 | 1 | -11/+7 |
| | | | | | | | | * rename _render_partial to _render_partial_unknown_type to reflect that for this call, we don't know the type. * Merge _render_partial_with_block and _render_partial_with_layout to _render_partial * TODO: Check to see if any more logic can be shared * TODO: See about streamlining block path so we can get rid of @_proc_for_layout * Remove @exempt_from_layout as it is no longer needed | ||||
* | Replace _render_template_with_layout with _render_template since the layout ↵ | Yehuda Katz | 2009-08-07 | 1 | -9/+13 |
| | | | | is optional | ||||
* | Some more AV refactoring: | Yehuda Katz | 2009-08-07 | 1 | -4/+4 |
| | | | | | * remove no longer used _array_like_objects * _render_content_with_layout renamed to _render_content since layout it optional * remove check for optional layout before _render_content | ||||
* | Start cleaning up partial path | Yehuda Katz | 2009-08-07 | 1 | -5/+11 |
| | |||||
* | replace _render_*_from_controller with render_* as they are intended to be ↵ | Yehuda Katz | 2009-08-06 | 1 | -1/+1 |
| | | | | public | ||||
* | Minor ActionView cleanup | Yehuda Katz + Carl Lerche | 2009-06-18 | 1 | -3/+1 |
| | |||||
* | Fix typo | Yehuda Katz + Carl Lerche | 2009-06-18 | 1 | -1/+1 |
| | |||||
* | Extract the layout proc into a method, and write documentation explaining ↵ | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -5/+38 |
| | | | | what the proc does in various cases. | ||||
* | Drive the final stake through @content_for_*'s heart! | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -18/+14 |
| | |||||
* | Cleaning up if defined?(ActionController::Http) blocks from the pre new base ↵ | Yehuda Katz + Carl Lerche | 2009-06-17 | 1 | -1/+0 |
| | | | | era. | ||||
* | Implemented redirects and partial rendering in new base. | Yehuda Katz + Carl Lerche | 2009-05-12 | 1 | -0/+5 |
| | |||||
* | Deprecate template, session, assigns, and layout accessors on response ↵ | Joshua Peek | 2009-04-28 | 1 | -1/+1 |
| | | | | object. Instead access them through the controller instance. This mainly affects functional test assertions. |