Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | render :template => 'foo/bar.json' now works as it should. | José Valim | 2010-10-07 | 1 | -6/+8 |
| | |||||
* | Make collection rendering faster. | José Valim | 2010-10-07 | 1 | -2/+2 |
| | |||||
* | Remove locals dependency from template. | José Valim | 2010-10-07 | 1 | -35/+45 |
| | | | | | | This means that templates does not need to store its source anymore, allowing us to reduce the ammount of memory taken by our Rails processes. Naively speaking, if your app/views contains 2MB of files, each of your processes (after being hit by a bunch of requests) will take 2MB less of memory after this commit. This is extremely important for the upcoming features. Since Rails will also render CSS and JS files, their source won't be stored as well allowing us to decrease the ammount of memory taken. | ||||
* | reviews 02656ac | Xavier Noria | 2010-09-13 | 1 | -18/+17 |
| | |||||
* | copy-edits 4eb8987 | Xavier Noria | 2010-09-13 | 1 | -3/+3 |
| | |||||
* | Add documentation for `:spacer_template` in Rails 3 | Prem Sichanugrist | 2010-09-13 | 1 | -0/+5 |
| | | | This setting was existed since Rails 2.3.x, and seems like it have been left out when we rewriting the documentation. | ||||
* | added documentation for :as and :object in PartialRenderer | Collin Miller | 2010-09-13 | 1 | -0/+32 |
| | | | | Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com> | ||||
* | in Rendering objects with RecordIdentifier example, locals should reference ↵ | Mark Hayes | 2010-08-12 | 1 | -1/+1 |
| | | | | @account not @buyer | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | Make sure a namespaced <%= render form %> still renders the _form partial ↵ | Jan De Poorter | 2010-06-20 | 1 | -1/+1 |
| | | | | | | | | | | | | [#4784 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Added title to some other files in actionpack/lib/action_view | Rizwan Reza | 2010-06-16 | 1 | -0/+2 |
|/ | |||||
* | Optimize the code added in fa99de0bd054576336c9 | José Valim | 2010-05-15 | 1 | -9/+19 |
| | |||||
* | make sure `as` is set before trying to build an #{as}_counter. [#2804 ↵ | Jeff Kreeftmeijer | 2010-05-15 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | partial counters with :as [#2804 state:resolved] | Jeff Kreeftmeijer | 2010-05-15 | 1 | -0/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Change event namespace ordering to most-significant first [#4504 state:resolved] | Justin George | 2010-05-02 | 1 | -2/+2 |
| | | | | | | | | | More work still needs to be done on some of these names (render_template.action_view and render_template!.action_view particularly) but this allows (for example) /^sql/ to subscribe to all the various ORMs without further modification Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Key partial name cache on controller and object class *names* to avoid ↵ | Jeremy Kemper | 2010-04-02 | 1 | -2/+2 |
| | | | | memory leaks in dev mode | ||||
* | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 1 | -0/+2 |
| | |||||
* | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-15 | 1 | -1/+1 |
|\ | |||||
| * | Allow anything that responds to render to be given as :template and use ↵ | José Valim | 2010-03-12 | 1 | -1/+1 |
| | | | | | | | | find_template instead of find in views. | ||||
* | | Merge remote branch 'mainstream/master' | Pratik Naik | 2010-03-12 | 1 | -38/+10 |
|\| | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/base.rb railties/lib/rails/configuration.rb railties/lib/rails/log_subscriber.rb | ||||
| * | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | | |||||
| * | Rename Template::Lookup to LookupContext. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | | |||||
| * | More refactoring on the views side of rendering. | José Valim | 2010-03-08 | 1 | -26/+7 |
| | | |||||
| * | More cleanup on the layouts side. | José Valim | 2010-03-08 | 1 | -11/+2 |
| | | |||||
| * | Move layout lookup to views. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | | |||||
| * | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -2/+2 |
| | | | | | | | | lookup. | ||||
* | | Updated documentation for block helpers in render/partials.rb | Jeroen van Dijk | 2010-03-12 | 1 | -3/+3 |
|/ | |||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 1 | -1/+1 |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | ||||
* | In heterogeneous collections, neither the @path nor the @template are ↵ | José Valim | 2010-01-15 | 1 | -1/+1 |
| | | | | available, so we need to tell that we are simply rendering a collection. | ||||
* | Provide useful information when instrumenting partials. | José Valim | 2010-01-11 | 1 | -8/+6 |
| | |||||
* | Use underscore in notification namespaces. | José Valim | 2010-01-04 | 1 | -2/+2 |
| | |||||
* | Use namespaces in notifications. | José Valim | 2010-01-03 | 1 | -3/+4 |
| | |||||
* | More <%= render(@posts) %> optimization. | José Valim | 2009-12-26 | 1 | -24/+20 |
| | |||||
* | Optimize <%= render(@posts) %>. | José Valim | 2009-12-26 | 1 | -4/+14 |
| | |||||
* | Break instrumentation into several end-points so rendering of partials can ↵ | José Valim | 2009-12-26 | 1 | -19/+23 |
| | | | | be optimized. | ||||
* | Wrap layout rendering in one method: _render_layout (this should make ↵ | José Valim | 2009-12-26 | 1 | -1/+1 |
| | | | | partial instrumentation easier). | ||||
* | Fix @renderer warning | Joshua Peek | 2009-12-01 | 1 | -10/+10 |
| | |||||
* | Fix issue with standalone ActionView | Yehuda Katz | 2009-10-09 | 1 | -1/+4 |
| | |||||
* | Switch to on-by-default XSS escaping for rails. | Michael Koziarski | 2009-10-08 | 1 | -1/+1 |
| | | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration. | ||||
* | Caches and cache clearing seems to actually work, but the actual ↵ | Yehuda Katz | 2009-08-15 | 1 | -49/+73 |
| | | | | architecture is kind of messy. Next: CLEAN UP. | ||||
* | More cleanup of ActionView and reduction in need for blocks in some cases: | Yehuda Katz | 2009-08-15 | 1 | -8/+5 |
| | | | | | | | | * only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine | ||||
* | Clean up ActionView some: | Yehuda Katz | 2009-08-15 | 1 | -2/+4 |
| | | | | | | | | | | * Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView | ||||
* | Tentatively accept the ":as or :object, but not both" solution | Yehuda Katz | 2009-08-11 | 1 | -22/+21 |
| | |||||
* | Further experimentation. Was able to cut the cost of rendering 100 partials ↵ | Yehuda Katz | 2009-08-11 | 1 | -9/+40 |
| | | | | | | | | | | in a collection in half. To discuss: What are the desired semantics (if any) for layouts in a collection. There are no tests for it at present, and I'm not sure if it's needed at all. Deprecated on this branch: `object` pointing at the current object in partials. You can still use the partial name, or use :as to achieve the same thing. This is obviously up for discussion. | ||||
* | Cache some more things to improve partial perf | Yehuda Katz | 2009-08-09 | 1 | -3/+3 |
| | |||||
* | Went from 25% slower partials (vs. 2.3) to 10% faster. More to come. | Yehuda Katz | 2009-08-09 | 1 | -3/+7 |
| | |||||
* | Clean up partial object some more; replace passing around a block to a ↵ | Yehuda Katz | 2009-08-09 | 1 | -35/+39 |
| | | | | single block ivar | ||||
* | Clean up initializer and some of the internals of PartialRenderer | Yehuda Katz | 2009-08-09 | 1 | -49/+41 |
| | |||||
* | Ruby 1.9 compat: can't implicitly set instance var using block arg | Jeremy Kemper | 2009-08-08 | 1 | -2/+2 |
| | |||||
* | First pass at making partial rendering an Object. More cleanup to come. | Yehuda Katz | 2009-08-08 | 1 | -60/+82 |
| |