Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 4 | -66/+20 |
| | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | ||||
* | with_output_buffer cannot assume there's an output_buffer | Xavier Noria | 2010-03-15 | 1 | -1/+1 |
| | | | | | | [#4182 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Making escaped things more readable | Santiago Pastorino | 2010-03-14 | 3 | -3/+3 |
| | |||||
* | Made asset_tag_helper use config.perform_caching instead of ↵ | Denis Odorcic | 2010-03-12 | 1 | -14/+14 |
| | | | | | | ActionController::Base.perform_caching Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 1 | -1/+0 |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | ||||
* | simplify alt tag generation for images | Eaden McKee | 2010-03-11 | 1 | -2/+2 |
| | | | | | | [#2837 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make form helpers work with <%= | wycats | 2010-03-09 | 4 | -14/+48 |
| | |||||
* | Deprecate block_called_from_erb? pending a solution for getting it into apps | Carlhuda | 2010-03-09 | 4 | -38/+45 |
| | |||||
* | Merge master. | José Valim | 2010-03-08 | 2 | -6/+10 |
|\ | |||||
| * | Make many parts of Rails lazy. In order to facilitate this, | wycats | 2010-03-07 | 2 | -6/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | add lazy_load_hooks.rb, which allows us to declare code that should be run at some later time. For instance, this allows us to defer requiring ActiveRecord::Base at boot time purely to apply configuration. Instead, we register a hook that should apply configuration once ActiveRecord::Base is loaded. With these changes, brings down total boot time of a new app to 300ms in production and 400ms in dev. TODO: rename base_hook | ||||
* | | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -2/+2 |
|/ | | | | lookup. | ||||
* | Adds disable option to date_helpers generated hidden fields when ↵ | Santiago Pastorino | 2010-03-05 | 1 | -1/+2 |
| | | | | | | | | html_options specifies it. ht by Marc Schütz [#3807 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Remove some of the blank rescues from number helper. This makes the code ↵ | Xavier Shay | 2010-03-05 | 1 | -44/+42 |
| | | | | | | easier to understand, as you're not left wondering what the rescue is actually doing. This does not change documented/tested behaviour. Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Fix a bunch of failing AP / AM specs created from the previous ↵ | Carl Lerche | 2010-03-04 | 1 | -1/+1 |
| | | | | AbstractController configuration refactor. | ||||
* | Start refactoring the method of configuring ActionView | Carlhuda | 2010-03-03 | 1 | -7/+0 |
| | |||||
* | ActionDispatch::Request deprecates #request_uri | Carl Lerche | 2010-03-03 | 1 | -1/+1 |
| | | | | * Refactored ActionPatch to use fullpath instead | ||||
* | Tweak the semantic of various URL related methods of ActionDispatch::Request | Carlhuda | 2010-03-03 | 1 | -2/+3 |
| | |||||
* | Work on deprecating ActionController::Base.relative_url_root | Carlhuda | 2010-03-03 | 1 | -2/+2 |
| | |||||
* | Change AV formats so they can delegate to the controller. Now users (or ↵ | Carlhuda | 2010-03-01 | 1 | -15/+17 |
| | | | | plugins) can override details_for_render in their controllers and add appropriate additional details. Now if only they could *do* something with those details... | ||||
* | Delegate formats to the controller | Carlhuda | 2010-03-01 | 1 | -0/+4 |
| | |||||
* | Final pass at removing the router from a global constant | Carlhuda | 2010-02-25 | 1 | -1/+1 |
| | |||||
* | Bump i18n for new public I18n.normalize_keys | Jeremy Kemper | 2010-02-25 | 1 | -1/+1 |
| | |||||
* | add time_separator for minutes only if minutes aren't hidden | Santiago Pastorino | 2010-02-25 | 1 | -1/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Use ActionDispatch::Routing everywhere | Martin Schürrer | 2010-02-21 | 2 | -2/+2 |
| | |||||
* | Require persisted? in ActiveModel::Lint and remove new_record? and ↵ | José Valim | 2010-02-21 | 3 | -12/+11 |
| | | | | destroyed? methods. ActionPack does not care if the resource is new or if it was destroyed, it cares only if it's persisted somewhere or not. | ||||
* | Remove empty line and trailing hash, breaks documentation generation | Dirkjan Bussink | 2010-02-19 | 1 | -2/+0 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | ruby 1.9 array.to_s returns a string representing an escaped array | Santiago Pastorino | 2010-02-18 | 1 | -1/+1 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | i18n translate with arrays issue solved | Santiago Pastorino | 2010-02-18 | 1 | -2/+3 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | Explicit html_escape removed when not needed | Santiago Pastorino and José Ignacio Costa | 2010-02-14 | 3 | -4/+4 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | html_escape mail_to when encode javascript and not hex | Santiago Pastorino and José Ignacio Costa | 2010-02-14 | 1 | -5/+3 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | content_tag should escape its input | Bruno Michel | 2010-02-14 | 7 | -15/+14 |
| | | | | Signed-off-by: Yehuda Katz <yehudakatz@YK.local> | ||||
* | simple_format returns a safe buffer escaping unsafe input [Santiago Pastorino] | David Heinemeier Hansson | 2010-02-12 | 1 | -1/+1 |
| | |||||
* | Safely concat the ending tag to simple_format or it will be escaped | David Heinemeier Hansson | 2010-02-12 | 1 | -1/+1 |
| | |||||
* | Fix pluralization for numbers formatted like '1.00' | Gabriel Mansour | 2010-02-07 | 1 | -1/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix nested attributes with specified collection. | José Valim | 2010-02-07 | 1 | -7/+11 |
| | |||||
* | More html_safe strings now use the safe_concat method | Santiago Pastorino and José Ignacio Costa | 2010-02-05 | 4 | -6/+6 |
| | | | | | | [#3856 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | HTML-escape csrf meta contents | Jeremy Kemper | 2010-02-04 | 1 | -1/+1 |
| | |||||
* | Expose CSRF param name also | Jeremy Kemper | 2010-02-04 | 1 | -1/+1 |
| | |||||
* | Expose CSRF tag for UJS adapters | Jeremy Kemper | 2010-02-04 | 1 | -0/+12 |
| | |||||
* | Configuration values should be on AV::Base. | José Valim | 2010-02-02 | 1 | -17/+4 |
| | |||||
* | Modify the behavior of `radio_button_tag` to use `sanitize_to_id` for ↵ | Prem Sichanugrist | 2010-02-02 | 1 | -3/+1 |
| | | | | | | consistency [#1792 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deleted all references to ActionView::SafeBuffer in favor of ↵ | Santiago Pastorino | 2010-01-31 | 1 | -1/+1 |
| | | | | | | ActiveSupport::SafeBuffer Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | action_view is requiring the deleted action_view/erb/util.rb file | Santiago Pastorino | 2010-01-31 | 1 | -1/+0 |
| | | | | Signed-off-by: Yehuda Katz <wycats@Yehuda-Katz.local> | ||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 15 | -51/+42 |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | ||||
* | UJS documentation. | Stefan Penner | 2010-01-31 | 3 | -33/+78 |
| | |||||
* | data-remote needs to be on the form and not the submit when using button_to ↵ | Erik St. Martin | 2010-01-31 | 1 | -1/+3 |
| | | | | :remote=>true | ||||
* | add :remote option to form_tag | Stephen St. Martin | 2010-01-31 | 1 | -0/+1 |
| | |||||
* | form_for should pass :remote to form_tag through html_options | Stephen St. Martin | 2010-01-31 | 1 | -0/+2 |
| | |||||
* | Add rel=nofollow on non get remote links | Joshua Peek | 2010-01-30 | 1 | -1/+1 |
| | |||||
* | Generate UJS code for :disable_with | Joshua Peek | 2010-01-30 | 2 | -14/+1 |
| |