Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Move ActionController::RecordIdentifier to ActionView | Piotr Sarnacki | 2012-08-28 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | Since it's more about DOM classes and ids it belongs to Action View better. What's more, it's more convenient to make it part of Action View to follow the rule that Action Pack can depend on Action View, but not the other way round. | |||||
* | | correct handling of date selects when using both disabled and discard options | Vasiliy Ermolovich | 2012-08-25 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | we should take disabled option not only from `html_options` hash but from `options` hash too like `build_select` method does it. So datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true }) datetime_select("post", "updated_at", :discard_minute => true , :disabled => true) both these variants work now closes #7431 | |||||
* | | copy edit the time_ago_in_words helper docs | Vijay Dev | 2012-08-23 | 1 | -4/+4 | |
| | | ||||||
* | | Merge pull request #7398 from iamvery/time_ago_in_words-docs | Vijay Dev | 2012-08-22 | 1 | -0/+7 | |
|\ \ | |/ |/| | Extended documentation for `time_ago_in_words` helper | |||||
| * | Extended documentation for `time_ago_in_words` helper | Jay Hayes | 2012-08-20 | 1 | -0/+7 | |
| | | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-08-22 | 1 | -4/+4 | |
|\ \ | ||||||
| * | | Make a doc example output in match actual output | Evan Farrar | 2012-08-15 | 1 | -4/+4 | |
| |/ | | | | | | | | | Make doc output in grouped_options_for_select divider example match actual output. The options groups were in backwards order of actual. | |||||
* | | option_tags coerced to "" instead of nil | Sandeep | 2012-08-21 | 1 | -0/+1 | |
| | | ||||||
* | | Fix documentation mistakes | Janko Marohnić | 2012-08-21 | 2 | -45/+45 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-08-16 | 1 | -1/+13 | |
|\ | ||||||
| * | copy edits [ci skip] | Vijay Dev | 2012-08-16 | 1 | -6/+7 | |
| | | ||||||
| * | Document the namespacing of controller actions per this discussion: | schneems | 2012-08-09 | 1 | -0/+11 | |
| | | | | | | https://github.com/rails/journey/issues/40 | |||||
* | | Add support for start_hour and end_hour options in select_hour helper | Evan Tann | 2012-08-13 | 1 | -1/+11 | |
| | | | | | | | | Updated documentation to demonstrate start_hour and end_hour options | |||||
* | | Grammar fix in ActionView docs/comments | Edward Ocampo-Gooding | 2012-08-12 | 1 | -1/+1 | |
| | | ||||||
* | | Ensure option_html_attributes does not modify the given option hashes | Carlos Antonio da Silva | 2012-08-11 | 1 | -1/+1 | |
| | | | | | | | | We can avoid creating extra hashes with #merge, and use #merge! instead. | |||||
* | | Simplify html attributes generation for options_for_select | Carlos Antonio da Silva | 2012-08-11 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | Further simplify the option_html_attributes method after the changes introduced in dacbcbe55745aa9e5484b10b11f65ccca7db1c54 to not escape the html options here (since they're going to be escaped down the chain in content tag). | |||||
* | | check for nil or empty record in form_for | schneems | 2012-08-10 | 1 | -0/+1 | |
| | | | | | | | | if nil or an empty array is passed into form_for you get a horrible error message, this one is much more indicative of what the programmer needs to know to fix the problem. | |||||
* | | Do not mark strip_tags result as html_safe | Santiago Pastorino | 2012-08-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465 | |||||
* | | Allow data attributes to be set as a first-level option for form_for, so you ↵ | David Heinemeier Hansson | 2012-08-08 | 1 | -0/+19 | |
| | | | | | | | | can write `form_for @record, data: { behavior: 'autosave' }` instead of `form_for @record, html: { data: { behavior: 'autosave' } }` *DHH* | |||||
* | | Modernize the documentation for view caching somewhat | David Heinemeier Hansson | 2012-08-08 | 1 | -16/+16 | |
| | | ||||||
* | | Deprecate `button_to_function` and `link_to_function` helpers. | Rafael Mendonça França | 2012-08-07 | 1 | -0/+40 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We recommend the use of Unobtrusive JavaScript instead. For example: link_to "Greeting", "#", :class => "nav_link" $(function() { $('.nav_link').click(function() { // Some complex code return false; }); }); or link_to "Greeting", '#', onclick: "alert('Hello world!'); return false", class: "nav_link" for simple cases. This reverts commit 3acdd652e9fe99481c879c84c5807a84eb9ad724. | |||||
* | | Rearrange example output of javascript_include_tag | Prem Sichanugrist | 2012-08-06 | 1 | -2/+2 | |
| | | ||||||
* | | Do not include application.js if it doesn't exists | Prem Sichanugrist | 2012-08-06 | 1 | -4/+7 | |
|/ | | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory. | |||||
* | Use content_tag here instead of manually building HTML | Santiago Pastorino | 2012-08-03 | 1 | -2/+6 | |
| | ||||||
* | load active_support/deprecation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 | |
| | ||||||
* | load active_support/core_ext/class/attribute in active_support/rails | Xavier Noria | 2012-08-02 | 2 | -2/+0 | |
| | ||||||
* | load active_support/concern in active_support/rails | Xavier Noria | 2012-08-02 | 2 | -2/+0 | |
| | ||||||
* | load active_support/core_ext/object/blank in active_support/rails | Xavier Noria | 2012-08-02 | 7 | -7/+0 | |
| | ||||||
* | flushing output should write to the stream rather than mutating the response ↵ | Aaron Patterson | 2012-07-29 | 1 | -1/+1 | |
| | | | | object | |||||
* | Replace the flush parameter with a Hash. | Lucas Mazza | 2012-07-24 | 1 | -4/+4 | |
| | ||||||
* | Merge pull request #7123 from nashby/data-in-options | Rafael Mendonça França | 2012-07-22 | 1 | -1/+1 | |
|\ | | | | | don't escape options in option_html_attributes method | |||||
| * | don't escape options in option_html_attributes method | Vasiliy Ermolovich | 2012-07-22 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | we don't need to escape values in this method as we pass these html attributes to `tag_options` method that handle escaping as well. it fixes the case when we want to pass html5 data options | |||||
* | | Add back `:disable_with` and change deprecation horizon to 4.1 | Carlos Galdino + Rafael Mendonça França | 2012-07-21 | 2 | -2/+39 | |
| | | ||||||
* | | Add back `:confirm` and change deprecation horizon to 4.1 | Carlos Galdino + Rafael Mendonça França | 2012-07-21 | 2 | -0/+56 | |
|/ | ||||||
* | Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` option | Carlos Galdino | 2012-07-18 | 2 | -46/+21 | |
| | | | | | | | | | This applies to the following helpers: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag` | |||||
* | Fixed bug creating invalid HTML in select options | Rusty Geldmacher | 2012-07-10 | 2 | -3/+3 | |
| | | | | | | When a select tag is created for a field with errors, then the inserted options will errantly have a <div class="field_with_errors"> wrapping them. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-07-07 | 1 | -1/+1 | |
|\ | ||||||
| * | use config.action_controller instead of ActionController::Base in example ↵ | Nick Howard | 2012-06-30 | 1 | -1/+1 | |
| | | | | | | | | code for asset_tag_helper | |||||
* | | Remove ActiveModel dependency from ActionPack | Guillermo Iguaran | 2012-06-30 | 1 | -13/+8 | |
|/ | | | | | | | | ActiveModel is used in ActionPack for ActiveModel::Naming for a few, mostly optional aspects of ActionPack related to automatically converting an ActiveModel compliant object into a key for params and routing. It uses only three methods of ActiveModel (ActiveModel::Naming.route_key, ActiveModel::Naming.singular_route_key and ActiveModel::Naming.param_key). | |||||
* | Do not propagate the :raise option to AS number helpers | Carlos Antonio da Silva | 2012-06-24 | 1 | -7/+19 | |
| | | | | | ActiveSupport::NumberHelper does not make use of :raise, so there's no need to propagate it down. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-22 | 2 | -1/+2 | |
|\ | ||||||
| * | fixes a few mistakes in api docs [ci skip] | Vijay Dev | 2012-06-22 | 1 | -1/+1 | |
| | | ||||||
| * | Fix misprint in UrlHelper module | Alexey Vakhov | 2012-06-18 | 1 | -1/+1 | |
| | | ||||||
| * | Add rdoc to phone_field | Gaurish Sharma | 2012-06-16 | 1 | -0/+1 | |
| | | | | | | [API docs](http://api.rubyonrails.org/classes/ActionView/Helpers/FormHelper.html#method-i-phone_field) for `phone_field` provide no information on what the method actually does. no description nor access to source code. so added this | |||||
* | | add :nodoc: to AV StylesheetIncludeTag, JavascriptIncludeTag and AssetIncludeTag | Francesco Rodriguez | 2012-06-19 | 3 | -4/+4 | |
|/ | ||||||
* | One-liner code for logger in ActionView::Helpers::ControllerHelper | Dmitry Vorotilin | 2012-06-05 | 1 | -5/+1 | |
| | ||||||
* | Merge pull request #6631 from yuki24/use_block_in_button_helper | José Valim | 2012-06-05 | 1 | -2/+13 | |
|\ | | | | | Accept a block in FormHelper#button | |||||
| * | accept a block in button helper. | Yuki Nishijima | 2012-06-05 | 1 | -2/+13 | |
| | | ||||||
* | | Metal controller doesn't have logger method, check it and then delegate | Dmitry Vorotilin | 2012-06-05 | 1 | -2/+8 | |
|/ | ||||||
* | Simplify link_to using content_tag | Carlos Antonio da Silva | 2012-05-31 | 1 | -12/+6 | |
| | | | | Add some tests for link_to with blocks and escaping content. |