Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Accept :remote as symbol in link_to options | Riley | 2012-10-06 | 1 | -1/+3 |
| | | | | | Accept either :remote or 'remote' in both the html_options and (url_)options hash arguments to link_to. | ||||
* | correct handling of date selects when using both disabled and discard options | Vasiliy Ermolovich | 2012-08-25 | 1 | -2/+5 |
| | | | | | | | | | | | | we should take disabled option not only from `html_options` hash but from `options` hash too like `build_select` method does it. So datetime_select("post", "updated_at", { :discard_minute => true }, { :disabled => true }) datetime_select("post", "updated_at", :discard_minute => true , :disabled => true) both these variants work now closes #7431 | ||||
* | Merge pull request #7410 from sandeepravi/default_options_helper_value | Rafael Mendonça França | 2012-08-21 | 1 | -0/+1 |
| | | | | | | option_tags coerced to "" instead of nil Closes #7404 | ||||
* | Merge branch '3-2-8' into 3-2-stable | Santiago Pastorino | 2012-08-09 | 2 | -3/+3 |
|\ | |||||
| * | Do not mark strip_tags result as html_safe | Santiago Pastorino | 2012-08-09 | 1 | -1/+1 |
| | | | | | | | | | | | | Thanks to Marek Labos & Nethemba CVE-2012-3465 | ||||
| * | escape select_tag :prompt values | Santiago Pastorino | 2012-08-09 | 1 | -2/+2 |
| | | | | | | | | CVE-2012-3463 | ||||
* | | Rearrange example output of javascript_include_tag | Prem Sichanugrist | 2012-08-06 | 1 | -2/+2 |
| | | |||||
* | | Do not include application.js if it doesn't exists | Prem Sichanugrist | 2012-08-06 | 1 | -5/+6 |
|/ | | | | | | Rails were including 'application.js' to the pack when using `javascript_include_tag :all` even there's no application.js in the public directory. | ||||
* | Revert "Deprecate link_to_function and button_to_function helpers" | Rafael Mendonça França | 2012-08-01 | 1 | -4/+0 |
| | | | | This reverts commit 9dc57fe9c4807fc0ad4b1590a931891d9faa3164. | ||||
* | Revert "Deprecate `:mouseover` options for `image_tag` helper." | Rafael Mendonça França | 2012-08-01 | 1 | -2/+0 |
| | | | | | | | This reverts commit 1aff7725c7a04cde202cca906208560a55409e6a. Conflicts: actionpack/CHANGELOG.md | ||||
* | Revert "Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` ↵ | Rafael Mendonça França | 2012-08-01 | 3 | -29/+9 |
| | | | | | | | | | | | option" Revert "Deprecate `:disable_with` in favor of `'data-disable-with'` option for `button_to` and `submit_tag` helpers." This reverts commit fc092a9cba5fceec38358072e50e09250cf58840. This reverts commit e9051e20aeb2c666db06b6217954737665878db7. This reverts commit d47d6e7eda3aa3e6aa28d0c17ac6801234bb97d1. This reverts commit 21141e777bdce8534e3755c8de7268324b3d8714. | ||||
* | Fixed bug creating invalid HTML in select options | Rusty Geldmacher | 2012-07-10 | 1 | -5/+5 |
| | | | | | | | | | When a select tag is created for a field with errors, and that select tag has :prompt or :include_blank options, then the inserted first option will errantly have a <div class="field_with_errors"> wrapping it. See https://github.com/rails/rails/issues/7017 | ||||
* | Fix NumberHelper options wrapping to prevent verbatim blocks being rendered ↵ | Mark J. Titorenko | 2012-07-02 | 1 | -90/+159 |
| | | | | | | | | | | instead of line continuations. While I'm at it, wrap long comment lines consistently. Conflicts: actionpack/lib/action_view/helpers/number_helper.rb There was just one conflict related to the addition of the :format option to number_to_percentage. | ||||
* | ActionController::Metal doesn't have logger method, check it and then delegate | Dmitry Vorotilin | 2012-06-16 | 1 | -2/+4 |
| | |||||
* | Deprecate `:confirm` in favor of `:data => { :confirm => 'Text' }` option | Carlos Galdino | 2012-06-05 | 2 | -2/+13 |
| | | | | | | | | | | | | This deprecation applies to: `button_to` `button_tag` `image_submit_tag` `link_to` `submit_tag` As :confirm is an UI specific option is better to use the data attributes, teaching users about unobtrusive JavaScript and how Rails works with it. | ||||
* | Fixed tag_helper data-attribute bug with BigDecimals | Bodacious | 2012-05-20 | 1 | -1/+1 |
| | |||||
* | Use right option for excerpt text helper in tests, fix build | Carlos Antonio da Silva | 2012-05-19 | 1 | -2/+2 |
| | | | | | | | `excerpt` text helper uses `:radius`, not `line_width` (that is used by `word_wrap` helper). Also cleanup some whitespaces. | ||||
* | Merge pull request #5020 from KL-7/fix-blank-image_tag-source | José Valim | 2012-05-18 | 1 | -2/+2 |
| | | | | Render img tag with empty src if empty string is passed to image_tag. | ||||
* | Deprecate old APIs for highlight, excerpt and word_wrap | Jeremy Walker | 2012-05-18 | 1 | -0/+9 |
| | |||||
* | Deprecate `:disable_with` for `button_tag` too | Carlos Galdino + Rafael Mendonça França | 2012-05-14 | 2 | -2/+4 |
| | |||||
* | Fix typo | Carlos Galdino + Rafael Mendonça França | 2012-05-14 | 1 | -1/+1 |
| | |||||
* | Deprecate `:disable_with` in favor of `'data-disable-with'` option for ↵ | Carlos Galdino + Rafael Mendonça França | 2012-05-14 | 2 | -6/+13 |
| | | | | `button_to` and `submit_tag` helpers. | ||||
* | Deprecate `:mouseover` options for `image_tag` helper. | Rafael Mendonça França | 2012-05-13 | 1 | -0/+2 |
| | |||||
* | Merge pull request #3237 from sakuro/data-url-scheme | Rafael Mendonça França | 2012-05-13 | 1 | -1/+1 |
| | | | | Support data: url scheme | ||||
* | Deprecate link_to_function and button_to_function helpers | Rafael Mendonça França | 2012-04-30 | 1 | -0/+4 |
| | |||||
* | Add missing require when helpers are used in isolation | Rafael Mendonça França | 2012-04-30 | 1 | -0/+1 |
| | |||||
* | Lazy load `default_form_builder` if it's passed as a string | Piotr Sarnacki | 2012-04-28 | 1 | -1/+7 |
| | | | | closes #3341 | ||||
* | Do not mutate options hash | Carlos Antonio da Silva | 2012-04-27 | 1 | -2/+2 |
| | |||||
* | fix number_to_human docs [ci skip] | Vijay Dev | 2012-04-26 | 1 | -2/+2 |
| | |||||
* | Cover one more case in auth_token and remote forms | Piotr Sarnacki | 2012-03-28 | 1 | -1/+1 |
| | | | | | If embedding auth_token in remote forms is off and we pass a value for auth_token it should respect it. | ||||
* | Added config.action_view.embed_authenticity_token_in_remote_forms | Piotr Sarnacki | 2012-03-28 | 1 | -8/+16 |
| | | | | | | | | There is a regression introduced in 16ee611fa, which breaks remote forms that should also work without javascript. This commit introduces config option that allows to configure this behavior defaulting to the old behavior (ie. include authenticity token in remote forms by default) | ||||
* | Merge pull request #5622 from rafaelfranca/fix-2492-3-2 | Jeremy Kemper | 2012-03-27 | 1 | -2/+3 |
|\ | | | | | [3-2-stable] Fix label_tag to merge the options hash with the object hash | ||||
| * | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -10/+5 |
| | | | | | | | | | | | | hash. Closes #2492 and #5614 | ||||
| * | Fixing issue #2492. ActionView::Base.field_error_proc doesn't call for label. | Andrey Samsonov | 2012-03-27 | 1 | -2/+8 |
| | | | | | | | | | | | | objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | | Don't break Haml with textarea newline fix. | James Coleman | 2012-03-27 | 2 | -2/+6 |
|/ | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation. | ||||
* | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -1/+4 |
| | |||||
* | Allow you to force the authenticity_token to be rendered even on remote ↵ | David Heinemeier Hansson | 2012-03-14 | 1 | -5/+9 |
| | | | | forms if you pass true | ||||
* | Do not include the authenticity token in forms where remote: true as ajax ↵ | David Heinemeier Hansson | 2012-03-14 | 1 | -2/+9 |
| | | | | forms use the meta-tag value | ||||
* | Merge branch '3-2-2' into 3-2-stable | Aaron Patterson | 2012-03-01 | 2 | -4/+4 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | * 3-2-2: bumping to 3.2.2 Ensure [] respects the status of the buffer. Merge pull request #4834 from sskirby/fix_usage_of_psql_in_db_test_prepare Merge pull request #5084 from johndouthat/patch-1 updating RAILS_VERSION delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options | ||||
| * | use AS::SafeBuffer#clone_empty for flushing the output_buffer | Akira Matsuda | 2012-02-20 | 1 | -1/+1 |
| | | |||||
| * | fix output safety issue with select options | Sergey Nartimov | 2012-02-20 | 1 | -3/+3 |
| | | |||||
* | | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 1 | -1/+1 |
|/ | | | | Closes #393 | ||||
* | don't set the hidden checkbox value if it's nil | Damien Mathieu | 2012-01-27 | 1 | -1/+1 |
| | |||||
* | check_box helper with :disabled => true generates disabled hidden field. ↵ | Tadas Tamošauskas | 2012-01-27 | 1 | -1/+1 |
| | | | | fixes #1953 | ||||
* | remove extra 'the' | Rohit Arondekar | 2012-01-26 | 1 | -1/+1 |
| | |||||
* | Merge pull request #4639 from joevandyk/datetime-infinity-select-fix | Aaron Patterson | 2012-01-24 | 1 | -1/+1 |
|\ | | | | | datetime_select fix for dates of -infinity and +infinity | ||||
| * | datetime_select should work with -/+ infinity dates | Joe Van Dyk | 2012-01-24 | 1 | -1/+1 |
| | | |||||
* | | Fix date_select with discard_month and discard_year options | Rafael Mendonça França | 2012-01-24 | 1 | -2/+2 |
| | | | | | | | | Closes #4553 and #4633 | ||||
* | | Fix date_select nil and blank and order case | Indrek Juhkam | 2012-01-24 | 1 | -1/+1 |
|/ | |||||
* | Merge pull request #4604 from ihid/3-2-stable | José Valim | 2012-01-22 | 1 | -0/+1 |
|\ | | | | | 3-2-stable: Fixed regression - unable to use a range as choices for form.select. |