aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_view/helpers
Commit message (Collapse)AuthorAgeFilesLines
...
* Removed unnecessary calls to image_path and hash lookups [#2827 state:resolved]Yehuda Katz + Carl Lerche2009-07-021-3/+3
|
* My suggestion to fix ticket 2401 [#2401 state:resolved]Jarl Friis2009-07-021-4/+6
| | | | Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* Adds a video_tag helper for the HTML5 video tag (similar to how the ↵Tieg Zaharia2009-07-022-1/+69
| | | | | | image_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* Patch FormTagHelper so that when a form tag is created, the div which holds ↵Elliot Winkler2009-07-011-2/+2
| | | | | | the form authenticity token is set to display:inline [#2846 state:resolved] Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
* Make text_area_tag escape contents by default.Chris Mear2009-06-271-0/+5
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2015 state:committed]
* Handle missing javascript/stylesheets assets by raising an exceptionChristos Zisopoulos2009-06-261-4/+28
| | | | | | | | | | | | An exception will be raised if a local javascript/stylesheet file included by the stylesheet_link_tag or javascript_include_tag can not be found. When caching is enabled, we use atomic_write to ensure that the cache file is not created with zero length. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2738 state:committed]
* Add content_for?(:name) helper to check if content_for(:name) is present ↵Darragh Curran2009-06-211-0/+22
| | | | | | [#1311 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Use errors[field] instead of errors.on(field)Jeremy Kemper2009-06-171-48/+11
|
* Extract the layout proc into a method, and write documentation explaining ↵Yehuda Katz + Carl Lerche2009-06-171-4/+0
| | | | what the proc does in various cases.
* Drive the final stake through @content_for_*'s heart!Yehuda Katz + Carl Lerche2009-06-171-3/+2
|
* Add :concat option to asset tag helpers to force concatenation.Joshua Peek2009-06-151-6/+18
| | | | | This is useful for working around IE's stylesheet limit. stylesheet_link_tag :all, :concat => true
* allow absolute paths for the asset cachesAndrew Kaspick2009-06-111-3/+3
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Sanitized the id generated by text_area_tag helper method. ↵Stephen Anderson2009-06-091-1/+1
| | | | | | text_area_tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Made label target radio button tags with values. Radio button now respects ↵David Stevenson2009-06-091-7/+19
| | | | | | inherited :index options when generating id. Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Uses Hash#symbolize_keysJeremy Kemper2009-06-081-0/+1
|
* Explicitly qualify constants in BasicObjectsJeremy Kemper2009-06-081-1/+1
|
* Use as_json instead of rails_to_jsonJeremy Kemper2009-06-081-2/+2
|
* ActionPack components should no longer have undeclared dependencies.Yehuda Katz + Carl Lerche2009-06-083-4/+6
| | | | | | | * Tests can be run in isolation * Dependencies added * A few tests modified to avoid depending on AS deps not depended on my files they were testing
* Add explicit requirement in a few cases it was missing.Yehuda Katz2009-06-023-0/+3
| | | TODO: Come up with the minimal core and remove all of these
* fix for IE incompatibility of :disable_with in submit_tagHan Kessels2009-06-011-1/+2
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Ruby 1.9: flushing the output buffer preserves its encodingJeremy Kemper2009-05-281-3/+10
|
* Added the :rjs render optionYehuda Katz + Carl Lerche2009-05-211-0/+2
|
* Merge branch 'master' of git@github.com:rails/railsJeremy Kemper2009-05-181-1/+6
|\
| * Truncate helper accepts a :separator for a more legible result [#1807 ↵Andy Stewart2009-05-181-1/+6
| | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* | Merge branch 'master' of git@github.com:rails/railsJeremy Kemper2009-05-184-8/+16
|\|
| * Ensure number_to_human_size does not strip zeros from the end [#1763 ↵Travis Briggs2009-05-171-1/+6
| | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Ensure auto_link does not ignore multiple trailing punctuations [#2504 ↵Lance Ivy2009-05-171-6/+7
| | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Allow strings to be sent as collection to select.José Valim2009-05-151-0/+2
| | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
| * Cleaning up more render testsYehuda Katz + Carl Lerche2009-05-141-1/+1
| |
* | Active Support dependenciesJeremy Kemper2009-05-141-0/+1
|/
* Cherry-pick core extensionsJeremy Kemper2009-05-131-4/+5
|
* Now that we have a separate internal rails_to_json, use a separate circular ↵Jeremy Kemper2009-04-261-2/+2
| | | | reference stack instead of sticking it in the options hash
* Use javascript_object_forJeremy Kemper2009-04-261-1/+1
|
* Only Object to_json alias is needed. Prefer nil options.Jeremy Kemper2009-04-261-2/+0
|
* Qualify toplevel constant references since we're in a BasicObjectJeremy Kemper2009-04-261-7/+7
|
* * Add pluggable JSON backends with support for the JSON gem. [rick]rick2009-04-232-12/+14
| | | | | | | | | | | | | | Example: ActiveSupport::JSON.backend = "JSONGem" All internal Rails JSON encoding is now handled by ActiveSupport::JSON.encode(). Use of #to_json is not recommended, as it may clash with other libraries that overwrite it. However, you can recover Rails specific functionality if you really want to use #to_json. gem 'json' ActiveSupport::JSON.backend = "JSONGem" class ActiveRecord::Base alias to_json rails_to_json end
* Fix tests on 1.9Jeremy Kemper2009-04-221-0/+2
|
* Merge docrailslifo2009-04-172-4/+4
|
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-1313-112/+476
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * Object names with underscore do the wrong lookup in I18n on error_messages_for.José Valim2009-04-051-1/+1
| | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2390 state:committed]
| * Merge docrailsPratik Naik2009-03-242-17/+24
| |
| * Merge branch 'master' into bodypartsJeremy Kemper2009-03-182-3/+3
| |\
| | * Merge docrailsPratik Naik2009-03-162-3/+3
| | |
| * | Introduce flush_output_buffer to append the buffer to the response body then ↵Jeremy Kemper2009-03-131-0/+8
| |/ | | | | | | start a new buffer. Useful for pushing custom parts to the response body without disrupting template rendering.
| * Ensure auto_link doesnt linkify URLs in the middle of a tag [#1523 ↵Eugene Pimenov2009-03-101-2/+3
| | | | | | | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Fixed number_to_phone to work with 7 digit numbers [#2176 state:resolved]rpheath2009-03-091-1/+3
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Prototype helpers support the onCreate callback.Jeremy Kemper2009-03-081-1/+1
| | | | | | | | [#1074 state:committed]
| * submit_tag with confirmation and disable_with [#660 state:resolved]Lawrence Pit2009-03-071-2/+2
| | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
| * Ensure Active Record error related view helpers escape the message [#1280 ↵Dan Barry2009-03-071-2/+2
| | | | | | | | | | | | state:resolved] [Inge Jørgensen, Dan Barry] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Pass a custom form builder on to nested fields_for calls. [#2023 ↵Eloy Duran2009-02-271-49/+83
| | | | | | | | | | | | status:committed] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>