Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | datetime_select should work with -/+ infinity dates | Joe Van Dyk | 2012-03-28 | 1 | -1/+1 |
| | |||||
* | Cover one more case in auth_token and remote forms | Piotr Sarnacki | 2012-03-28 | 1 | -1/+1 |
| | | | | | If embedding auth_token in remote forms is off and we pass a value for auth_token it should respect it. | ||||
* | config.action_view.embed_authenticity_token_in_remote_forms is true by default | Piotr Sarnacki | 2012-03-28 | 1 | -1/+1 |
| | | | | | | | Changed default value for `config.action_view.embed_authenticity_token_in_remote_forms` to `false`. This change breaks remote forms that need to work also without javascript, so if you need such behavior, you can either set it to `true` or explicitly pass `:authenticity_token => true` in form options | ||||
* | Added config.action_view.embed_authenticity_token_in_remote_forms | Piotr Sarnacki | 2012-03-28 | 1 | -8/+16 |
| | | | | | | | | | | | | There is a regression introduced in 16ee611fa, which breaks remote forms that should also work without javascript. This commit introduces config option that allows to configure this behavior defaulting to the old behavior (ie. include authenticity token in remote forms by default) Conflicts: actionpack/CHANGELOG.md | ||||
* | Merge pull request #5621 from rafaelfranca/fix-2492-master | Jeremy Kemper | 2012-03-27 | 1 | -3/+3 |
|\ | | | | | Fix label_tag to merge the options hash with the object hash | ||||
| * | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 2 | -12/+5 |
| | | | | | | | | | | | | hash. Closes #2492 and #5615 | ||||
| * | Fixing issue #2492 for master branch. ActionView::Base.field_error_proc ↵ | Andrey Samsonov | 2012-03-27 | 1 | -2/+9 |
| | | | | | | | | | | | | | | | | doesn't call for label. objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | | Don't break Haml with textarea newline fix. | James Coleman | 2012-03-27 | 2 | -2/+6 |
|/ | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation. | ||||
* | change number_with_precision to not return negative zeros | Tim McEwan | 2012-03-27 | 1 | -0/+1 |
| | |||||
* | Merge pull request #5561 from carlosantoniodasilva/form-builder-block-arg | Aaron Patterson | 2012-03-26 | 1 | -3/+9 |
|\ | | | | | Properly deprecate the block argument in AV FormBuilder | ||||
| * | Properly deprecate the block argument in AV FormBuilder | Carlos Antonio da Silva | 2012-03-23 | 1 | -3/+9 |
| | | | | | | | | | | | | | | | | | | Commit 56089ca986c767763f29159c8de0aa1ebabfd4d2 introduced a backward incompatible change by changing the method signature of the FormBuilder. This brings back the same method signature warning in case someone gives a block to the builder. More info: https://github.com/rails/rails/commit/56089ca986c767763f29159c8de0aa1ebabfd4d2#commitcomment-1116166 | ||||
* | | apply form_for namespace option to date_select | Sergey Nartimov | 2012-03-26 | 1 | -1/+4 |
| | | |||||
* | | Merge pull request #5183 from lest/patch-1 | José Valim | 2012-03-26 | 1 | -2/+3 |
|\ \ | | | | | | | use content_tag in button_to helper | ||||
| * | | use content_tag in button_to helper | Sergey Nartimov | 2012-03-14 | 1 | -2/+3 |
| | | | |||||
* | | | Remove code duplication | Rafael Mendonça França | 2012-03-19 | 1 | -11/+11 |
| |/ |/| | |||||
* | | Fixes issue #5222: DateTimeSelector builds invalid dates on leap day when ↵ | Jey Balachandran | 2012-03-18 | 1 | -6/+6 |
| | | | | | | | | discarding both day and month. | ||||
* | | time_tag support for blocks | Antonio Tapiador del Dujo | 2012-03-18 | 1 | -2/+7 |
| | | |||||
* | | Allow you to force the authenticity_token to be rendered even on remote ↵ | David Heinemeier Hansson | 2012-03-14 | 1 | -5/+9 |
| | | | | | | | | forms if you pass true | ||||
* | | Do not include the authenticity token in forms where remote: true as ajax ↵ | David Heinemeier Hansson | 2012-03-14 | 1 | -2/+9 |
|/ | | | | forms use the meta-tag value | ||||
* | Merge pull request #572 from sikachu/remove_activeresource | José Valim | 2012-03-13 | 1 | -1/+1 |
|\ | | | | | Remove Active Resource source files from the repository. | ||||
| * | Remove Active Resource source files from the repository | Prem Sichanugrist | 2012-03-13 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | Dear Active Resource, It's not that I hate you or anything, but you didn't get much attention lately. There're so many alternatives out there, and I think people have made their choice to use them than you. I think it's time for you to have a big rest, peacefully in this Git repository. I will miss you, @sikachu. | ||||
* | | add include_hidden option to checkbox tag | Sergey Nartimov | 2012-03-13 | 1 | -2/+8 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-13 | 1 | -66/+138 |
|\ | |||||
| * | Revised explanation of fields_for usage. | Mark Thomson | 2012-03-11 | 1 | -10/+39 |
| | | | | | | | | Minor tweak to previous comments on form_for and form_helper.rb preamble | ||||
| * | Added clarification to description of how initial form values are derived. | Mark Thomson | 2012-03-10 | 1 | -1/+2 |
| | | |||||
| * | Revised explanation of form_for usage | Mark Thomson | 2012-03-10 | 1 | -53/+84 |
| | | |||||
| * | Additional preamble comments in form_helper.rb. | Mark Thomson | 2012-03-08 | 1 | -7/+18 |
| | | |||||
| * | Small correction to the description of the role of the form builder. | Mark Thomson | 2012-03-08 | 1 | -1/+1 |
| | | | | | | | | (endpoints are generated by form_for without reference to the form builder) | ||||
* | | add 'include_hidden' option to select tag, closes #5402 | Vasiliy Ermolovich | 2012-03-13 | 2 | -1/+4 |
| | | |||||
* | | Merge pull request #5380 from benmmurphy/escape_unicode_paragraph_separator | Aaron Patterson | 2012-03-12 | 1 | -1/+3 |
|\ \ | | | | | | | ensure u2029 is escaped in escape_javascript helper | ||||
| * | | ensure u2029 is escaped in escape_javascript helper | benmmurphy | 2012-03-11 | 1 | -1/+3 |
| |/ | |||||
* | | Fix unintended removal of 'cols' from a text_area example. | Philip Arndt | 2012-03-12 | 1 | -1/+1 |
| | | |||||
* | | Fixes #5324 by removing default size options from input:text and default ↵ | Philip Arndt | 2012-03-10 | 4 | -22/+17 |
|/ | | | | cols and rows options from textarea. | ||||
* | simplify namespace assignment in fields_for | Sergey Nartimov | 2012-03-02 | 1 | -1/+1 |
| | |||||
* | Merge pull request #5242 from rails/opt_routes | José Valim | 2012-03-02 | 1 | -9/+14 |
|\ | | | | | | | | | | | | | | | Optimize routes generation in simple cases. If you pass to the route helper the same amount of arguments as the required segments, route generation will be optimized as a string interpolation. After this commit, `post_path(post)` is about 6.5 times faster, `post_url(post)` is about 5 times. | ||||
| * | Optimize url helpers. | Sergey Nartimov + José Valim | 2012-03-02 | 1 | -9/+14 |
| | | |||||
* | | Allow fieldsets to be created without a block. | Ben Pickles | 2012-03-01 | 1 | -2/+1 |
|/ | |||||
* | Merge branch 'master-security' | Aaron Patterson | 2012-03-01 | 2 | -4/+3 |
|\ | | | | | | | | | | | | | | | | | | | | | | | * master-security: Ensure [] respects the status of the buffer. delete vulnerable AS::SafeBuffer#[] use AS::SafeBuffer#clone_empty for flushing the output_buffer add AS::SafeBuffer#clone_empty fix output safety issue with select options Conflicts: actionpack/lib/action_view/helpers/tags/base.rb | ||||
| * | use AS::SafeBuffer#clone_empty for flushing the output_buffer | Akira Matsuda | 2012-02-20 | 1 | -1/+1 |
| | | |||||
| * | fix output safety issue with select options | Sergey Nartimov | 2012-02-20 | 1 | -3/+3 |
| | | |||||
* | | Change asset_host config language to be more helpful and accurate | Gabe Hollombe | 2012-02-28 | 1 | -2/+3 |
| | | |||||
* | | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 1 | -1/+1 |
| | | | | | | | | Closes #393 | ||||
* | | Fix collection_check_boxes and collection_radio_buttons when using local | Rafael Mendonça França | 2012-02-26 | 1 | -0/+1 |
| | | | | | | | | variables in the form builder | ||||
* | | Add documentation to object method of CollectionHelpers::Builder | Rafael Mendonça França | 2012-02-26 | 1 | -6/+6 |
| | | |||||
* | | use content_tag instead strings | Vasiliy Ermolovich | 2012-02-25 | 1 | -3/+4 |
| | | |||||
* | | Merge pull request #5117 from nashby/form-option-refactor | José Valim | 2012-02-25 | 1 | -17/+11 |
|\ \ | | | | | | | FormOptionsHelper refactor | ||||
| * | | refactor option_text_and_value and option_value_selected? methods | Vasiliy Ermolovich | 2012-02-21 | 1 | -10/+3 |
| | | | |||||
| * | | refactor time_zone_options_for_select | Vasiliy Ermolovich | 2012-02-21 | 1 | -7/+8 |
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BTW, select works quite faster then find_all: require 'benchmark' n = [1]*100_000_000 Benchmark.bm do |x| x.report { n.select { |a| a > 1 } } x.report { n.find_all { |a| a > 1 } } end user system total real 7.590000 0.010000 7.600000 ( 7.927171) 9.650000 0.010000 9.660000 ( 9.634406) | ||||
* | | consistently mention first patch, then put | Xavier Noria | 2012-02-24 | 1 | -1/+1 |
| | | | | | | | | | | | | There was a mix, sometimes patch first, sometimes put first. Use always patch first, since this is going to be the primary verb for updates. | ||||
* | | uses PATCH for the forms of persisted records, and routes PATCH and PUT to ↵ | Xavier Noria | 2012-02-24 | 1 | -1/+1 |
| | | | | | | | | the update action of resources |