Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Remove nodoc from FormBuilder because the methods inside are public API methods | Ryan Bigg | 2010-12-13 | 1 | -1/+1 |
| | |||||
* | class inheritable attributes is used no more! all internal use of class ↵ | Josh Kalderimis | 2010-11-20 | 1 | -2/+2 |
| | | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Remove deprecated form_for with strings or symbols" | José Valim | 2010-11-18 | 1 | -3/+9 |
| | | | | | | | | | | | | | | | | This code was not deprecated. What was deprecated is the following: form_for(:foo, @foo) Which now should be rewritten as: form_for(@foo, :as => :foo) The following format is valid: form_for(:foo) This reverts commit be797750e6ce866ea08307f63bf35304a965c8d4. | ||||
* | Remove deprecated form_for with strings or symbols | Leonardo Capillera | 2010-11-18 | 1 | -9/+3 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add f.submit to forms just to show the most common use case | Santiago Pastorino | 2010-11-14 | 1 | -0/+12 |
| | |||||
* | Merge branch 'spastorino-master' | Santiago Pastorino | 2010-11-14 | 1 | -2/+2 |
|\ | |||||
| * | This doesn't make sense here | Santiago Pastorino | 2010-11-14 | 1 | -2/+2 |
| | | |||||
* | | Add empty line between previous method and RDoc of submit to allow RDoc ↵ | Santiago Pastorino | 2010-11-14 | 1 | -0/+1 |
|/ | | | | appear on api.rubyonrails.org | ||||
* | fields_for should treat ActiveRecord::Relation as an array | Neeraj Singh | 2010-11-11 | 1 | -2/+2 |
| | | | | | | [#5795 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Just initialize options with an empty hash | Santiago Pastorino | 2010-11-03 | 1 | -2/+1 |
| | |||||
* | Call html_escape in ERB::Util module and don't mix it in in the helpers | Santiago Pastorino | 2010-10-18 | 1 | -2/+3 |
| | |||||
* | Revert "Make InstanceTagMethods#value_before_type_cast raise if the model ↵ | Santiago Pastorino | 2010-10-10 | 1 | -8/+3 |
| | | | | | | | | don't respond to attr_before_type_cast or attr method" And "Makes form_helper use overriden model accessors" This reverts commit 3ba8e3100548f10fce0c9784981a4589531476dd and fb0bd8c1092db51888ec4bb72af6c595e13c31fa. | ||||
* | Fixing search_field to remove object attribute from options hash [#5730 ↵ | Aditya Sanghi | 2010-10-02 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | tag value can be false, so nil? check is necessary | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -2/+2 |
| | |||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -14/+17 |
| | | | | everyone calls super as expected. | ||||
* | Ask if the instance variable is defined before asking for it, avoid *many* ↵ | Emilio Tagua | 2010-09-28 | 1 | -1/+5 |
| | | | | warnings. | ||||
* | Define @emitted_hidden_id if it doesn't exists and reuse it if it does. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | We don't need to check if the format exists to generate the url, it already ↵ | Carlos Antonio da Silva | 2010-09-26 | 1 | -8/+7 |
| | | | | does it internally | ||||
* | More cleanup on form helpers | Carlos Antonio da Silva | 2010-09-26 | 1 | -11/+12 |
| | |||||
* | Remove last tests with deprecated form_for and cleanup form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -4/+2 |
| | | | | | | | This cleans up the last bits of deprecation stuff from form_for helper. However there is still a bug when using :as => foo[], with index. The classes and ids are being generated using [], such as foo[]_edit. This bug already existed but it was not detected before. | ||||
* | Refactor form_for helper | Carlos Antonio da Silva | 2010-09-26 | 1 | -21/+11 |
| | |||||
* | resolves rdoc conflict | Xavier Noria | 2010-09-23 | 1 | -4/+6 |
|\ | |||||
| * | Document form_for behaviour when using file_field inside the block | Joost Baaij | 2010-09-21 | 1 | -1/+3 |
| | | |||||
| * | Typos | rspeicher | 2010-09-15 | 1 | -3/+3 |
| | | |||||
* | | file_field propagates up multipart property even inside of fields_for | Santiago Pastorino | 2010-09-20 | 1 | -8/+13 |
| | | |||||
* | | removing some warnings | Aaron Patterson | 2010-09-18 | 1 | -2/+2 |
| | | |||||
* | | freeze is not necessary | Aaron Patterson | 2010-09-18 | 1 | -3/+3 |
| | | |||||
* | | argument error is done for us | Aaron Patterson | 2010-09-18 | 1 | -2/+0 |
| | | |||||
* | | file_field makes the enclosing form multipart | Santiago Pastorino | 2010-09-18 | 1 | -19/+36 |
|/ | |||||
* | Change singular to param_key in form_helper, param_key is now used for ↵ | Piotr Sarnacki | 2010-09-11 | 1 | -2/+2 |
| | | | | | | generating field names Signed-off-by: Mikel Lindsaar <raasdnil@gmail.com> | ||||
* | Simplify form_for by removing *args and extract_options! (at asakusa.rb) | wycats | 2010-09-09 | 1 | -15/+16 |
| | |||||
* | Remove namespace for isolated namespaced models in forms | Piotr Sarnacki | 2010-09-03 | 1 | -5/+5 |
| | |||||
* | Added :format option for form_for helper and spec for this [#5226 ↵ | Alex Chrome | 2010-09-01 | 1 | -1/+9 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Speed up form_for by specializing extract_options! (at asakusa.rb) | wycats | 2010-08-31 | 1 | -6/+8 |
| | |||||
* | password_field renders with nil value by default | Santiago Pastorino | 2010-08-28 | 1 | -5/+5 |
| | | | | | | | | This makes the use of passwords secure by default if you want to render the value of the password_field you have to do for instance f.password_field(:password, :value => @user.password) # => <input type=password id=user_password name=user[password] value=#{@user.password} /> | ||||
* | type="password" for password_fields | Santiago Pastorino | 2010-08-28 | 1 | -4/+4 |
| | |||||
* | Make InstanceTagMethods#value_before_type_cast raise if the model don't ↵ | Santiago Pastorino | 2010-08-27 | 1 | -3/+8 |
| | | | | | | respond to attr_before_type_cast or attr method [#3374] [#5471 state:committed] | ||||
* | Fix label form helper to use I18n and html options, without the need of ↵ | Carlos Antonio da Silva | 2010-08-01 | 1 | -3/+4 |
| | | | | | | | | | | | 'nil' text param: Before: f.label :title, nil, :class => 'title' After : f.label :title, :class => 'title' [#5267 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Makes form_helper use overriden model accessors | Santiago Pastorino | 2010-08-01 | 1 | -3/+3 |
| | | | | [#3374 state:committed] | ||||
* | doc: form_for does return output rather than merely evaluate its block | Wincent Colaiuta | 2010-07-22 | 1 | -4/+0 |
| | |||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 1 | -5/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | remove size attribute from tag generated by file_field helper [#5084 ↵ | Miles Egan | 2010-07-13 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added documentation for usage of associative resources with form_for | Rizwan Reza | 2010-07-01 | 1 | -1/+11 |
| | |||||
* | Do not wrap hidden fields with error proc [#4962 state:resolved] | Carlos Antonio da Silva | 2010-06-25 | 1 | -1/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | make text_field and hidden_field omit the value attribute if the developer ↵ | Jeff Dean | 2010-06-23 | 1 | -4/+4 |
| | | | | | | explicitly passes in :value => nil [#4839 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | adds minus to value part of id [#4862 state:resolved] | RainerBlessing | 2010-06-22 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | removed 'unless const_defined?' code smell | Josh Kalderimis | 2010-06-21 | 1 | -9/+9 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | form_for without :html and with :remote should not error | David Genord II | 2010-06-18 | 1 | -1/+1 |
| | | | | | | | | | | | | [#4902 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> |