Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #5622 from rafaelfranca/fix-2492-3-2 | Jeremy Kemper | 2012-03-27 | 1 | -2/+3 |
|\ | | | | | [3-2-stable] Fix label_tag to merge the options hash with the object hash | ||||
| * | Check if the options hash already exists and merge it with the another | Rafael Mendonça França | 2012-03-27 | 1 | -10/+5 |
| | | | | | | | | | | | | hash. Closes #2492 and #5614 | ||||
| * | Fixing issue #2492. ActionView::Base.field_error_proc doesn't call for label. | Andrey Samsonov | 2012-03-27 | 1 | -2/+8 |
| | | | | | | | | | | | | objectify_options method should be applied to the proper options arg. See explanation and example of the bug - https://github.com/kryzhovnik/rails_field_error_proc_bug_example | ||||
* | | Don't break Haml with textarea newline fix. | James Coleman | 2012-03-27 | 1 | -1/+1 |
|/ | | | | | | See issue #393, issue #4000, issue #5190, and issue #5191. Adds a newline after the textarea opening tag based on @codykrieger's original patch so that we don't cause regressions in Haml-using apps. The regression caused textarea tags to add newlines to the field unintentionally (each update/save added an extra newline.) Also fix 6 more tests that didn't yet have the newline expectation. | ||||
* | Add a new line after the textarea opening tag. | Rafael Mendonça França | 2012-02-27 | 1 | -1/+1 |
| | | | | Closes #393 | ||||
* | don't set the hidden checkbox value if it's nil | Damien Mathieu | 2012-01-27 | 1 | -1/+1 |
| | |||||
* | check_box helper with :disabled => true generates disabled hidden field. ↵ | Tadas Tamošauskas | 2012-01-27 | 1 | -1/+1 |
| | | | | fixes #1953 | ||||
* | fix adding field_with_errors to date selects, closes #3487 | Vasiliy Ermolovich | 2011-12-20 | 1 | -1/+2 |
| | |||||
* | Add button_tag support to ActionView::Helpers::FormBuilder. | Will Farrington | 2011-12-11 | 1 | -0/+33 |
| | | | | | | | | | | This support is near-identical to the existing submit_tag support. Example: <%= form_for @post do |f| %> <%= f.button %> <% end %> | ||||
* | form_for with +:as+ option uses "action_as" as css class and id | Vasiliy Ermolovich | 2011-12-04 | 1 | -2/+2 |
| | |||||
* | minor typo fix | Vijay Dev | 2011-12-01 | 1 | -1/+1 |
| | |||||
* | add namespace options to form_for | Vasiliy Ermolovich | 2011-11-27 | 1 | -2/+9 |
| | | | | | You can provide a namespace for your form to ensure uniqueness of id attributes on form elements. The namespace attribute will be prefixed with underscore on the generate HTML id | ||||
* | fix label with block in erb | lest | 2011-11-27 | 1 | -2/+2 |
| | |||||
* | Fix impractical I18n lookup in nested fields_for | Alexander Uvarov | 2011-11-17 | 1 | -1/+9 |
| | |||||
* | Docs cosmetic fixes in Action View form_helper.rb | Alexey Vakhov | 2011-11-06 | 1 | -2/+2 |
| | |||||
* | Remove 'size' attribute from number_field form helper fixes #3454 | Waseem Ahmad | 2011-11-04 | 1 | -0/+2 |
| | | | | | f.number_field generates <input type="number", size="30"../> which is invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state | ||||
* | Rename new method to_path to to_partial_path to avoid conflicts with ↵ | José Valim | 2011-08-01 | 1 | -4/+4 |
| | | | | File#to_path and similar. | ||||
* | Rename class method to_path to _to_path and make it explicit that it is an ↵ | José Valim | 2011-07-28 | 1 | -2/+2 |
| | | | | internal method. | ||||
* | Merge pull request #2034 from Casecommons/to_path | José Valim | 2011-07-28 | 1 | -2/+6 |
|\ | | | | | Allow ActiveModel-compatible instances to define their own partial paths | ||||
| * | Let ActiveModel instances define partial paths. | Grant Hutchins & Peter Jaros | 2011-07-25 | 1 | -2/+6 |
| | | | | | | | | | | | | Deprecate ActiveModel::Name#partial_path. Now you should call #to_path directly on ActiveModel instances. | ||||
* | | Merge pull request #2095 from dgeb/issue-2094 | Aaron Patterson | 2011-07-26 | 1 | -1/+1 |
|\ \ | |/ |/| | Fixes overriding of options[:html][:remote] in form_for() (Issue #2094) | ||||
| * | fixed problem in which options[:html][:remote] would be overridden in ↵ | Dan Gebhardt | 2011-07-15 | 1 | -1/+1 |
| | | | | | | | | form_for() - fixes #2094 | ||||
* | | Missed a few instances of British English spelling in the last commit | Oemuer Oezkir | 2011-07-24 | 1 | -1/+1 |
| | | | | | | | | oh and obviously I meant according to Webster, not Weber | ||||
* | | Changed a few instances of of words in the API docs written in British ↵ | Oemuer Oezkir | 2011-07-24 | 1 | -2/+2 |
| | | | | | | | | | | | | English to American English(according to Weber) | ||||
* | | little details seen while doing a pass through what's new in docrails | Xavier Noria | 2011-07-23 | 1 | -6/+6 |
| | | |||||
* | | Update form helper documentation to match code. | Paul Battley | 2011-07-19 | 1 | -2/+2 |
| | | | | | | | | Change d3cfee11 removed the automatically generated object_name_submit id attributes on form submit elements. This makes the documentation match. | ||||
* | | minor corrections in form helpers guide and api docs | Vijay Dev | 2011-07-20 | 1 | -2/+2 |
| | | |||||
* | | examples for telephone_field, url_field and email_field | Ray Baxter | 2011-07-17 | 1 | -0/+12 |
| | | |||||
* | | document options to search_field | Ray Baxter | 2011-07-17 | 1 | -1/+22 |
| | | |||||
* | | use correct in description | Ray Baxter | 2011-07-17 | 1 | -1/+1 |
|/ | |||||
* | Don't require ActionView::Context as it's autoloaded | Andrew White | 2011-07-01 | 1 | -1/+0 |
| | |||||
* | Add missing requires for ActionView::Context and Module#instance_method_names | Andrew White | 2011-07-01 | 1 | -0/+2 |
| | |||||
* | Revert "Add method fields_for_with_index to FormHelper" | José Valim | 2011-07-01 | 1 | -18/+6 |
| | | | | | | | | This reverts commit 7c562d5e460d97b18e4f3367b3cfb13401732920. Conflicts: actionpack/lib/action_view/helpers/form_helper.rb | ||||
* | Fixed ActionView::FormOptionsHelper#select with :multiple => false | Bogdan Gusiev | 2011-06-30 | 1 | -1/+1 |
| | |||||
* | Test for extractable_options? within nested fields_for. | Sam Pohlenz | 2011-06-20 | 1 | -1/+1 |
| | | | | | This fixes an error when a record object that is a subclass of Hash is passed to fields_for, which is incorrectly interpreted as field options. | ||||
* | Typo. | R.T. Lechow | 2011-06-16 | 1 | -2/+2 |
| | |||||
* | form => form_for | Vijay Dev | 2011-06-15 | 1 | -1/+1 |
| | |||||
* | Clarify importance of *_attributes= writer methods for nested fields | Christine Yen | 2011-06-15 | 1 | -8/+12 |
| | |||||
* | The example in the API docs incorrectly indicated that form_for would use ↵ | Mark Roghelia | 2011-05-31 | 1 | -2/+2 |
| | | | | the same default route for both new and previously persisted records. The default path given in the example would have generated a routing error for new records. form_for actually uses polymorphic_path to determine which route to use based on the state of the record. The example has been updated to reflect the method's actual behavior. | ||||
* | Edited actionpack/lib/action_view/helpers/form_helper.rb via GitHub | José Valim | 2011-05-22 | 1 | -0/+1 |
| | |||||
* | Add method fields_for_with_index to FormHelper | Jorge Bejar | 2011-05-21 | 1 | -0/+19 |
| | |||||
* | Use record_name to make fields for methods more consistent | Carlos Antonio da Silva | 2011-05-14 | 1 | -6/+6 |
| | |||||
* | Refactor fields_for to make the api more clear, and fix usage with non ↵ | Carlos Antonio da Silva | 2011-05-14 | 1 | -26/+19 |
| | | | | nested attributes and without object | ||||
* | Cleanup instantiate builder method definition | Carlos Antonio da Silva | 2011-05-14 | 1 | -5/+2 |
| | |||||
* | Remove dependency from _template. | José Valim | 2011-05-01 | 1 | -1/+1 |
| | |||||
* | Start abstracting the renderer. | José Valim | 2011-05-01 | 1 | -0/+5 |
| | |||||
* | Allow a label with the value option to have value-specific translations. | Jason Garber | 2011-04-27 | 1 | -1/+2 |
| | |||||
* | attribute should be attributes | José Valim | 2011-04-14 | 1 | -1/+1 |
| | |||||
* | Edited actionpack/lib/action_view/helpers/form_helper.rb via GitHub | José Valim | 2011-04-14 | 1 | -2/+3 |
| | |||||
* | Allow FormHelper#form_for to specify the :method as a direct option instead ↵ | David Heinemeier Hansson | 2011-03-26 | 1 | -2/+13 |
| | | | | of through the :html hash [DHH] |