Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Clean up unused methods from AV::Base and pass in the template object on ↵ | José Valim | 2010-10-10 | 1 | -16/+13 |
| | | | | rendering. | ||||
* | Clean up the house before moving in the new furniture. | José Valim | 2010-10-10 | 1 | -3/+6 |
| | | | | This commit moves all the template rendering logic that was hanging around AV::Base to renderer objects. | ||||
* | Compile ActionController::Base.config's methods to avoid method_missing ↵ | thedarkone | 2010-09-27 | 1 | -2/+1 |
| | | | | overhead. | ||||
* | Tiny fixes to rdoc | Alexey Mahotkin | 2010-09-16 | 1 | -1/+1 |
| | |||||
* | Removing RJS hack | Thiago Pradi | 2010-09-02 | 1 | -5/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove NonConcattingString. | José Valim | 2010-08-29 | 1 | -3/+0 |
| | |||||
* | Unify routes naming by renaming router to routes | Piotr Sarnacki | 2010-07-02 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing ↵ | José Valim | 2010-06-24 | 1 | -0/+1 |
| | | | | frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] | ||||
* | In ActionView::TestCase::Behavior, assign variables right before | David Chelimsky | 2010-06-23 | 1 | -1/+5 |
| | | | | | | | | | | | rendering the view. - Previously, _assigns were locked down the first time _view was referenced. [#4931 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Adds title and description where needed. | Rizwan Reza | 2010-06-16 | 1 | -4/+6 |
| | |||||
* | removes spurious .rb in require | Xavier Noria | 2010-06-12 | 1 | -1/+1 |
| | |||||
* | adds missing require for having ActiveSupport::InheritableOptions defined | Xavier Noria | 2010-06-11 | 1 | -0/+1 |
| | |||||
* | Remove punctuate_body! No code in lib was using it and it had no documentation. | José Valim | 2010-06-10 | 1 | -6/+0 |
| | |||||
* | class_attribute is not a direct replacement of class_inheritable_*. | José Valim | 2010-06-10 | 1 | -10/+7 |
| | | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance. | ||||
* | Make AP test suite green once again and speed up performance in layouts ↵ | José Valim | 2010-06-07 | 1 | -1/+1 |
| | | | | lookup for some cases. | ||||
* | Optimize LookupContext | wycats | 2010-06-04 | 1 | -0/+1 |
| | |||||
* | Base options cant live in lazy loaded helpers as they then wont be available ↵ | David Heinemeier Hansson | 2010-05-31 | 1 | -0/+4 |
| | | | | to set for config | ||||
* | Avoid instance variable @output_buffer not initialized | Santiago Pastorino | 2010-05-19 | 1 | -1/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Only run load hooks once a file has been fully loaded. | Nathan Weizenbaum | 2010-04-27 | 1 | -2/+2 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | revises some <%= in rdoc | Xavier Noria | 2010-04-05 | 1 | -1/+2 |
| | |||||
* | Refactored url_for in AV to have its own instances of the helpers instead of ↵ | wycats | 2010-04-03 | 1 | -1/+6 |
| | | | | proxying back to the controller. This potentially allows for more standalone usage of AV. It also kicked up a lot of dust in the tests, which were mocking out controllers to get this behavior. By moving it to the view, it made a lot of the tests more standalone (a win) | ||||
* | Replace the placeholder base_hook API with on_load. To specify some code that | wycats | 2010-03-29 | 1 | -1/+1 |
| | | | | | | | | should run during framework load do: ActiveSupport.on_load(:action_controller) do # Code run in the context of AC::Base end | ||||
* | Move application configuration to the application configuration object, ↵ | José Valim | 2010-03-26 | 1 | -2/+2 |
| | | | | remove railtie_name and engine_name and allow to set the configuration object. | ||||
* | Eliminate an error from an implicit dependency on AV::Base | wycats | 2010-03-19 | 1 | -21/+0 |
| | |||||
* | Each controller class has it's own view context subclass. This removes the ↵ | Carlhuda | 2010-03-18 | 1 | -32/+0 |
| | | | | need for ActionView::Base.for_controller | ||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 1 | -2/+0 |
| | |||||
* | Use Array.wrap not Array() | Jeremy Kemper | 2010-03-17 | 1 | -1/+2 |
| | |||||
* | Modify assert_template to use notifications. Also, remove ↵ | Carlhuda | 2010-03-17 | 1 | -2/+7 |
| | | | | ActionController::Base#template since it is no longer needed. | ||||
* | Remove some 1.9 warnings (resulting in some fixed bugs). Remaining AM ↵ | wycats | 2010-03-17 | 1 | -0/+1 |
| | | | | warnings are in dependencies. | ||||
* | Do not always include the named URL helpers into AC::Base and AV::Base. | Carl Lerche | 2010-03-16 | 1 | -0/+4 |
| | |||||
* | Add deprecation notices for <% %>. | Carlhuda | 2010-03-15 | 1 | -0/+3 |
| | | | | | | | | | | | | | | | | * The approach is to compile <% %> into a method call that checks whether the value returned from a block is a String. If it is, it concats to the buffer and prints a deprecation warning. * <%= %> uses exactly the same logic to compile the template, which first checks to see whether it's compiling a block. * This should have no impact on other uses of block in templates. For instance, in <% [1,2,3].each do |i| %><%= i %><% end %>, the call to each returns an Array, not a String, so the result is not concatenated * In two cases (#capture and #cache), a String can be returned that should *never* be concatenated. We have temporarily created a String subclass called NonConcattingString which behaves (and is serialized) identically to String, but is not concatenated by the code that handles deprecated <% %> block helpers. Once we remove support for <% %> block helpers, we can remove NonConcattingString. | ||||
* | Finish cleaning up rendering stack from views and move assigns evaluation to ↵ | José Valim | 2010-03-12 | 1 | -9/+0 |
| | | | | controller (so plugins and/or controllers can overwrite just one method). | ||||
* | Allow anything that responds to render to be given as :template and use ↵ | José Valim | 2010-03-12 | 1 | -1/+1 |
| | | | | find_template instead of find in views. | ||||
* | Optimize and clean up how details key get expired. | José Valim | 2010-03-10 | 1 | -1/+1 |
| | |||||
* | Clean LookupContext API. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | |||||
* | Merge master. | José Valim | 2010-03-08 | 1 | -0/+2 |
|\ | |||||
| * | Make many parts of Rails lazy. In order to facilitate this, | wycats | 2010-03-07 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | add lazy_load_hooks.rb, which allows us to declare code that should be run at some later time. For instance, this allows us to defer requiring ActiveRecord::Base at boot time purely to apply configuration. Instead, we register a hook that should apply configuration once ActiveRecord::Base is loaded. With these changes, brings down total boot time of a new app to 300ms in production and 400ms in dev. TODO: rename base_hook | ||||
* | | Speed up performance in resolvers by adding fallbacks just when required. | José Valim | 2010-03-08 | 1 | -28/+18 |
| | | |||||
* | | Rename Template::Lookup to LookupContext. | José Valim | 2010-03-08 | 1 | -19/+8 |
| | | |||||
* | | More refactoring on the views side of rendering. | José Valim | 2010-03-08 | 1 | -1/+1 |
| | | |||||
* | | Move layout lookup to views. | José Valim | 2010-03-08 | 1 | -5/+1 |
| | | |||||
* | | Added template lookup responsible to hold all information used in template ↵ | José Valim | 2010-03-07 | 1 | -53/+25 |
|/ | | | | lookup. | ||||
* | Tweak how ActionPack handles InheritableOptions | Carl Lerche | 2010-03-03 | 1 | -1/+1 |
| | |||||
* | Start refactoring the method of configuring ActionView | Carlhuda | 2010-03-03 | 1 | -10/+2 |
| | |||||
* | Delegate formats to the controller | Carlhuda | 2010-03-01 | 1 | -2/+23 |
| | |||||
* | Renamed LocalizedCache to DetailsCache. | José Valim | 2010-02-24 | 1 | -1/+1 |
| | |||||
* | Include missing modules. | José Valim | 2010-02-22 | 1 | -2/+2 |
| | |||||
* | Convert to class_attribute | Jeremy Kemper | 2010-02-01 | 1 | -1/+2 |
| | |||||
* | For performance reasons, you can no longer call html_safe! on Strings. ↵ | Yehuda Katz | 2010-01-31 | 1 | -1/+1 |
| | | | | | | | | | | | | Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self). * Additionally, instead of doing concat("</form>".html_safe), you can do safe_concat("</form>"), which will skip both the flag set, and the flag check. * For the first pass, I converted virtually all #html_safe!s to #html_safe, and the tests pass. A further optimization would be to try to use #safe_concat as much as possible, reducing the performance impact if we know up front that a String is safe. | ||||
* | Improve missing template error messages a little bit. | José Valim | 2010-01-31 | 1 | -6/+11 |
| |