aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8713 from goshakkk/better-error-pageGuillermo Iguaran2013-01-032-12/+10
|\ | | | | Fix env toggling, improve error page styling
| * fix env toggling, improve error page stylingGosha Arinich2013-01-032-12/+10
| |
* | Merge pull request #8715 from goshakkk/refactor-mapperCarlos Antonio da Silva2013-01-031-9/+4
|\ \ | | | | | | Refactor Routing::Mapper#matches?
| * | refactor Routing::MapperGosha Arinich2013-01-031-9/+4
| |/
* | Explain the possible precautionsAndre Arko2013-01-021-3/+4
| |
* | Restore original remote_ip algorithm.Andre Arko2013-01-021-53/+112
|/ | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979
* Merge pull request #8697 from goshakkk/undupRafael Mendonça França2013-01-021-5/+3
|\ | | | | Remove another unnecessary dup
| * remove another unnecessary dupGosha Arinich2013-01-021-5/+3
| |
* | Merge pull request #8701 from senny/8700_double_slash_with_trailing_slashRafael Mendonça França2013-01-021-1/+5
|\ \ | | | | | | do not append a second slash when using `trailing_slash: true`
| * | do not append a second slash when usingYves Senn2013-01-021-1/+5
| |/
* | Fixing closing </p>Guillermo Iguaran2013-01-021-1/+1
| |
* | Fix a number of validation/style errors:Sam Ruby2013-01-022-8/+7
|/ | | | | | | | | | * <pre> is not allowed to be nested inside of <p> elements in HTML * Indentation of </p> doesn't match corresponding <p> * <p> element not explicitly closed * One more </div> than <div> In each case, the template was fixed to match how a HTML5 parser would "see" the resulting page.
* Merge pull request #8694 from goshakkk/undupCarlos Antonio da Silva2013-01-021-2/+1
|\ | | | | Remove unnecessary #dup
| * remove unnecessary #dupGosha Arinich2013-01-021-2/+1
| |
* | Merge pull request #8688 from goshakkk/error-page-toggleGuillermo Iguaran2013-01-021-3/+3
|\ \ | |/ |/| Allow toggling dumps on error page
| * allow toggling dumps instead of just showingGosha Arinich2013-01-021-3/+3
| |
* | Cleanup some unnecessary CSS on the new error page and reformat some lines.Lucas Mazza2013-01-021-12/+13
| |
* | add source line paddingGosha Arinich2013-01-021-0/+4
|/
* remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-021-1/+0
|
* Fix indent in UnknownAction templateGuillermo Iguaran2013-01-011-1/+1
|
* Summary and Details HTML elements aren't supported in all modern browsersGuillermo Iguaran2012-12-312-12/+12
|
* Add style to AV::Template::Error exception pageGuillermo Iguaran2012-12-312-14/+42
|
* Improve line-height to have better line spacing in exception messageGuillermo Iguaran2012-12-311-0/+1
|
* Add new style to Routing Error pageGuillermo Iguaran2012-12-311-19/+22
|
* Styling for exception pageGuillermo Iguaran2012-12-316-29/+150
|
* Add source extract to detailed exception pageGuillermo Iguaran2012-12-314-2/+34
|
* Merge pull request #8666 from mekishizufu/fix_lambdasSantiago Pastorino2012-12-311-2/+2
|\ | | | | Fix usage of lambda as a Rack endpoint
| * Fix usage of lambda as a Rack endpointJiri Pospisil2012-12-311-2/+2
| | | | | | | | The response body needs to respond_to? :each.
* | Alias refute methods to assert_not and perfer assert_not on testsRafael Mendonça França2012-12-311-1/+1
| |
* | Inherit from MiniTest::Unit::TestCase instead of MiniTest::SpecRafael Mendonça França2012-12-311-3/+0
|/
* Merge pull request #8662 from ↵Santiago Pastorino2012-12-311-2/+6
|\ | | | | | | | | senny/8661_should_not_append_charset_if_already_present Charset should not be appended to image/* type
| * charset should not be appended for `head` responsesYves Senn2012-12-311-2/+6
| | | | | | | | | | | | | | 1) Failure: test_head_created_with_image_png_content_type(RenderTest) [test/controller/render_test.rb:1238]: Expected: "image/png" Actual: "image/png; charset=utf-8"
* | Define [], []=, permanent, signed and encrypted as the only allowed methods ↵Santiago Pastorino2012-12-301-9/+57
|/ | | | for the non Raw Cookie classes
* Merge pull request #8627 from schneems/schneems/routes-1-9Rafael Mendonça França2012-12-261-1/+1
|\ | | | | Ruby 1.9 style hash in Route Inspector
| * Ruby 1.9 style hash in Route Inspectorschneems2012-12-271-1/+1
| |
* | We need to check explictly that env['action_dispatch.show_exceptions']Rafael Mendonça França2012-12-261-1/+1
| | | | | | | | | | | | is false. If it is nil we can't raise the exception
* | more descriptive return parametersHrvoje Šimić2012-12-261-4/+3
| |
* | return Mime::NullType if format is unknownAngelo Capilleri2012-12-221-1/+12
| | | | | | | | | | | | | | | | | | | | If a request has an unknown format, the methods html?, xml?, json? ...etc not raise an Exception. This patch add a class Mime::NullType, that is returned when request.format is unknown and it responds false to the methods that ends with '?' and true to 'nil?'. It refers to #7837, this issue is considered a improvement not a bug.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-12-211-0/+5
|\ \
| * | Add script_name option description and example for #url_for optionsIvan Vanyak2012-12-171-0/+5
| | |
* | | Fix indentation issuing warningCarlos Antonio da Silva2012-12-201-1/+1
| | |
* | | update AD::Journey to follow Rails coding conventionsFrancesco Rodriguez2012-12-2016-437/+439
| | |
* | | :nodoc: Journey because is not part of the public API [ci skip]Francesco Rodriguez2012-12-1920-78/+75
| | |
* | | remove code for Ruby 1.8.x supportFrancesco Rodriguez2012-12-191-7/+2
| | |
* | | Remove the actual extension file as well [ci skip]Andrew White2012-12-191-11/+0
| | |
* | | Remove obsolete Hash extension needed for Ruby 1.8.x supportAndrew White2012-12-191-1/+0
| | | | | | | | | | | | [ci skip]
* | | Integrate Journey into Action DispatchAndrew White2012-12-1927-1/+2339
| | | | | | | | | | | | | | | | | | | | | | | | Move the Journey code underneath the ActionDispatch namespace so that we don't pollute the global namespace with names that may be used for models. Fixes rails/journey#49.
* | | Minor js review [ci skip]Carlos Antonio da Silva2012-12-181-7/+7
| | | | | | | | | | | | Remove/add ; where necessary, fix indentation.
* | | Format routes as html on debug pageschneems2012-12-174-2/+76
| |/ |/| | | | | | | | | | | | | | | When someone gets a routing exception, the routes are rendered (starting in Rails 4.0). This PR brings parity between the html routes in the `rails/info/routes` path and when rendered from an exception. This is the continuation of #8521 which brought html formatted routes. In addition to bringing parity to the two views, we're keeping our views DRY by rendering off of the same partials. In this case Railties depends on partials provided by ActionDispatch. I'm open to alternative implementations. Ideally both views will use the same code so any improvements or updates to it will be reproduced on both. <hr /> ![](http://f.cl.ly/items/3O1D0K1v0j0i343O3T3T/Screen%20Shot%202012-12-17%20at%203.07.20%20PM.png)
* | Merge pull request #8529 from schneems/schneems/debug-exceptions-extend-pathSteve Klabnik2012-12-161-1/+1
|\ \ | |/ |/| DebugExceptions `File.join` => `File.expand_path`