aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* remove useless to_param callAaron Patterson2014-06-111-1/+1
| | | | | extract_subdomain always returns a string, and to_param calls to_s on a string
* only look up the subdomain onceAaron Patterson2014-06-111-3/+4
|
* scheme should contain one or more charactersAaron Patterson2014-06-111-1/+1
|
* pull the port out of the options hash onceAaron Patterson2014-06-111-2/+3
|
* remove useless nil checkAaron Patterson2014-06-111-2/+2
| | | | | | | | | irb(main):004:0> /foo/ !~ nil => true irb(main):005:0> /foo/ !~ 'bar' => true irb(main):006:0> /foo/ !~ 'foo' => false
* these methods are always called with a tld_parameterAaron Patterson2014-06-111-3/+3
| | | | | remove the default parameter since the methods are always called with a parameter
* rm `same_host?`. The same conditional is two lines down.Aaron Patterson2014-06-111-5/+3
|
* Revert "rm `same_host?`. The same conditional is two lines down."Aaron Patterson2014-06-111-5/+8
| | | | This reverts commit 79469b4b0c05a50e19699bc9b568042add2d4987.
* rm `same_host?`. The same conditional is two lines down.Aaron Patterson2014-06-111-8/+5
|
* cache host on the stack so we only look it up onceAaron Patterson2014-06-111-8/+9
|
* only pull :protocol from the options hash onceAaron Patterson2014-06-111-2/+3
|
* cache protocol on the stack to reduce options hash lookupsAaron Patterson2014-06-111-7/+7
|
* eliminate nil checks in normalize_portAaron Patterson2014-06-111-7/+7
|
* reduce hash lookups and disconnect normalize_port from the options hashAaron Patterson2014-06-111-9/+9
|
* Handle client disconnect during live streamingMatthew Draper2014-06-081-13/+47
| | | | .. even when the producer is blocked for a write.
* [ci skip] Fix capitalizationAkshay Vishnoi2014-06-071-2/+2
|
* remove another wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
|
* Use a frozen Set instance for CGI_VARIABLES.Nathaniel Bibler2014-06-051-8/+21
| | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
* Merge branch 'master' of github.com:rails/railsAaron Patterson2014-06-042-3/+2
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: For our build, stick with mail 2.5.x for now Correct result, previously showing wrong result Collapse PG default extractoin of most types to single regex Change wording of explanation about precision & scale of decimal numbers [ci skip] Cleaned up duplicated CHANGELOG entry [ci skip] reuse available belongs_to? method Convert StrongParameters cache to a hash. This fixes an unbounded memory leak demonstrated on @tenderlove's latest blog post: Partially revert deprecation of *_filter Pluralize params Add default_i18n_subject to the guides Fix regression on eager loading association based on SQL query rather than existing column. Relax mail gem constraint from ~> 2.5.4 to ~> 2.5, >= 2.5.4 Keep column defaults in type cast form Return a null column when no column exists for an attribute Refactor XML serializer to not depend on `serialized_attributes` Test the serialized types of virtual columns in XML implement ActiveRecord::Base#pretty_print + changelog Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| * Merge pull request #15349 from tgxworld/remove_duplicated_method_callRafael Mendonça França2014-06-032-3/+2
| |\ | | | | | | Remove duplicated HashWithIndifferentAccess#with_indifferent_access.
| | * Remove duplicated HashWithIndifferentAccess#with_indifferent_access.Guo Xiang Tan2014-05-262-3/+2
| | |
* | | push splitting "to" up the callstackAaron Patterson2014-06-031-15/+20
|/ /
* | Routes specifying 'to:' must be a string that contains a "#" or a rackAaron Patterson2014-06-031-3/+21
| | | | | | | | | | application. Use of a symbol should be replaced with `action: symbol`. Use of a string without a "#" should be replaced with `controller: string`.
* | push some options munging to an alternate constructorAaron Patterson2014-06-031-13/+19
| |
* | move options_constraints tests next to each otherAaron Patterson2014-06-031-2/+2
| |
* | only do is_a checks on `formatted` onceAaron Patterson2014-06-031-9/+5
| |
* | push options_constraints processing upAaron Patterson2014-06-031-22/+24
| | | | | | | | | | this lets us reduce is_a checks on the options_constraints and push "callable constraints" verification to the right place.
* | remove options as an ivarAaron Patterson2014-06-031-6/+8
| |
* | only do Regexp === option onceAaron Patterson2014-06-031-3/+4
| |
* | return early from add_request_methodAaron Patterson2014-06-031-11/+11
| |
* | only loop over `options` once (hopefully)Aaron Patterson2014-06-031-13/+11
| |
* | only loop through constraints onceAaron Patterson2014-06-031-19/+15
| |
* | change defaults allocation to a one-linerAaron Patterson2014-06-031-3/+2
| |
* | no longer need the scope ivarAaron Patterson2014-06-031-2/+1
| |
* | only look up scope[:module] onceAaron Patterson2014-06-031-6/+6
| |
* | remove IGNORE_OPTIONSAaron Patterson2014-06-031-4/+8
| |
* | :only is never used in Mapping, so rm the keyAaron Patterson2014-06-031-1/+2
| |
* | remove :defaults from the IGNORE_OPTIONS listAaron Patterson2014-06-031-4/+4
| |
* | remove :constraints from IGNORE_OPTIONSAaron Patterson2014-06-031-4/+5
| |
* | disconnect normalize_defaults! from options[:constraints]Aaron Patterson2014-06-031-6/+6
| |
* | disconnect options and scope from the `blocks` methodAaron Patterson2014-06-031-7/+8
| |
* | disconnect the constraints method from the options and scope hashesAaron Patterson2014-06-031-12/+15
| |
* | :on is removed from options before the Mapping is instantiated, so remove it ↵Aaron Patterson2014-06-031-1/+1
| | | | | | | | from IGNORE_OPTIONS
* | pull up via extraction and remove it from options / IGNORE_OPTIONSAaron Patterson2014-06-031-8/+6
| |
* | always make :via a listAaron Patterson2014-06-031-3/+2
| |
* | always pull out a via variable and simplify logicAaron Patterson2014-06-031-12/+15
| |
* | add a test for missing "via" parameterAaron Patterson2014-06-031-1/+1
| |
* | remove :as and :anchor from IGNORE_OPTIONSAaron Patterson2014-06-031-3/+5
| |
* | remove another value from IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
| |
* | shorten up IGNORE_OPTIONSAaron Patterson2014-06-031-2/+2
| | | | | | | | | | | | since we are now passing the format value around, we can remove it from the options hash, which means we don't need to consult as many values from IGNORE_OPTIONS