Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | push is_a check up to where the Constraints object is allocated | Aaron Patterson | 2014-05-26 | 2 | -6/+11 | |
| | | | | ||||||
| * | | | pass the request object to the application | Aaron Patterson | 2014-05-25 | 2 | -4/+3 | |
| | | | | ||||||
| * | | | pass a request to `matches?` so we can avoid creating excess requests | Aaron Patterson | 2014-05-25 | 2 | -7/+6 | |
| | | | | ||||||
| * | | | nothing is passed to `rack_app` anymore, so rm the params | Aaron Patterson | 2014-05-25 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | one fewer is_a check | Aaron Patterson | 2014-05-25 | 1 | -4/+3 | |
| | | | | ||||||
| * | | | Constraints#app should never return another Constraints object, so switch to ↵ | Aaron Patterson | 2014-05-25 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | if statement | |||||
| * | | | eliminate dispatcher is_a checks | Aaron Patterson | 2014-05-24 | 1 | -8/+14 | |
| | | | | ||||||
| * | | | push is_a?(Dispatcher) check in to one place | Aaron Patterson | 2014-05-24 | 3 | -14/+11 | |
| | | | | ||||||
| * | | | Always construct route objects with Constraint objects | Aaron Patterson | 2014-05-24 | 3 | -9/+7 | |
| | | | | ||||||
* | | | | Merge pull request #15321 from ↵ | Santiago Pastorino | 2014-05-27 | 1 | -1/+4 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | tgxworld/only_find_routes_as_heads_for_head_request Call get_routes_as_head only on HEAD requests. | |||||
| * | | | | Call get_routes_as_head only on HEAD requests. | Guo Xiang Tan | 2014-05-25 | 1 | -1/+4 | |
| | |_|/ | |/| | | ||||||
* | | | | Escape user input before showing in the page. | Rafael Mendonça França | 2014-05-26 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This is not a security issue since this page is not present in production and user have to type something in the field but is better to escape the input. | |||||
* | | | | Remove unnecessary flatten! method call. | Guo Xiang Tan | 2014-05-25 | 1 | -3/+1 | |
|/ / / | ||||||
* | | | Merge pull request #15305 from tgxworld/remove_unnecessary_require | Guillermo Iguaran | 2014-05-24 | 1 | -1/+0 | |
|\ \ \ | |/ / |/| | | Remove unnecessary require of Minitest. | |||||
| * | | Remove unnecessary require of Minitest. | Guo Xiang Tan | 2014-05-24 | 1 | -1/+0 | |
| | | | | | | | | | | | | Minitest has already been required when calling Minitest.autorun. | |||||
* | | | unwrap the constraints object on initialization, eliminate loops | Aaron Patterson | 2014-05-24 | 4 | -3/+12 | |
| | | | | | | | | | | | | | | | | | | | | | Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea. | |||||
* | | | Merge pull request #14986 from dlangevin/trailing-slash-url-generation | Rafael Mendonça França | 2014-05-24 | 1 | -7/+13 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb | |||||
| * | | | Fixes URL generation with trailing_slash: true | Dan Langevin | 2014-05-22 | 1 | -9/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash | |||||
* | | | | Merge pull request #15291 from francocatena/router-visualizer-fix | Rafael Mendonça França | 2014-05-23 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | Fix router visualizer CSS and JS resources | |||||
| * | | | | Fix router visualizer CSS and JS resources | Franco Catena | 2014-05-23 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | Constraints contructor should always return a Constraints object | Aaron Patterson | 2014-05-23 | 1 | -9/+5 | |
| | | | | | | | | | | | | | | | | | | | | I know, it's crazy. | |||||
* | | | | | default value is never used, so make it required | Aaron Patterson | 2014-05-23 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | push options decomposition up so we can extract | Aaron Patterson | 2014-05-23 | 1 | -20/+13 | |
|/ / / / | ||||||
* | | | | glob_param is never used, so rm | Aaron Patterson | 2014-05-23 | 2 | -9/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff). | |||||
* | | | | there is no formatter on the router object, so rm | Aaron Patterson | 2014-05-23 | 1 | -1/+0 | |
| | | | | ||||||
* | | | | Merge pull request #15273 from DNNX/formatter-refactoring-4 | Rafael Mendonça França | 2014-05-23 | 1 | -5/+0 | |
|\ \ \ \ | | | | | | | | | | | Remove AD::Journey::Formatter#verify_required_parts! | |||||
| * | | | | Remove AD::Journey::Formatter#verify_required_parts! | Viktar Basharymau | 2014-05-23 | 1 | -5/+0 | |
| | |/ / | |/| | | | | | | | | | | | | | | Nobody uses this private method, maybe it is a leftover from some old refactoring. Let's delete it. | |||||
* | | | | decouple the router object from the request class | Aaron Patterson | 2014-05-23 | 2 | -7/+4 | |
| | | | | ||||||
* | | | | pass the correct custom request to the recognize method | Aaron Patterson | 2014-05-23 | 2 | -4/+2 | |
| | | | | ||||||
* | | | | switch to the `serve` method so we can remove the request class (eventually) | Aaron Patterson | 2014-05-23 | 1 | -6/+0 | |
| | | | | ||||||
* | | | | pull request allocation up one frame | Aaron Patterson | 2014-05-23 | 1 | -1/+3 | |
| | | | | ||||||
* | | | | extract request allocation from the main app serving routine | Aaron Patterson | 2014-05-23 | 1 | -2/+4 | |
| | | | | ||||||
* | | | | use the accessors on the request object rather than touching env | Aaron Patterson | 2014-05-23 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | find_routes only use the request, so stop passing env | Aaron Patterson | 2014-05-23 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | remove NullRequest and just always pass a request class | Aaron Patterson | 2014-05-23 | 1 | -26/+1 | |
| | | | | ||||||
* | | | | use the request object since we have it | Aaron Patterson | 2014-05-23 | 1 | -8/+9 | |
|/ / / | | | | | | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object. | |||||
* | | | stop using PARAMETERS_KEY, and use the accessor on the request object | Aaron Patterson | 2014-05-22 | 2 | -7/+6 | |
| | | | | | | | | | | | | this decouples our code from the env hash a bit. | |||||
* | | | pass the instantiated request to the find_routes method | Aaron Patterson | 2014-05-22 | 1 | -5/+7 | |
| | | | ||||||
* | | | just return path parameters | Aaron Patterson | 2014-05-22 | 1 | -2/+1 | |
| | | | ||||||
* | | | use symbol keys for path_parameters | Aaron Patterson | 2014-05-22 | 3 | -5/+5 | |
| | | | ||||||
* | | | Merge pull request #15254 from DNNX/formatter-refactoring-3 | Rafael Mendonça França | 2014-05-22 | 1 | -4/+4 | |
|\ \ \ | | | | | | | | | Rename `stack` to `queue` | |||||
| * | | | Rename `stack` to `queue` | Viktar Basharymau | 2014-05-22 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because it is used as a queue (FIFO), not as a stack (LIFO). * http://en.wikipedia.org/wiki/Stack_(abstract_data_type) * http://en.wikipedia.org/wiki/Queue_(data_structure) | |||||
* | | | | Merge pull request #15252 from DNNX/formatter-refactoring-2 | Rafael Mendonça França | 2014-05-22 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Remove unnecessary `Hash#to_a` call | |||||
| * | | | | Remove unnecessary `Hash#to_a` call | Viktar Basharymau | 2014-05-22 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inspired by https://github.com/rails/rails/commit/931ee4186b877856b212b0085cd7bd7f6a4aea67 ```ruby def stat(num) start = GC.stat(:total_allocated_object) num.times { yield } total_obj_count = GC.stat(:total_allocated_object) - start puts "#{total_obj_count / num} allocations per call" end h = { 'x' => 'y' } stat(100) { h. each { |pair| pair } } stat(100) { h.to_a.each { |pair| pair } } __END__ 1 allocations per call 2 allocations per call ``` | |||||
* | | | | Merge pull request #15247 from DNNX/activesupport-formatter-refactoring | Rafael Mendonça França | 2014-05-22 | 1 | -1/+1 | |
|\ \ \ \ | | | | | | | | | | | Use `break` instead of `next` in AD::Journey::Formatter#match_route | |||||
| * | | | | Use `break` instead of `next` in AD::Journey::Formatter#match_route | Viktar Basharymau | 2014-05-22 | 1 | -1/+1 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | The array is sorted in descending order, so there is no point in iterating further if we met a negative item - all the rest will be negative too. | |||||
* / / / | Fix the hash key being delete from env | Rafael Mendonça França | 2014-05-22 | 1 | -1/+1 | |
|/ / / | | | | | | | | | | It was changed by mistake at c5d64b2b86aa42f57881091491ee289b3c489c7e. | |||||
* | | | Form full URI as string to be parsed in Rack::Test. | Guo Xiang Tan | 2014-05-21 | 1 | -7/+5 | |
| | | | | | | | | | | | | There are performance gains to be made by avoiding URI setter methods. | |||||
* | | | drop hash allocations during match | Aaron Patterson | 2014-05-21 | 1 | -2/+2 | |
| | | | ||||||
* | | | fewer object allocations and method calls during route match | Aaron Patterson | 2014-05-21 | 1 | -5/+5 | |
| | | |