Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #8787 from tank-bohr/master | Rafael Mendonça França | 2013-01-06 | 1 | -2/+2 |
|\ | | | | | masgn and response variable | ||||
| * | return multiple assingment and response variable | tank-bohr | 2013-01-07 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #8785 from goshakkk/refactor-debug-exceptions | Rafael Mendonça França | 2013-01-06 | 1 | -2/+1 |
|\ \ | |/ |/| | Refactor DebugExceptions | ||||
| * | refactor DebugExceptions by combining two conditionals into one | Gosha Arinich | 2013-01-07 | 1 | -2/+1 |
| | | |||||
* | | Reduce number of Strings a bit | Akira Matsuda | 2013-01-07 | 1 | -3/+3 |
| | | |||||
* | | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 2 | -2/+2 |
|/ | |||||
* | Merge pull request #8783 from goshakkk/refactor-journey-routes | Rafael Mendonça França | 2013-01-06 | 1 | -12/+11 |
|\ | | | | | Refactor Journey::Routes | ||||
| * | refactor Journey::Routes | Gosha Arinich | 2013-01-07 | 1 | -12/+11 |
| | | | | | | | | | | * prefer do-end for multiline blocks * prefer or-equals over returns with checks | ||||
* | | fix for rbx | tank-bohr | 2013-01-07 | 1 | -2/+2 |
|/ | | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable | ||||
* | Needless requires | Akira Matsuda | 2013-01-06 | 1 | -4/+0 |
| | |||||
* | Missing requires | Akira Matsuda | 2013-01-06 | 1 | -0/+1 |
| | |||||
* | Rename route_wrapper partial layout to table | Carlos Antonio da Silva | 2013-01-06 | 2 | -1/+1 |
| | | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler. | ||||
* | Move table routes formatter class to the inspector and rename it | Carlos Antonio da Silva | 2013-01-06 | 3 | -19/+19 |
| | | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page. | ||||
* | Refactor to not call path.ast twice | Carlos Antonio da Silva | 2013-01-06 | 1 | -2/+3 |
| | |||||
* | refactor Route#ast to use or-equals and block, instead of return with a cond | Gosha Arinich | 2013-01-06 | 1 | -5/+4 |
| | |||||
* | Remove unnecessary begin..rescue..end, use only rescue | Akira Matsuda | 2013-01-06 | 1 | -5/+3 |
| | |||||
* | Merge pull request #8766 from jcoglan/session_token_docs | Andrew White | 2013-01-05 | 1 | -7/+4 |
|\ | | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip] | ||||
| * | Remove suggestion that Procs can be used as session secrets. | James Coglan | 2013-01-05 | 1 | -7/+4 |
| | | |||||
* | | Remove warning, remove not used variable, and make methods private | Carlos Antonio da Silva | 2013-01-05 | 1 | -3/+5 |
|/ | | | | Warning: "shadowing outer local variable - routes". | ||||
* | Close container div tag in routing error page | Carlos Antonio da Silva | 2013-01-05 | 1 | -9/+11 |
| | |||||
* | Move style to head to make routes page valid html5 | Carlos Antonio da Silva | 2013-01-05 | 2 | -4/+6 |
| | |||||
* | display mountable engine routes on RoutingError. | Yves Senn | 2013-01-05 | 2 | -8/+23 |
| | |||||
* | split formatting concerns from RoutesInspector | Yves Senn | 2013-01-05 | 1 | -20/+42 |
| | |||||
* | Allow use of durations for ActionDispatch::SSL configuration | Andrew White | 2013-01-04 | 1 | -1/+1 |
| | |||||
* | Remove unnecessary `ERB::Util::h` | Ryunosuke SATO | 2013-01-05 | 7 | -17/+17 |
| | | | | It is automatically applied when strings is unsafe for html. | ||||
* | Suppress warning about IO#lines in Ruby 2.0 | Ryunosuke SATO | 2013-01-04 | 1 | -1/+1 |
| | | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead | ||||
* | Merge pull request #8723 from goshakkk/refactor-error-page | Guillermo Iguaran | 2013-01-03 | 3 | -5/+27 |
|\ | | | | | Move error page js into script tag | ||||
| * | move error page js into script tag | Gosha Arinich | 2013-01-04 | 3 | -5/+27 |
| | | |||||
* | | Add documentation to ActionDispatch::Http::UploadedFile#headers | Rafael Mendonça França | 2013-01-03 | 1 | -0/+1 |
| | | | | | | | | [ci skip] | ||||
* | | Remove a useless TODO comment | Robin Dupret | 2013-01-03 | 1 | -1/+0 |
|/ | |||||
* | Merge pull request #8713 from goshakkk/better-error-page | Guillermo Iguaran | 2013-01-03 | 2 | -12/+10 |
|\ | | | | | Fix env toggling, improve error page styling | ||||
| * | fix env toggling, improve error page styling | Gosha Arinich | 2013-01-03 | 2 | -12/+10 |
| | | |||||
* | | Merge pull request #8715 from goshakkk/refactor-mapper | Carlos Antonio da Silva | 2013-01-03 | 1 | -9/+4 |
|\ \ | | | | | | | Refactor Routing::Mapper#matches? | ||||
| * | | refactor Routing::Mapper | Gosha Arinich | 2013-01-03 | 1 | -9/+4 |
| |/ | |||||
* | | Explain the possible precautions | Andre Arko | 2013-01-02 | 1 | -3/+4 |
| | | |||||
* | | Restore original remote_ip algorithm. | Andre Arko | 2013-01-02 | 1 | -53/+112 |
|/ | | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979 | ||||
* | Merge pull request #8697 from goshakkk/undup | Rafael Mendonça França | 2013-01-02 | 1 | -5/+3 |
|\ | | | | | Remove another unnecessary dup | ||||
| * | remove another unnecessary dup | Gosha Arinich | 2013-01-02 | 1 | -5/+3 |
| | | |||||
* | | Merge pull request #8701 from senny/8700_double_slash_with_trailing_slash | Rafael Mendonça França | 2013-01-02 | 1 | -1/+5 |
|\ \ | | | | | | | do not append a second slash when using `trailing_slash: true` | ||||
| * | | do not append a second slash when using | Yves Senn | 2013-01-02 | 1 | -1/+5 |
| |/ | |||||
* | | Fixing closing </p> | Guillermo Iguaran | 2013-01-02 | 1 | -1/+1 |
| | | |||||
* | | Fix a number of validation/style errors: | Sam Ruby | 2013-01-02 | 2 | -8/+7 |
|/ | | | | | | | | | | * <pre> is not allowed to be nested inside of <p> elements in HTML * Indentation of </p> doesn't match corresponding <p> * <p> element not explicitly closed * One more </div> than <div> In each case, the template was fixed to match how a HTML5 parser would "see" the resulting page. | ||||
* | Merge pull request #8694 from goshakkk/undup | Carlos Antonio da Silva | 2013-01-02 | 1 | -2/+1 |
|\ | | | | | Remove unnecessary #dup | ||||
| * | remove unnecessary #dup | Gosha Arinich | 2013-01-02 | 1 | -2/+1 |
| | | |||||
* | | Merge pull request #8688 from goshakkk/error-page-toggle | Guillermo Iguaran | 2013-01-02 | 1 | -3/+3 |
|\ \ | |/ |/| | Allow toggling dumps on error page | ||||
| * | allow toggling dumps instead of just showing | Gosha Arinich | 2013-01-02 | 1 | -3/+3 |
| | | |||||
* | | Cleanup some unnecessary CSS on the new error page and reformat some lines. | Lucas Mazza | 2013-01-02 | 1 | -12/+13 |
| | | |||||
* | | add source line padding | Gosha Arinich | 2013-01-02 | 1 | -0/+4 |
|/ | |||||
* | remove meaningless AS::FrozenObjectError | Akira Matsuda | 2013-01-02 | 1 | -1/+0 |
| | |||||
* | Fix indent in UnknownAction template | Guillermo Iguaran | 2013-01-01 | 1 | -1/+1 |
| |