| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Only build the missing_keys array once we have detected that there
actually are missing keys by moving the check to be part of the block
that performs the path substitution.
|
| |
|
|
|
|
|
|
|
| |
When optimized path helpers were re-introduced in d7014bc the test added
in a328f2f broke but no-one noticed because it wasn't being run by the
test suite.
Fix the test by checking for nil values or empty strings after the args
have been parameterized.
|
| |
|
|
|
|
|
|
|
|
| |
When generating an unnamed url (i.e. using `url_for` with an options
hash) we should skip anything other than standard Rails routes otherwise
it will match the first mounted application or redirect and generate a
url with query parameters rather than raising an error if the options
hash doesn't match any defined routes.
Fixes #8018
|
| |\
| |
| | |
Use content_length method instead of ENV['CONTENT_LENGTH'].to_i
|
| | | |
|
| |/
|
|
|
|
|
|
| |
In order to get raw_post to be not empty after
ParamsParser#parse_formatted_parameters,
added rewinding of body stream input on parsing json params.
Closes #11345
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Set ActionDispatch.test_app instead.
|
| | |
|
| |
|
|
|
|
|
|
| |
request thread to return up the stack before the instance variable is
assigned. Synchronize so that the ivar is assigned before the other
thread can activate.
fixes #10984
|
| |\
| |
| |
| | |
Fix undefined method `ref' for nil:NilClass for bad accept headers
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Merge `:action` from routing scope and assign endpoint if both `:controller`
and `:action` are present. The endpoint assignment only occurs if there is
no `:to` present in the options hash so should only affect routes using the
shorthand syntax (i.e. endpoint is inferred from the the path).
Fixes #9856
|
| |\ \
| | |
| | | |
Flag cookies as secure with ignore case in ActionDispatch::SSL
|
| | | | |
|
| |/ / |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when app was mounted as following:
class Foo
def call(env)
[200, {}, [env['PATH_INFO']]]
end
end
RackMountRailsBug::Application.routes.draw do
mount RackTest.new => "/foo"
end
trailing slash was removed from PATH_INFO. For example requesting
GET /foo/bar/
on routes defined above would result in a response containing "/foo/bar"
instead of "/foo/bar/".
This commit fixes the issue.
(closes #3215)
|
| |
|
|
|
|
| |
We are setting this header to chrome=1 for Chrome Frame and this will be
retired soon. Check http://blog.chromium.org/2013/06/retiring-chrome-frame.html for
details
|
| | |
|
| |\
| |
| | |
Refactor ActionDispatch::Http::Parameters#normalize_encode_params
|
| | | |
|
| |\ \
| | |
| | | |
DRY-up ActionDispatch::Routing autoloads
|
| | |/ |
|
| | |
| |
| |
| | |
were deprecated.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After some discussion on Twitter with @skud, the documentation on ActionDispatch::Response is
a bit sparse. This class is useful when you're writing tests, as often you want to assert various
things about the response that's coming back. Better docs would make this easier for people new
to testing in Rails.
I only added some descriptions for various properties that were defined, and mostly just a sentence
or two. Most of these things are familliar if you're working with HTTP, but some words is better
than no words at all.
Hopefully further commits will fix up things that aren't just documentation.
|
| |\ \
| | |
| | | |
Extract ActionDispatch::Request#deep_munge
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
ActionDispatch::Request#deep_munge was introduced as a private method,
but was turned into a public one for the use of
ActionDispatch::ParamsParser.
I have extracted it into ActionDispatch::Request::Utils, so it does not
get mixed up with the Request public methods.
|
| |/ |
|
| |
|
|
|
| |
minitest/autorun required minitest/spec and we are avoiding to require
it.
|
| |\
| |
| | |
Eliminate minitest warnings
|
| | |
| |
| |
| | |
https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6#L15R8
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When named route that is nested is used in 3.2.13
Example `routes.rb`:
```
resources :nested do
resources :builder, :controller => 'nested/builder'
end
```
In 3.2.12 and 3.2.12 this named route would work:
```
nested_builder_path(:last_step, :nested_id => "foo")
```
Generating a url that looks like `/nested/foo/builder/last_step`. This PR fixes the regression when building urls via the optimized helper. Any explicit keys set in the options are removed from the list of implicitly mapped keys.
Not sure if this is exactly how the original version worked, but this fixes this use case regression.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ad46884af567d6f8d6d8d777f372c39e81a560ba.
Conflicts:
actionpack/CHANGELOG.md
actionpack/lib/action_dispatch/testing/integration.rb
actionpack/test/controller/integration_test.rb
Reason: It will conflict with a lot of test cases. Better to call
`process` directly since this is a very uncommon HTTP method.
Fixes #10638.
|
| |
|
|
| |
c43ca06ca091fc09e2c86bb051ac92b648f12b64
|
| |
|
|
|
|
|
| |
The nested `if` was replaced by using `presence` which takes account for
the given hash when it is `nil` or when it is empty. The `else` was
removed because what it was doing was to assign to `env[KEY]` the
value it already had.
|
| |\
| |
| | |
remove variable and fix warning
|
| | | |
|
| |/ |
|
| |
|
|
| |
for their status, by default, not the message from the underlying exception
|
| |\
| |
| | |
Add styling to h1 for default rescue layout
|
| | | |
|
| |/ |
|
| |\
| |
| | |
failure to parse params should trigger a 400 Bad Request
|
| | | |
|
| | | |
|
| | | |
|
| |\ \
| | |
| | | |
extract arrays to constants in Mapper
|
