aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'constraints'Aaron Patterson2014-05-279-70/+71
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * constraints: rm reset_parameters because we automatically do it from 9ca4839a move path_parameter encoding check to the request object dispatcher doesn't need `call` anymore call `serve` with the request on dispatchers constraints class does not need the request class anymore give all endpoints a superclass skip the build business if the stack is empty stop hardcoding path_parameters and get it from the request we do not need to cache rack_app a redirect is not a dispatcher by definition, so eliminate test push is_a check up to where the Constraints object is allocated pass the request object to the application pass a request to `matches?` so we can avoid creating excess requests nothing is passed to `rack_app` anymore, so rm the params one fewer is_a check Constraints#app should never return another Constraints object, so switch to if statement eliminate dispatcher is_a checks push is_a?(Dispatcher) check in to one place Always construct route objects with Constraint objects Conflicts: actionpack/lib/action_controller/metal.rb
| * rm reset_parameters because we automatically do it from 9ca4839aAaron Patterson2014-05-272-6/+0
| |
| * move path_parameter encoding check to the request objectAaron Patterson2014-05-273-18/+13
| |
| * dispatcher doesn't need `call` anymoreAaron Patterson2014-05-271-4/+0
| |
| * call `serve` with the request on dispatchersAaron Patterson2014-05-271-9/+10
| |
| * constraints class does not need the request class anymoreAaron Patterson2014-05-271-4/+4
| |
| * give all endpoints a superclassAaron Patterson2014-05-274-22/+40
| |
| * we do not need to cache rack_appAaron Patterson2014-05-261-9/+3
| |
| * a redirect is not a dispatcher by definition, so eliminate testAaron Patterson2014-05-261-1/+1
| |
| * push is_a check up to where the Constraints object is allocatedAaron Patterson2014-05-262-6/+11
| |
| * pass the request object to the applicationAaron Patterson2014-05-252-4/+3
| |
| * pass a request to `matches?` so we can avoid creating excess requestsAaron Patterson2014-05-252-7/+6
| |
| * nothing is passed to `rack_app` anymore, so rm the paramsAaron Patterson2014-05-251-1/+1
| |
| * one fewer is_a checkAaron Patterson2014-05-251-4/+3
| |
| * Constraints#app should never return another Constraints object, so switch to ↵Aaron Patterson2014-05-251-1/+1
| | | | | | | | if statement
| * eliminate dispatcher is_a checksAaron Patterson2014-05-241-8/+14
| |
| * push is_a?(Dispatcher) check in to one placeAaron Patterson2014-05-243-14/+11
| |
| * Always construct route objects with Constraint objectsAaron Patterson2014-05-243-9/+7
| |
* | Merge pull request #15321 from ↵Santiago Pastorino2014-05-271-1/+4
|\ \ | | | | | | | | | | | | tgxworld/only_find_routes_as_heads_for_head_request Call get_routes_as_head only on HEAD requests.
| * | Call get_routes_as_head only on HEAD requests.Guo Xiang Tan2014-05-251-1/+4
| | |
* | | Escape user input before showing in the page.Rafael Mendonça França2014-05-261-2/+2
| | | | | | | | | | | | | | | | | | This is not a security issue since this page is not present in production and user have to type something in the field but is better to escape the input.
* | | Remove unnecessary flatten! method call.Guo Xiang Tan2014-05-251-3/+1
|/ /
* | Merge pull request #15305 from tgxworld/remove_unnecessary_requireGuillermo Iguaran2014-05-241-1/+0
|\ \ | |/ |/| Remove unnecessary require of Minitest.
| * Remove unnecessary require of Minitest.Guo Xiang Tan2014-05-241-1/+0
| | | | | | | | Minitest has already been required when calling Minitest.autorun.
* | unwrap the constraints object on initialization, eliminate loopsAaron Patterson2014-05-244-3/+12
| | | | | | | | | | | | | | Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea.
* | Merge pull request #14986 from dlangevin/trailing-slash-url-generationRafael Mendonça França2014-05-241-7/+13
|\ \ | | | | | | | | | | | | | | | | | | Fixes URL generation with trailing_slash: true Conflicts: actionpack/lib/action_dispatch/http/url.rb
| * | Fixes URL generation with trailing_slash: trueDan Langevin2014-05-221-9/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | URL generation with trailing_slash: true was adding a trailing slash after .:format Routes.draw do resources :bars end bars_url(trailing_slash: true, format: 'json') # => /bars.json/ This commit removes that extra trailing slash
* | | Merge pull request #15291 from francocatena/router-visualizer-fixRafael Mendonça França2014-05-231-2/+2
|\ \ \ | | | | | | | | Fix router visualizer CSS and JS resources
| * | | Fix router visualizer CSS and JS resourcesFranco Catena2014-05-231-2/+2
| | | |
* | | | Constraints contructor should always return a Constraints objectAaron Patterson2014-05-231-9/+5
| | | | | | | | | | | | | | | | I know, it's crazy.
* | | | default value is never used, so make it requiredAaron Patterson2014-05-231-1/+1
| | | |
* | | | push options decomposition up so we can extractAaron Patterson2014-05-231-20/+13
|/ / /
* | | glob_param is never used, so rmAaron Patterson2014-05-232-9/+3
| | | | | | | | | | | | | | | | | | this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff).
* | | there is no formatter on the router object, so rmAaron Patterson2014-05-231-1/+0
| | |
* | | Merge pull request #15273 from DNNX/formatter-refactoring-4Rafael Mendonça França2014-05-231-5/+0
|\ \ \ | | | | | | | | Remove AD::Journey::Formatter#verify_required_parts!
| * | | Remove AD::Journey::Formatter#verify_required_parts!Viktar Basharymau2014-05-231-5/+0
| | |/ | |/| | | | | | | | | | Nobody uses this private method, maybe it is a leftover from some old refactoring. Let's delete it.
* | | decouple the router object from the request classAaron Patterson2014-05-232-7/+4
| | |
* | | pass the correct custom request to the recognize methodAaron Patterson2014-05-232-4/+2
| | |
* | | switch to the `serve` method so we can remove the request class (eventually)Aaron Patterson2014-05-231-6/+0
| | |
* | | pull request allocation up one frameAaron Patterson2014-05-231-1/+3
| | |
* | | extract request allocation from the main app serving routineAaron Patterson2014-05-231-2/+4
| | |
* | | use the accessors on the request object rather than touching envAaron Patterson2014-05-231-2/+2
| | |
* | | find_routes only use the request, so stop passing envAaron Patterson2014-05-231-3/+3
| | |
* | | remove NullRequest and just always pass a request classAaron Patterson2014-05-231-26/+1
| | |
* | | use the request object since we have itAaron Patterson2014-05-231-8/+9
|/ / | | | | | | | | stop hardcoding hash keys and use the accessors provided on the request object.
* | stop using PARAMETERS_KEY, and use the accessor on the request objectAaron Patterson2014-05-222-7/+6
| | | | | | | | this decouples our code from the env hash a bit.
* | pass the instantiated request to the find_routes methodAaron Patterson2014-05-221-5/+7
| |
* | just return path parametersAaron Patterson2014-05-221-2/+1
| |
* | use symbol keys for path_parametersAaron Patterson2014-05-223-5/+5
| |
* | Merge pull request #15254 from DNNX/formatter-refactoring-3Rafael Mendonça França2014-05-221-4/+4
|\ \ | | | | | | Rename `stack` to `queue`
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-18 23:24:57 +0000