Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ETag: use body instead of @body since the method will always return a string | Jeremy Kemper | 2010-06-28 | 1 | -2/+2 |
| | |||||
* | Tidy up valid conditions in router a bit. | José Valim | 2010-06-28 | 1 | -2/+4 |
| | |||||
* | Add :controller and :action to the list of valid conditions | Andrew White | 2010-06-28 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge :constraints from scope into resource options [#2694 state:resolved] | Andrew White | 2010-06-28 | 1 | -4/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove invalid conditions from route [#4989 state:resolved] | Andrew White | 2010-06-28 | 2 | -4/+14 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deprecate the old router DSL. Since it is still used intensively across ↵ | José Valim | 2010-06-28 | 1 | -0/+2 |
| | | | | ActionPack test suite, patches that translates Rails internal tests to the new router DSL are welcome (note though that a few tests shouldn't be translated since they are testing exactly the old mapper API, like the ones in actionpack/test/controller/resource_test.rb and actionpack/test/controller/routing_test.rb) | ||||
* | Fix several known web encoding issues: | wycats | 2010-06-27 | 1 | -1/+30 |
| | | | | | | | | | | | | | | | | | | | | | | | * Specify accept-charset on all forms. All recent browsers, as well as IE5+, will use the encoding specified for form parameters * Unfortunately, IE5+ will not look at accept-charset unless at least one character in the form's values is not in the page's charset. Since the user can override the default charset (which Rails sets to UTF-8), we provide a hidden input containing a unicode character, forcing IE to look at the accept-charset. * Now that the vast majority of web input is UTF-8, we set the inbound parameters to UTF-8. This will eliminate many cases of incompatible encodings between ASCII-8BIT and UTF-8. * You can safely ignore params[:_snowman_] TODO: * Validate inbound text to confirm it is UTF-8 * Combine the whole_form implementations in form_helper_test and form_tag_helper_test | ||||
* | Vendor unreleased rack-mount 0.6.6.pre dependency | Jeremy Kemper | 2010-06-27 | 35 | -1/+4014 |
| | |||||
* | Fixed that an ArgumentError is thrown when request.session_options[:id] is ↵ | Michael Lovitt | 2010-06-27 | 2 | -36/+38 |
| | | | | | | | | read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types. [#4938] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Normalize recall params when the route is not a standard route otherwise ↵ | Andrew White | 2010-06-27 | 1 | -3/+26 |
| | | | | | | :controller and :action may appear in the generated url [#4326 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Support optional static segements as well [#4832 state:resolved] | Andrew White | 2010-06-26 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed normalize_path in Routing::Mapper to handle optional prefix segments ↵ | Paul Barry | 2010-06-26 | 1 | -1/+1 |
| | | | | | | with static and dynamic parts Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Don't force pluralization of controller name when defining a resource [#4980 ↵ | Andrew White | 2010-06-26 | 1 | -1/+9 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | URL fragments should not have safe characters escaped. Ref: Appendix A, ↵ | Andrew White | 2010-06-25 | 1 | -1/+1 |
| | | | | | | | | http://tools.ietf.org/rfc/rfc3986.txt [#4762 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Do not mark the session as loaded if an error happened while doing it. | José Valim | 2010-06-25 | 1 | -2/+1 |
| | |||||
* | Calling exists? in the session store, without checking for stale sessions, ↵ | José Valim | 2010-06-25 | 2 | -10/+10 |
| | | | | was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements. | ||||
* | Make sure that Rails doesn't resent session_id cookie over and over again if ↵ | Prem Sichanugrist | 2010-06-25 | 1 | -1/+3 |
| | | | | | | | | it's already there [#2485 state:resolved] This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Just reading flash messages should not create a session if one does not ↵ | José Valim | 2010-06-25 | 2 | -2/+12 |
| | | | | exist yet. | ||||
* | Avoid deserializing cookies too early, which causes session objects to not ↵ | José Valim | 2010-06-24 | 2 | -18/+22 |
| | | | | be available yet. Unfortunately, could not reproduce this in a test case. | ||||
* | Fix namespaced redirects [#4389 state:resolved] | Andrew White | 2010-06-24 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Sessions should not be created until written to and session data should be ↵ | Michael Lovitt | 2010-06-23 | 4 | -30/+116 |
| | | | | | | | | destroyed on reset. [#4938] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Add the :path option to match routes when given as symbols. This is ↵ | Carlos Antonio da Silva | 2010-06-23 | 1 | -9/+8 |
| | | | | | | | | | | specially useful in http helpers for generating routes in scenarios like: resources :users, :path => 'usuarios' do get :search, :on => :collection, :path => 'pesquisar' end Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Provive resources_path_names helpers in the router. | José Valim | 2010-06-23 | 1 | -0/+4 |
| | |||||
* | Stop filling the blocks scope array with nil. | José Valim | 2010-06-22 | 1 | -1/+3 |
| | |||||
* | Allow namespace accept options in routes [#4936 state:resolved] | Carlos Antonio da Silva | 2010-06-22 | 1 | -3/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Deprecate :name_prefix in the new router DSL. | José Valim | 2010-06-22 | 1 | -20/+22 |
| | |||||
* | Remove unused variable on assert_recognizes [#4912 state:resolved] | Paco Guzman | 2010-06-22 | 1 | -1/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | removed 'unless const_defined?' code smell | Josh Kalderimis | 2010-06-21 | 1 | -23/+19 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 5 | -165/+293 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | Use the new ActiveSupport::FileUpdateChecker instead of RoutesReloader. | José Valim | 2010-06-20 | 1 | -1/+1 |
| | | |||||
| * | Use Rack::Utils.bytesize when calculating content-length of exception pages. ↵ | Tarsoly András | 2010-06-20 | 1 | -1/+1 |
| | | | | | | | | | | | | [#4727 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | remove executable permission from files that don't need it. [#4802 ↵ | rohit | 2010-06-20 | 1 | -0/+0 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Don't use module to work out shallow name prefix and path as it may not ↵ | Andrew White | 2010-06-20 | 1 | -9/+17 |
| | | | | | | | | | | | | accurately reflect the actual namespace [#4899 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Accept an object for :constraints option [#4904 state:resolved] | Andrew White | 2010-06-20 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | Merge branch 'master' of github.com:rails/rails | José Valim | 2010-06-20 | 1 | -7/+36 |
| |\ | |||||
| | * | Custom resource routes should be scoped | Andrew White | 2010-06-19 | 1 | -7/+36 |
| | | | | | | | | | | | | | | | | | | [#3765] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | | Clear DescendantsTracker on each request. | José Valim | 2010-06-19 | 1 | -4/+4 |
| |/ | |||||
| * | fix for :shallow in router not generating helpers for create, update, and ↵ | Josh Kalderimis | 2010-06-18 | 1 | -4/+3 |
| | | | | | | | | | | | | | | | | destroy actions when :only or :except are used [#4900 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
| * | Add shallow routing option to new router [#3765 status:committed] | Andrew White | 2010-06-17 | 1 | -156/+248 |
| | | | | | | | | Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | | Take out documentation from DeprecatedMapper to discourage its usage. | Rizwan Reza | 2010-06-21 | 1 | -384/+0 |
| | | |||||
* | | Use h1 for titles. | Rizwan Reza | 2010-06-21 | 1 | -1/+1 |
| | | |||||
* | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 6 | -8/+8 |
|\ \ | |/ |/| | |||||
| * | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 6 | -8/+8 |
| | | |||||
* | | Refactored duplication into a separate method. Dropped class variable. | Rizwan Reza | 2010-06-11 | 1 | -15/+17 |
| | | |||||
* | | Adding missing docs to delete cookies with :all which were added that way. | Rizwan Reza | 2010-06-11 | 1 | -1/+2 |
| | | |||||
* | | Took out the domain option logic to cookies.rb. | Rizwan Reza | 2010-06-11 | 3 | -22/+32 |
| | | |||||
* | | Moved Domain regexp to a constant and added comments. | Rizwan Reza | 2010-06-11 | 1 | -1/+8 |
| | | |||||
* | | The previous commit didn't work with complex domains, which is now fixed. | Rizwan Reza | 2010-06-11 | 1 | -4/+4 |
| | | |||||
* | | Add support for multi-subdomain session by setting cookie host in session ↵ | Rizwan Reza | 2010-06-11 | 2 | -1/+14 |
|/ | | | | | | cookie so you can share session between www.example.com, example.com and user.example.com. [#4818 state:resolved] This reverts commit 330a89072a493aafef1e07c3558964477f85adf0. | ||||
* | Revert "Add support for multi-subdomain session by setting cookie host in ↵ | José Valim | 2010-06-10 | 2 | -14/+1 |
| | | | | | | | | session cookie so you can share session between www.example.com, example.com and user.example.com. [#4818 state:resolved]" It does not work for domains like co.uk and com.br. This reverts commit c4d6245e875bbb276c122a5a401422d341dac4df. |