Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 3 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | |||||
* | | | | | renames response_from_page_or_rjs -> response_from_page, and extracts the ↵ | Xavier Noria | 2011-04-13 | 1 | -58/+5 | |
| | | | | | | | | | | | | | | | | | | | | RJS in it | |||||
* | | | | | removes assert_select_rjs | Xavier Noria | 2011-04-13 | 1 | -139/+1 | |
| | | | | | ||||||
* | | | | | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 4 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | suggestion! | |||||
* | | | | | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 4 | -5/+10 | |
| | | | | | | | | | | | | | | | | | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | |||||
* | | | | | Merge branch 'master' of github.com:rails/rails | Aaron Patterson | 2011-04-07 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 'master' of github.com:rails/rails: Cache flash now Revert "Use freeze instead of close!" Revert "Eagerly load Signed and Permanent cookies" cookies here Eagerly load Signed and Permanent cookies Use freeze instead of close! | |||||
| * | | | | | Cache flash now | Santiago Pastorino | 2011-04-07 | 1 | -1/+1 | |
| | | | | | | ||||||
| * | | | | | Revert "Use freeze instead of close!" | Santiago Pastorino | 2011-04-07 | 2 | -5/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 29592a7f09dda2e7e1e0a915d9230fe6a9b5c0af. | |||||
| * | | | | | Revert "Eagerly load Signed and Permanent cookies" | Santiago Pastorino | 2011-04-07 | 1 | -17/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit dffeda377021ba8691381195f5a2889f8e040b93. | |||||
| * | | | | | Eagerly load Signed and Permanent cookies | Santiago Pastorino | 2011-04-07 | 1 | -10/+17 | |
| | | | | | | ||||||
| * | | | | | Use freeze instead of close! | Santiago Pastorino | 2011-04-06 | 2 | -14/+5 | |
| | | | | | | ||||||
* | | | | | | getting the flash hash under test | Aaron Patterson | 2011-04-06 | 1 | -0/+4 | |
| | | | | | | ||||||
* | | | | | | favor composition over inheritance, have FlashHash delegate to a Hash | Aaron Patterson | 2011-04-06 | 1 | -7/+40 | |
|/ / / / / | ||||||
* | | | | | CookieJar should prefer composition over inheritance | Aaron Patterson | 2011-04-06 | 1 | -6/+10 | |
| | | | | | ||||||
* | | | | | Make process reuse the env var passed as argument | Santiago Pastorino | 2011-04-06 | 1 | -5/+4 | |
| | | | | | ||||||
* | | | | | raise if someone tries to modify the cookies when it was already streamed ↵ | Santiago Pastorino | 2011-04-06 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | back to the client or converted to HTTP headers | |||||
* | | | | | Add ClosedError message to the initializer | Santiago Pastorino | 2011-04-06 | 2 | -5/+9 | |
| | | | | | ||||||
* | | | | | raise if someone tries to modify the flash when it was already streamed back ↵ | Santiago Pastorino | 2011-04-05 | 1 | -1/+19 | |
| | | | | | | | | | | | | | | | | | | | | to the client or converted to HTTP headers | |||||
* | | | | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-04-03 | 1 | -8/+8 | |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | ||||||
| * | | | | Fix grammar, formatting, and cross references | John Firebaugh | 2011-03-28 | 1 | -8/+8 | |
| | |/ / | |/| | | ||||||
* | | | | use assert_equal so we get normal error messages along with our custom ↵ | Aaron Patterson | 2011-03-30 | 1 | -3/+3 | |
| |_|/ |/| | | | | | | | | failure message | |||||
* | | | Update the wildcard route to be non-greedy by default, therefore be able to ↵ | Prem Sichanugrist | 2011-03-29 | 1 | -1/+7 | |
|/ / | | | | | | | | | | | | | | | match the (.:format) segment [#6605 state:resolved] After some discussion with Andrew White, it seems like this is a better approach for handling a wildcard route. However, user can still bring back the old behavior by supplying `:format => false` to the route. Signed-off-by: Andrew White <andyw@pixeltrix.co.uk> | |||||
* / | correction to the outputted controller name in the diagnostics error ↵ | Josh Kalderimis | 2011-03-24 | 1 | -1/+1 | |
|/ | | | | | | template, test included Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-23 | 1 | -0/+7 | |
|\ | ||||||
| * | doc :anchor option for #match in routes | Gabriel Horner | 2011-03-15 | 1 | -0/+7 | |
| | | ||||||
* | | Do not show optional (.:format) block for wildcard route [#6605 state:resolved] | Prem Sichanugrist | 2011-03-22 | 1 | -1/+1 | |
| | | | | | | | | This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default | |||||
* | | use a list to represent the supported verbs for a route object | Aaron Patterson | 2011-03-14 | 2 | -11/+13 | |
| | | ||||||
* | | stop splatting arguments so that we can understand wtf is going on | Aaron Patterson | 2011-03-14 | 1 | -2/+3 | |
| | | ||||||
* | | RegexpWithNamedGroups is only used for path_info, so only apply to path info | Aaron Patterson | 2011-03-14 | 1 | -1/+2 | |
|/ | ||||||
* | Just define methods directly on the class rather than use the module | Aaron Patterson | 2011-03-11 | 1 | -14/+5 | |
| | | | | | | indirection. clever-- | |||||
* | do not automatically add format to routes that end in a slash | Aaron Patterson | 2011-03-11 | 1 | -1/+1 | |
| | ||||||
* | Filter sensitive query string parameters in the log [#6244 state:committed] | Prem Sichanugrist & Xavier Noria | 2011-03-11 | 1 | -4/+17 | |
| | | | | | | This provides more safety to applications that put secret information in the query string, such as API keys or SSO tokens. Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | Filter params that return nil for to_param and allow through false values | Andrew White | 2011-03-09 | 1 | -1/+1 | |
| | ||||||
* | stop being clever and just call methods on the Route object | Aaron Patterson | 2011-03-08 | 2 | -1/+4 | |
| | ||||||
* | Improve testing of cookies in functional tests: | Andrew White | 2011-03-06 | 2 | -2/+7 | |
| | | | | | | | | | - cookies can be set using string or symbol keys - cookies are preserved across calls to get, post, etc. - cookie names and values are escaped - cookies can be cleared using @request.cookies.clear [#6272 state:resolved] | |||||
* | Raise ArgumentError if route name is invalid [#6517 state:resolved] | Andrew White | 2011-03-06 | 1 | -0/+2 | |
| | ||||||
* | Action Pack typos. | R.T. Lechow | 2011-03-05 | 1 | -2/+2 | |
| | ||||||
* | make sure string keys are always looked up from the class cache | Aaron Patterson | 2011-03-02 | 1 | -2/+3 | |
| | ||||||
* | use newer class cache api | Aaron Patterson | 2011-03-02 | 1 | -1/+1 | |
| | ||||||
* | yo dawg, directly use the class cache rather than the cache of the cache | Aaron Patterson | 2011-03-01 | 1 | -1/+2 | |
| | ||||||
* | refactor Reference to a ClassCache object, fix lazy lookup in Middleware so ↵ | Aaron Patterson | 2011-03-01 | 2 | -5/+13 | |
| | | | | that anonymous classes are supported | |||||
* | initialize ivars | Aaron Patterson | 2011-03-01 | 1 | -1/+1 | |
| | ||||||
* | Enumerable gives us include?, so remove include? | Aaron Patterson | 2011-03-01 | 1 | -4/+0 | |
| | ||||||
* | prefer composition over inheritance with AD::MS | Aaron Patterson | 2011-03-01 | 1 | -8/+37 | |
| | ||||||
* | Revert "compute ext in initialize, and use an attr_reader" | Aaron Patterson | 2011-02-28 | 1 | -5/+7 | |
| | | | | | | | | This reverts commit 2dbb73bdda3b81947fd112486ac4285fb1a6e3a9. Conflicts: actionpack/lib/action_dispatch/middleware/static.rb | |||||
* | no need to pass a regex to Regexp.compile | Aaron Patterson | 2011-02-28 | 1 | -4/+4 | |
| | ||||||
* | compute ext in initialize, and use an attr_reader | Aaron Patterson | 2011-02-28 | 1 | -7/+5 | |
| | ||||||
* | Fix named route helper for routes nested inside deeply nested resources | Andrew White | 2011-02-14 | 1 | -1/+1 | |
| | | | | [#6416 state:resolved] | |||||
* | Add notes on how to override the default :id constraint [#5994 state:resolved] | Andrew White | 2011-02-14 | 1 | -1/+8 | |
| | ||||||
* | Remove incorrect assert_recognizes example | Andrew White | 2011-02-13 | 1 | -3/+0 | |
| |