aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Make system tests take failed screenshots in `before_teardown` hookRichard Macklin2019-04-201-5/+7
| | | | | | | | | | | | Previously we were calling the `take_failed_screenshot` method in an `after_teardown` hook. However, this means that other teardown hooks have to be executed before we take the screenshot. Since there can be dynamic updates to the page after the assertion fails and before we take a screenshot, it seems desirable to minimize that gap as much as possible. Taking the screenshot in a `before_teardown` rather than an `after_teardown` helps with that, and has a side benefit of allowing us to remove the nested `ensure` commented on here: https://github.com/rails/rails/pull/34411#discussion_r232819478
* Change the deprecation message for dynamic routes segment to 6.1Abhay Nikam2019-04-201-2/+2
|
* Merge pull request #36000 from JosiMcClellan/fix-screenshot-filenamesEileen M. Uchitelle2019-04-191-1/+2
|\ | | | | handle long or duplicated screenshot filenames
| * truncate screenshot filenames to avoid errorJosi McClellan2019-04-181-1/+2
| |
* | Refactor after the most recent code reviewGenadi Samokovarov2019-04-191-2/+2
| |
* | Dispatch actions only if config.consider_all_requests_local is setGenadi Samokovarov2019-04-191-1/+1
| |
* | Drop the ambiguous `ActiveSupport::ActionableError#===` checkGenadi Samokovarov2019-04-191-13/+11
| |
* | Manage ActionDispatch::ActionableExceptions from the default middleware stackGenadi Samokovarov2019-04-191-1/+1
| |
* | Introduce Actionable ErrorsGenadi Samokovarov2019-04-197-2/+70
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actionable errors let's you dispatch actions from Rails' error pages. This can help you save time if you have a clear action for the resolution of common development errors. The de-facto example are pending migrations. Every time pending migrations are found, a middleware raises an error. With actionable errors, you can run the migrations right from the error page. Other examples include Rails plugins that need to run a rake task to setup themselves. They can now raise actionable errors to run the setup straight from the error pages. Here is how to define an actionable error: ```ruby class PendingMigrationError < MigrationError #:nodoc: include ActiveSupport::ActionableError action "Run pending migrations" do ActiveRecord::Tasks::DatabaseTasks.migrate end end ``` To make an error actionable, include the `ActiveSupport::ActionableError` module and invoke the `action` class macro to define the action. An action needs a name and a procedure to execute. The name is shown as the name of a button on the error pages. Once clicked, it will invoke the given procedure.
* Merge pull request #35975 from xithan/masterRafael França2019-04-151-1/+2
|\ | | | | mounted routes with non-word characters
| * mounted routes with non-word charactersxithan2019-04-151-1/+2
| |
* | Merge pull request #35919 from Shopify/simplify-define_url_helperRafael França2019-04-111-12/+10
|\ \ | | | | | | Simplify and fasten NamedRouteCollection#define_url_helper
| * | Simplify and fasten NamedRouteCollection#define_url_helperJean Boussier2019-04-101-12/+10
| |/
* / Adds named_captures to MatchData to emulate RegexBrandon Weaver2019-04-091-0/+4
|/ | | | | | | | | This change adds a `named_captures` method to `ActionDispatch::Journey::Path::MatchData` in order to emulate a similar method present on `Regex`'s `MatchData` present in Ruby core. This method can be useful for introspection of routes without the need to use `zip` while testing or developing in Rails core.
* `ast` is no longer to be `nil` since #33118Ryuta Kamizono2019-04-051-1/+0
|
* Deduplicate strings held by the routerJean Boussier2019-04-031-3/+7
|
* [ci skip] Doc for shallow: false options should use <tt> for better ↵Abhay Nikam2019-04-031-1/+1
| | | | readability. PR after #24405
* Merge pull request #24405 from waits/shallow-falseRafael França2019-04-021-1/+4
|\ | | | | Honor shallow: false on nested resources
| * Honor shallow: false on nested resourcesDylan Waits2016-04-031-1/+4
| | | | | | | | | | | | | | | | Previously there was no way to place a non-shallow resource inside a parent with `shallow: true` set. Now you can set `shallow: false` on a nested child resource to generate normal (non-shallow) routes for it. Fixes #23890.
* | url -> URL where apt inside actionpack/Sharang Dashputre2019-04-011-1/+1
| |
* | Fix annotated typoPrathamesh Sonpatki2019-03-291-1/+1
| |
* | Remove :all symbol from Mime::ALLJohn Hawthorn2019-03-271-1/+1
| | | | | | | | | | | | .all isn't a valid file extension, so it shouldn't used as a symbol. This also makes Mime::ALL better match how */* is parsed from an Accept header.
* | Merge pull request #35236 from renuo/fix-30467Rafael França2019-03-271-0/+4
|\ \ | | | | | | Prohibit sneaky custom params from being drawn (Fix #30467)
| * | Raise if resource custom params contain colonsJosua Schmid2019-03-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After this change it's not possible anymore to configure routes like this: routes.draw do resources :users, param: "name/:sneaky" end Fixes #30467.
* | | Add the `Mime::Type::InvalidMimeType` error in the default rescue_response:Edouard CHIN2019-03-263-3/+12
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | - https://github.com/rails/rails/pull/35604 introduced a vulnerability fix to raise an error in case the `HTTP_ACCEPT` headers contains malformated mime type. This will cause applications to throw a 500 if a User Agent sends an invalid header. This PR adds the `InvalidMimeType` in the default `rescue_responses` from the ExceptionWrapper and will return a 406. I looked up the HTTP/1.1 RFC and it doesn't stand what should be returned when the UA sends malformated mime type. Decided to get 406 as it seemed to be the status the better suited for this.
* | Merge pull request #35649 from andrehjr/fix-override-of-cookies-controller-specsRafael França2019-03-191-1/+1
|\ \ | | | | | | Don't override @set_cookies on CookieJar#update_cookies_from_jar'
| * | Don't override @set_cookies on CookieJar#update_cookies_from_jar'André Luis Leal Cardoso Junior2019-03-171-1/+1
| | | | | | | | | | | | | | | | | | When building the cookie_jar for the current test request. It was possible for this method to override keys currently being set on the test itself. In situations such as when making two requests mixing creating the cookie on the test and the controller.
* | | Merge pull request #35669 from cpruitt/update-mime-type-regexpAaron Patterson2019-03-191-1/+4
|\ \ \ | | | | | | | | Update regular expression for checking valid MIME type
| * | | Update regular expression for checking valid MIME typeCliff Pruitt2019-03-191-1/+4
| | | | | | | | | | | | | | | | MIME Type validation regular expression does not allow for MIME types initialized with strings that contain parameters after the MIME type name.
* | | | Instrument middleware processingDaniel Schierbeck2019-03-191-1/+22
|/ / / | | | | | | | | | | | | Adds ActiveSupport::Notifications instrumentation of the processing of each middleware in the stack.
* | | Merge pull request #35358 from tjwallace/patch-1Eileen M. Uchitelle2019-03-191-0/+3
|\ \ \ | | | | | | | | Add documentation for the resource(s) :param option
| * | | Add documentation for the resource(s) :param optionJeff Wallace2019-02-211-0/+3
| | | |
* | | | Raise exception when building invalid mime typeJohn Hawthorn2019-03-142-2/+11
| |/ / |/| | | | | | | | | | | | | | | | | This allows mime types in the form text/html, text/*, or */* This required a few minor test/code changes where previously nil was used as a mime string.
* | | Merge tag 'v6.0.0.beta3'eileencodes2019-03-132-3/+9
|\ \ \ | | | | | | | | | | | | v6.0.0.beta3 release
| * | | Fix possible dev mode RCEAaron Patterson2019-03-101-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the secret_key_base is nil in dev or test generate a key from random bytes and store it in a tmp file. This prevents the app developers from having to share / checkin the secret key for dev / test but also maintains a key between app restarts in dev/test. [CVE-2019-5420] Co-Authored-By: eileencodes <eileencodes@gmail.com> Co-Authored-By: John Hawthorn <john@hawthorn.email>
| * | | Only accept formats from registered mime typesJohn Hawthorn2019-03-101-0/+5
| | | | | | | | | | | | | | | | | | | | [CVE-2019-5418] [CVE-2019-5419]
* | | | Show friendly message to install action mailbox if the related table does ↵Prathamesh Sonpatki2019-03-122-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | not exist - This is similar to the work done in https://github.com/rails/rails/pull/31534
* | | | Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_blockKasper Timm Hansen2019-03-101-2/+2
|\ \ \ \ | | | | | | | | | | Ruby 2.7 warning: creating a Proc without a block
| * | | | ActionPack Proc.new without a blockutilum2019-02-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit fixes cases that use pre Ruby [r66772](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) syntax that are not tickled by the test suite.
* | | | | Support other optional parameters and quoted-strings on Content-Type parserr7kamura2019-03-101-4/+3
| | | | |
* | | | | Fix code examples' indentation in ActionDispatch::Routing [ci skip]Ricardo Díaz2019-02-261-4/+4
| |/ / / |/| | |
* | | | Restore UploadedFile compatibility with IO.copy_streamJanko Marohnić2019-02-231-1/+4
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In https://github.com/rails/rails/pull/28676 the `#to_path` method was added to `ActionDispatch::Http::UploadedFile`. This broke usage with `IO.copy_stream`: source = ActionDispatch::Http::UploadedFile.new(...) IO.copy_stream(source, destination) # ~> TypeError: can't convert ActionDispatch::Http::UploadedFile to IO (ActionDispatch::Http::UploadedFile#to_io gives Tempfile) Normally `IO.copy_stream` just calls `#read` on the source object. However, when `#to_path` is defined, `IO.copy_stream` calls `#to_io` in order to retrieve the raw `File` object. In that case it trips up, because `ActionDispatch::Http::UploadedFile#to_io` returned a `Tempfile` object, which is not an `IO` subclass. We fix this by having `#to_io` return an actual `File` object.
* | | appropriate typo fixalkesh262019-02-191-1/+1
| | |
* | | Merge pull request #35229 from rails/fix-35222Aaron Patterson2019-02-131-2/+2
|\ \ \ | |/ / |/| | Convert lookup context's to a stack for fixing #35222 and #34138
| * | Turn lookup context in to a stack, push and pop if formats changeAaron Patterson2019-02-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit keeps a stack of lookup contexts on the ActionView::Base instance. If a format is passed to render, we instantiate a new lookup context and push it on the stack, that way any child calls to "render" will use the same format information as the parent. This also isolates "sibling" calls to render (multiple calls to render in the same template). Fixes #35222 #34138
* | | Merge pull request #35175 from drn/create-sessionGuillermo Iguaran2019-02-121-1/+1
|\ \ \ | |/ / |/| | Support testing of non-ActionDispatch-routed apps.
| * | Support testing of non-ActionDispatch-routed apps.Darren Cheng2019-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The [Grape API framework](https://github.com/ruby-grape/grape) regularly writes tests like [spec/grape/api_spec.rb](https://github.com/ruby-grape/grape/blob/master/spec/grape/api_spec.rb). When attempting to write a test in a Rails environment similar to the following: ``` describe Grape::Api, type: :request do let(:app) { Class.new(Grape::API) do get 'test' do { foo: 'bar' } end end } it '200s' do get 'test' end end ``` The following exception is thrown: ``` NoMethodError: undefined method `url_helpers' for #<Array:0x00007fb4e4bc4c88> -- 0: .../lib/action_dispatch/testing/integration.rb:330:in `block in create_session' 1: .../lib/action_dispatch/testing/integration.rb:326:in `initialize' 2: .../lib/action_dispatch/testing/integration.rb:326:in `new' 3: .../lib/action_dispatch/testing/integration.rb:326:in `create_session' 4: .../lib/action_dispatch/testing/integration.rb:316:in `integration_session' 5: .../lib/action_dispatch/testing/integration.rb:348:in `block (2 levels) in <module:Runner>' ``` This change explicitly ensures that `app.routes` is an `ActionDispatch::Routing::RouteSet` instance.
* | | Merge pull request #35036 from rails/av-base-subclassAaron Patterson2019-02-061-0/+4
|\ \ \ | |/ / |/| | Move compiled ERB to an AV::Base subclass
| * | Pull generated methods up in to the anonymous subclassAaron Patterson2019-02-061-6/+1
| | | | | | | | | | | | Then we don't need the extra module.
| * | Move templates to an anonymous subclass of AV::BaseAaron Patterson2019-02-061-0/+9
| | | | | | | | | | | | | | | Now we can throw away the subclass and the generated methods will get GC'd too
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 02:30:36 +0000