Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| | * | | | | | Changed filter_matches to return a new NodeSet instead of Array. | Timm | 2014-06-15 | 1 | -1/+2 | |
| | | | | | | | ||||||
| | * | | | | | Initialized @css_selector_is_second_argument in determine_root_from. | Timm | 2014-06-15 | 1 | -0/+1 | |
| | | | | | | | ||||||
| | * | | | | | Changed early return for filter_matches as well as reassigning matches. ↵ | Timm | 2014-06-15 | 1 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Meddled with initialize in ArgumentFilter. | |||||
| | * | | | | | Removed redundant comments from assert_select. | Timm | 2014-06-15 | 1 | -3/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cleaned up a comment. | |||||
| | * | | | | | Added assert_size_match! with the assertions for assert_select. | Timm | 2014-06-15 | 1 | -14/+18 | |
| | | | | | | | ||||||
| | * | | | | | Changed some documentation for css_select. | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | | | | | ||||||
| | * | | | | | Replaced fragment calls with document, since we assume the responses are ↵ | Timm | 2014-06-15 | 1 | -9/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | complete documents. | |||||
| | * | | | | | Added filter_matches to reduce line count in assert_select. | Timm | 2014-06-15 | 1 | -24/+19 | |
| | | | | | | | ||||||
| | * | | | | | Renamed Selector to ArgumentFilter. Put code from HTMLSelector to ↵ | Timm | 2014-06-15 | 1 | -59/+39 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | ArgumentFilter. | |||||
| | * | | | | | Removed the custom selected proc. It's no longer needed. | Timm | 2014-06-15 | 1 | -10/+8 | |
| | | | | | | | ||||||
| | * | | | | | Updated selector to not have reponse_from_page. | Timm | 2014-06-15 | 1 | -5/+6 | |
| | | | | | | | ||||||
| | * | | | | | Changed css_select and pulled out response_from_page from Selector. | Timm | 2014-06-15 | 1 | -23/+17 | |
| | | | | | | | ||||||
| | * | | | | | Changed comparison from HTML::Node to Nokogiri::XML::Node in ↵ | Timm | 2014-06-15 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | assert_select_encoded. | |||||
| | * | | | | | Removed more redundant lines. Removed fix_content block that circumvented a ↵ | Timm | 2014-06-15 | 1 | -7/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | bug in html-scanner. | |||||
| | * | | | | | Removed more lines of code in assert_select. | Timm | 2014-06-15 | 1 | -7/+6 | |
| | | | | | | | ||||||
| | * | | | | | Simplified the first delete_if loop in assert_select to use Loofah's text ↵ | Timm | 2014-06-15 | 1 | -14/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | method. | |||||
| | * | | | | | Removed argument and root variable in assert_select proc. | Timm | 2014-06-15 | 1 | -4/+2 | |
| | | | | | | | ||||||
| | * | | | | | Changed name to selector. And a bunch of other things. | Timm | 2014-06-15 | 1 | -60/+51 | |
| | | | | | | | ||||||
| | * | | | | | The first attempt at abstracting argument parsing from selection methods. | Timm | 2014-06-15 | 1 | -81/+114 | |
| | | | | | | | ||||||
| | * | | | | | Removed tag.rb since it has been deprecated. | Timm | 2014-06-15 | 2 | -137/+0 | |
| | | | | | | | ||||||
| | * | | | | | Corrected documentation bug. | Timm | 2014-06-15 | 1 | -10/+57 | |
| | | | | | | | ||||||
| | * | | | | | Added Loofah as a dependency in actionview.gemspec. | Timm | 2014-06-11 | 1 | -9/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Implemented ActionView: FullSanitizer, LinkSanitizer and WhiteListSanitizer in sanitizers.rb. Deprecated protocol_separator and bad_tags. Added new tests in sanitizers_test.rb and reimplemented assert_dom_equal with Loofah. | |||||
* | | | | | | | Deprecate NamedRouteCollection#helpers. | Lucas Mazza | 2014-08-17 | 1 | -0/+5 | |
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method was removed at 210b338db20b1cdd0684f40bd78b52ed16148b99 but it is used by third party gems to check if a named route was defined. To help on the upgrade path on 4.2.0 we bring it back and emit a deprecation warning. | |||||
* | | | | | | Use AS::JSON for (de)serializing cookies | Godfrey Chan | 2014-08-17 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the Active Support JSON encoder for cookie jars using the `:json` or `:hybrid` serializer. This allows you to serialize custom Ruby objects into cookies by defining the `#as_json` hook on such objects. Fixes #16520. | |||||
* | | | | | | Merge pull request #16467 from strzalek/cookies-digest-config-option2 | Godfrey Chan | 2014-08-17 | 1 | -3/+9 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cookies digest config option (pt. 2) Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_dispatch/middleware/cookies.rb | |||||
| * | | | | | | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-12 | 1 | -3/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = 'SHA256' | |||||
* | | | | | | | Merge pull request #16484 from strzalek/remove-redundant-null-serializer | Godfrey Chan | 2014-08-17 | 1 | -16/+7 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Remove redundant NullSerializer | |||||
| * | | | | | | | Remove redundant NullSerializer | Łukasz Strzałkowski | 2014-08-13 | 1 | -16/+7 | |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | Use one from ActiveSupport::MessageEncryptor module. | |||||
* | | | | | | | extract methods and metaprogram less. | Aaron Patterson | 2014-08-14 | 1 | -11/+16 | |
| | | | | | | | ||||||
* | | | | | | | ask the scope object if it is a resource_method_scope | Aaron Patterson | 2014-08-13 | 1 | -10/+13 | |
| | | | | | | | ||||||
* | | | | | | | ask the scope for the action name | Aaron Patterson | 2014-08-13 | 1 | -14/+18 | |
| | | | | | | | ||||||
* | | | | | | | reduce calls to scope_level | Aaron Patterson | 2014-08-13 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this will help us to encapsulate magical symbols so hopefully we can eliminate hardcoded magic symbols | |||||
* | | | | | | | change to attr_reader | Aaron Patterson | 2014-08-13 | 1 | -5/+1 | |
| | | | | | | | ||||||
* | | | | | | | scope_level is no longer a hash key, just use the ivar | Aaron Patterson | 2014-08-13 | 1 | -4/+9 | |
| | | | | | | | ||||||
* | | | | | | | move the scope level key fully inside the scope object | Aaron Patterson | 2014-08-13 | 1 | -1/+5 | |
| | | | | | | | ||||||
* | | | | | | | move scope_level to a method on the scope object | Aaron Patterson | 2014-08-13 | 1 | -7/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | now we don't have to have a hard coded key | |||||
* | | | | | | | only look up scope level once | Aaron Patterson | 2014-08-13 | 1 | -6/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | avoid hash lookups and remove depency on the instance | |||||
* | | | | | | | only test `prefix` once | Aaron Patterson | 2014-08-13 | 1 | -2/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | we don't need to repeat if statements | |||||
* | | | | | | | pass consistent parameters to canonical_action? | Aaron Patterson | 2014-08-13 | 1 | -5/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | now we only have to look up @scope[:scope_level] once per call to canonical_action? and we don't have a variable named "flag" | |||||
* | | | | | | | fewer operations on the options hash | Aaron Patterson | 2014-08-13 | 1 | -10/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since we pass `as` down, then we won't have to do an insert / delete dance with the options hash | |||||
* | | | | | | | this should be accessing the hash, not calling a method | Aaron Patterson | 2014-08-13 | 1 | -1/+1 | |
| |_|_|/ / / |/| | | | | | ||||||
* | | | | | | use 'based on' instead of 'based off' [ci skip] | Akshay Vishnoi | 2014-08-12 | 2 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option" | Santiago Pastorino | 2014-08-08 | 1 | -8/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!! | |||||
* | | | | | | Add config option for cookies digest | Łukasz Strzałkowski | 2014-08-08 | 1 | -2/+8 | |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256' | |||||
* | | | | | Retrieve source code for the entire stack trace | Ryan Dao | 2014-08-08 | 8 | -69/+109 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors. | |||||
* | | | | | refactor Redirecting so we do not need a controller instance | Aaron Patterson | 2014-08-06 | 1 | -7/+2 | |
| | | | | | ||||||
* | | | | | avoid testing only_path | Aaron Patterson | 2014-08-04 | 1 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | we know that this call only wants the path returned, so lets call a method that returns the path. | |||||
* | | | | | Regenerate sid when sbdy tries to fixate the session | Santiago Pastorino | 2014-08-04 | 1 | -3/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed broken test. Thanks Stephen Richards for reporting. | |||||
* | | | | | Using no_result_var in Journey's parser generator | Jack Danger Canty | 2014-08-03 | 2 | -43/+33 | |
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the generated parser had an intermediate local variable `result` that really useful if you're building up a stateful object but Journey always discards the result argument to the reduce functions. This produces a simpler parser for anybody who actually wants to read the thing. Sadly, there's no real performance speedup with this change. | |||||
* | | | | always return a string from find_script_name | Aaron Patterson | 2014-08-01 | 2 | -7/+9 | |
| | | | | | | | | | | | | | | | | this allows us to avoid nil checks on the return value |