aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* if cookie is tampered with then nil is returned [ci skip]Neeraj Singh2013-03-251-4/+2
| | | | | | if the given key is not found then verifier does raise `ActiveSupport::MessageVerifier::InvalidSignature` exception but this exception is resuced and finally nil is returned.
* Introduce UpgradeLegacySignedCookieJar to transparently upgrade existing ↵Trevor Turk2013-03-241-99/+99
| | | | signed cookies generated by Rails 3 to avoid invalidating them when upgrading to Rails 4
* Merge pull request #9704 from trevorturk/warn-about-skipped-routesJeremy Kemper2013-03-241-1/+9
|\ | | | | Raise an ArgumentError when a clashing named route is defined
| * Tweak exception message to avoid giving potentially misleading suggestionsTrevor Turk2013-03-201-2/+3
| |
| * Raise an ArgumentError when a clashing named route is definedTrevor Turk2013-03-191-1/+8
| |
* | Fix some typosVipul A M2013-03-241-1/+1
|/
* Merge pull request #9794 from schneems/schneems/email-hostAndrew White2013-03-191-1/+12
|\ | | | | Fix improperly configured host in generated urls
| * Fix improperly configured host in generated urlsschneems2013-03-191-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the host in `default_url_options` is accidentally set with a protocol such as ``` host: "http://example.com" ``` then the generated url will have the protocol twice `http://http://example.com` which is not what the user intended. Likely they wanted to define a host `host: "example.com"` and a `protocol: "http://"` but did not know the convention. This may not the most common problem, but when it happens it can go undetected for a while. I accidentally added `http://` out of habit recently only to find all the links in my emails were broken after deploying a demo site to production. Rather than allow this accident go undetected, we can fix the problem in line by properly setting the protocol and host. I was able to find this related question on stack overflow: http://stackoverflow.com/questions/5878329/rails-3-devise-how-do-i-make-the-email-confirmation-links-use-secure-https-n where the answer was highly upvoted. This is based off of work in #7415 cc/ @pixeltrix ATP Action Mailer and Action Pack
* | Remove mentions of "app" from http request docs [ci skip]Carlos Antonio da Silva2013-03-191-12/+10
|/
* drop an unused hash; change slang to SPECIALVipul A M2013-03-191-2/+2
|
* Merge pull request #5606 from teohm/multipart_unicode_param_nameSteve Klabnik2013-03-153-31/+24
|\ | | | | multipart POST - utf8 param name not encoded
| * UTF-8 encode all keys and values in nested params hash.Teo Hui Ming2013-03-153-31/+24
| |
* | `Http::Headers` directly modifies the passed environment.Yves Senn2013-03-152-4/+4
|/ | | | | | | | | The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to #9700.
* Add extra clarifying line in docs. [ci skip]Steve Klabnik2013-03-131-0/+1
|
* Fix docs: response -> request.Steve Klabnik2013-03-131-2/+2
| | | | Even though I read it carefully, my brain tricked me. :cry:
* Merge pull request #9698 from garethrees/request_documentationSteve Klabnik2013-03-131-0/+16
|\ | | | | Add documentation to ActionDispatch::Request
| * Add documentation to ActionDispatch::RequestGareth Rees2013-03-131-0/+16
| |
* | `Http::Headers` respects dotted env vars, symbols, headers with numbers.Yves Senn2013-03-131-11/+6
| |
* | allow headers and env to be passed in `IntegrationTest`.Yves Senn2013-03-132-35/+49
| | | | | | | | Closes #6513.
* | refactor, `Http::Headers` stores headers in env notationYves Senn2013-03-131-17/+21
| | | | | | | | | | Also: cleanup, use consistent syntax for `Http::Header` and test.
* | Http::Headers respects headers that are not prefixed with HTTP_Yves Senn2013-03-131-1/+13
| |
* | Change from each to each_value in http/parameters since we don't use keyVipul A M2013-03-131-1/+1
|/
* Change useless tr to gsubrobertomiranda2013-03-061-2/+2
|
* change useless gsub to trrobertomiranda2013-03-052-3/+3
|
* Routing match `via` option requirement exception message made more explicitBoris Staal2013-03-051-1/+2
|
* Fix formats on xhr requests when HTTP_ACCEPT is empty stringmaximerety2013-03-041-1/+1
| | | | | | Fix ActionDispatch::Request#formats on xhr requests when HTTP_ACCEPT header is empty string. About issue #7774, same fix as in commit bebb02f but for xhr requests.
* Use custom visitor class for optimized url helpersAndrew White2013-03-033-9/+13
| | | | | | | | Rather than trying to use gsub to remove the optional route segments, which will fail with nested optional segments, use a custom visitor class that returns a empty string for group nodes. Closes #9524
* Remove redundant methodAndrew White2013-02-281-8/+0
|
* `format: true` does not override existing format constraints.Yves Senn2013-02-271-1/+1
| | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present.
* allow non-String default params in the router.Yves Senn2013-02-261-0/+2
| | | | | | | Closes #9435. Skip valid encoding checks for non-String parameters that come from the matched route's defaults.
* the router allows String contraints.Yves Senn2013-02-261-11/+17
| | | | Closes #9432.
* Merge pull request #9434 from zires/devRafael Mendonça França2013-02-261-1/+1
|\ | | | | Journey::Path::Pattern#new raise more meaningful exception message.
| * Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful ↵zires2013-02-271-1/+1
| | | | | | | | exception message.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-262-2/+2
|\ \
| * | Typo fix.Carson McDonald2013-02-211-1/+1
| | |
| * | improve grammar describing ActionDispatch::Cookies::CookieJar#deleteWeston Platter2013-02-191-1/+1
| | |
| * | improve grammar describing ActionDispatch::Cookies::CookieJar#deleteWeston Platter2013-02-191-1/+1
| | |
* | | Allow both a path and an option on root in config/routesSam Ruby2013-02-261-2/+9
| |/ |/|
* | determine the match shorthand target early.Yves Senn2013-02-211-14/+12
| | | | | | | | | | | | | | | | Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes.
* | Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-201-23/+3
| | | | | | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* | InvalidMessage is in ActiveSupport::MessageEncryptor namespaceSantiago Pastorino2013-02-191-1/+1
| | | | | | | | Closes #9302
* | Add missing require to routes inspectorCarlos Antonio da Silva2013-02-191-0/+1
| |
* | Require AS deps in ActionDispatch::Http::URLMiha Filej2013-02-191-0/+3
| | | | | | | | Allows us to use url_for and friends in isolation.
* | Duck typing is hard. Add header to HtmlTableFormatter.Steve Klabnik2013-02-181-0/+4
| | | | | | | | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔
* | editorial tweaksXavier Noria2013-02-191-3/+6
| |
* | use strip_heredoc to keep indentation consistent.Steve Klabnik2013-02-181-12/+12
| | | | | | | | Thanks @sikachu. :heart:
* | Add message when you have no routes defined.Steve Klabnik2013-02-181-0/+25
| | | | | | | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic.
* | Add headings to rake routes tableSteve Klabnik2013-02-181-3/+19
| |
* | Gist URLs are now namespacedAkira Matsuda2013-02-181-1/+1
| | | | | | | | see: https://github.com/blog/1406-namespaced-gists
* | Return false on toggle on error pagesBartlomiej Kozal2013-02-172-6/+7
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 05:10:19 +0000