aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-10-111-1/+1
|\ | | | | | | | | | | Conflicts: activerecord/lib/active_record/persistence.rb railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb
| * Space between "every" and "time"schneems2012-10-021-1/+1
| |
* | Revert "Use flat_map { } instead of map {}.flatten"Santiago Pastorino2012-10-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | This reverts commit abf8de85519141496a6773310964ec03f6106f3f. We should take a deeper look to those cases flat_map doesn't do deep flattening. irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten => [1, 3, 1, 2] irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i} => [[1, 3], [1, 2]]
* | Use flat_map { } instead of map {}.flattenSantiago Pastorino2012-10-051-2/+2
| |
* | config.action_dispatch.rack_cache should set explicitly to enable Rack::CacheGuillermo Iguaran2012-10-041-6/+1
| |
* | rename page_cache_extension option to default_static_extensionFrancesco Rodriguez2012-10-031-1/+1
| |
* | Failsafe exception returns text/plain.Steve Klabnik2012-10-011-3/+3
| | | | | | | | | | | | | | It's best to just return text/plain when something has gone terribly wrong. Fixes #5660.
* | resource and resources do no longer modify passed optionsYves Senn2012-10-011-2/+2
|/ | | | this is a patch for #7777.
* Merge pull request #7444 from szimek/params_parser_raises_parsing_errorAaron Patterson2012-09-261-5/+12
|\ | | | | Raise generic ParseError exception when ParamsParser fails parsing request params
| * Make ActionDispatch::ParamsParser::ParseError#original_exception return the ↵Szymon Nowak2012-08-271-4/+10
| | | | | | | | original exception.
| * Fix ActionDispatch::ParamsParser::ParseError message for XML and JSON parsers.Szymon Nowak2012-08-241-4/+2
| |
| * Raise generic ParseError exception when ActionDispatch::ParamsParser fails ↵Szymon Nowak2012-08-241-2/+5
| | | | | | | | parsing request params.
* | fixing most tests on Ruby 2.0Aaron Patterson2012-09-251-1/+1
| |
* | Merge pull request #7749 from blowmage/minitestAaron Patterson2012-09-251-0/+3
|\ \ | | | | | | Improve support for minitest's spec DSL
| * | Register AD::IntegrationTest for minitest's spec DSLMike Moore2012-09-241-0/+3
| | |
* | | depreacte unused Mime::Type#verify_request? and ↵grosser2012-09-241-1/+6
|/ / | | | | | | Mime::Type.browser_generated_types
* | documents ActionDispatch::Http::UploadedFileXavier Noria2012-09-221-6/+55
| |
* | Accept parameters in methods delegated to tempfileSergio Gil Pérez de la Manga2012-09-221-6/+2
| |
* | Delegate ActionDispatch::Http::UploadedFile#close to tempfileSergio Gil Pérez de la Manga2012-09-201-1/+1
| |
* | Removing to_shorthand from default_controller_and_action. Fixes #6497Luiz Felipe2012-09-191-1/+1
| | | | | | | | | | When using shortcut routes inside an engine the "to_shorthand" variable is set to true, causing the module scope of the route to not be applied.
* | log 404 status when ActiveRecord::RecordNotFound was raised (#7646)Yves Senn2012-09-171-1/+5
| |
* | Check if etag exists before to do the gsubRafael Mendonça França2012-09-151-2/+4
| | | | | | | | This fix the build http://travis-ci.org/#!/rails/rails/builds/2459981
* | fix the buildSteve Klabnik2012-09-151-0/+1
| |
* | Support for multiple etags in an If-None-Match headerTravis Warlick2012-09-151-1/+7
| | | | | | | | | | | | | | | | This is a rebased version of #2520. Conflicts: actionpack/test/dispatch/request_test.rb
* | Use internal instance variable naming scheme for mounted URL helper proxiesSam Pohlenz2012-09-091-1/+1
| |
* | Fixed missing requireIlya Vorontsov2012-09-081-0/+1
| | | | | | | | | | | | | | Missing require caused fail of guide generation (in action_dispatch/http/mime_type, line 295, undefined method `ends_with` for "to_ary":String) With this fix guides were normally generated
* | Improve error message for memcache session store when dalli isn't loaded in appGuillermo Iguaran2012-09-071-2/+6
| |
* | More fixes for action pack tests with Dalli.Arun Agrawal2012-09-061-3/+3
| |
* | Merge pull request #7530 from robin850/masterXavier Noria2012-09-051-1/+1
|\ \ | | | | | | Fix a typo in AD
| * | Fix a typoRobin Dupret2012-09-051-1/+1
| | |
* | | Merge pull request #7522 from lexmag/mime_typeRafael Mendonça França2012-09-041-84/+93
|\ \ \ | | | | | | | | Refactor `Mime::Type`
| * | | Refactor `Mime::Type`Aleksey Magusev2012-09-051-84/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `parse` method performance improvements - ~27-33%: accept = "image/gif, image/x-xbitmap, image/jpeg, image/pjpeg, application/x-shockwave-flash, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, , pronto/1.00.00, sslvpn/1.00.00.00, */*" Benchmark.measure{ 1_000_0.times { Mime::Type.parse(accept) }} old: 1.430000 0.000000 1.430000 ( 1.440977) new: 0.920000 0.000000 0.920000 ( 0.921813)
* | | | Make enhanced routing Concerns more tell-don't-askErnie Miller2012-09-031-25/+55
| | | |
* | | | Fix concerns not executing block in mapperErnie Miller2012-09-031-2/+19
| | | | | | | | | | | | | | | | Also, add documentation for alternate usage.
* | | | Allow routing concerns to accept a callableErnie Miller2012-09-031-3/+7
|/ / / | | | | | | | | | | | | | | | This allows us to make alterations to the generated routes based on the scope of the current mapper, and otherwise allows us to move larger blocks of concerns out of the routes file, altogether.
* | | Merge pull request #7495 from steveklabnik/issue_7478Aaron Patterson2012-09-013-4/+18
|\ \ \ | | | | | | | | Properly reset the session on reset_session
| * | | Force reloading of the session after destroyAndreas Loupasakis2012-09-011-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use load_for_write! to ensure a refresh of the session object. This way the new session_id and the empty data will be stored properly. E.g. in the case of the session cookie store this means that a new digest will be returned to the user.
| * | | Override rack's destroy_session in cookie storeAndreas Loupasakis2012-09-011-0/+8
| | | |
| * | | Assign a new session_id to session options hashAndreas Loupasakis2012-09-011-2/+2
| | | |
| * | | Properly reset the session on reset_sessionSteve Klabnik2012-08-311-2/+5
| | | | | | | | | | | | | | | | Fixes #7478
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-011-1/+1
|\ \ \ \
| * | | | Fix comment about Session.Steve Klabnik2012-08-311-1/+1
| | |_|/ | |/| | | | | | | | | | SessionHash isn't a thing, and tenses are wrong.
* | | | Revert "Merge pull request #7452 from arunagw/memcached_dalli"Jon Leighton2012-08-311-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7256cb53e0c34e510a4d59a50d120c0358cf1d99, reversing changes made to 6ebe22c3ae716d089af1e5090ddb0d12b31af8ac. Reason: A test was failing.
* | | | Update actionpack/lib/action_dispatch/routing/mapper.rbErik Ordway2012-08-291-1/+1
| |/ / |/| | | | | escape the '.'s  
* | | refactor route_set `generate_extras` functionalityschneems2012-08-281-17/+9
| | | | | | | | | | | | | | | | | | The result of Generator with or without the @extras instance variable set contains the desired information. Rather than preserving state when initializing the original object, we can simply extract the keys from the resultant parameters. ATP Actionpack, railties
* | | Add Missing Keys from Journey on failed URL formatschneems2012-08-281-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many named routes have keys that are required to successfully resolve. If a key is left off like this: <%= link_to 'user', user_path %> This will produce an error like this: No route matches {:action=>"show", :controller=>"users"} Since we know that the :id is missing, we can add extra debugging information to the error message. No route matches {:action=>"show", :controller=>"users"} missing required keys: [:id] This will help new and seasoned developers look closer at their parameters. I've also subclassed the routing error to be clear that this error is a result of attempting to generate a url and not because the user is trying to visit a bad url. While this may sound trivial this error message is misleading and confuses most developers. The important part isn't what's in the options its's what's missing. Adding this information to the error message will make debugging much more obvious. This is the sister pull request of https://github.com/rails/journey/pull/44 which will be required to get they missing keys into the correct error message. Example Development Error in Rails: http://cl.ly/image/3S0T0n1T3421
* | | removed : warning: `*' interpreted as argument prefixArun Agrawal2012-08-281-1/+1
| | |
* | | Merge pull request #7452 from arunagw/memcached_dalliRafael Mendonça França2012-08-281-3/+3
|\ \ \ | | | | | | | | Memcached to dalli for actionpack test.
| * | | More fixes for action pack tests with Dalli.Arun Agrawal2012-08-271-3/+3
| |/ /
* | | Don't require action_dispatch in ActionView::UrlHelpersPiotr Sarnacki2012-08-281-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This was changed by splitting previous implementation of UrlHelper into 2 modules: ActionView::Helpers::UrlHelper and ActionView::Routing::UrlHelper. The former one keeps only basic implementation of url_for. The latter adds features that allow to use routes and is only required when url_helpers or mounted_helpers are required.