aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* extract methods and metaprogram less.Aaron Patterson2014-08-141-11/+16
|
* ask the scope object if it is a resource_method_scopeAaron Patterson2014-08-131-10/+13
|
* ask the scope for the action nameAaron Patterson2014-08-131-14/+18
|
* reduce calls to scope_levelAaron Patterson2014-08-131-1/+5
| | | | | this will help us to encapsulate magical symbols so hopefully we can eliminate hardcoded magic symbols
* change to attr_readerAaron Patterson2014-08-131-5/+1
|
* scope_level is no longer a hash key, just use the ivarAaron Patterson2014-08-131-4/+9
|
* move the scope level key fully inside the scope objectAaron Patterson2014-08-131-1/+5
|
* move scope_level to a method on the scope objectAaron Patterson2014-08-131-7/+20
| | | | now we don't have to have a hard coded key
* only look up scope level onceAaron Patterson2014-08-131-6/+7
| | | | avoid hash lookups and remove depency on the instance
* only test `prefix` onceAaron Patterson2014-08-131-2/+4
| | | | we don't need to repeat if statements
* pass consistent parameters to canonical_action?Aaron Patterson2014-08-131-5/+5
| | | | | now we only have to look up @scope[:scope_level] once per call to canonical_action? and we don't have a variable named "flag"
* fewer operations on the options hashAaron Patterson2014-08-131-10/+10
| | | | | since we pass `as` down, then we won't have to do an insert / delete dance with the options hash
* this should be accessing the hash, not calling a methodAaron Patterson2014-08-131-1/+1
|
* use 'based on' instead of 'based off' [ci skip]Akshay Vishnoi2014-08-122-2/+2
|
* Revert "Merge pull request #16434 from strzalek/cookies-digest-config-option"Santiago Pastorino2014-08-081-8/+2
| | | | | | | This reverts commit 705977620539e2be6548027042f33175ebdc2505, reversing changes made to dde91e9bf5ab246f0f684b40288b272f4ba9a699. IT BROKE THE BUILD!!!
* Add config option for cookies digestŁukasz Strzałkowski2014-08-081-2/+8
| | | | | | You can now configure custom digest for cookies in the same way as `serializer`: config.action_dispatch.cookies_digest = \SHA256'
* Retrieve source code for the entire stack traceRyan Dao2014-08-088-69/+109
| | | | | | Provide the ability to extract the source code of the entire exception stack trace, not just the frame raising the error. This improves debugging capability of the error page, especially for framework-related errors.
* refactor Redirecting so we do not need a controller instanceAaron Patterson2014-08-061-7/+2
|
* avoid testing only_pathAaron Patterson2014-08-041-0/+4
| | | | | we know that this call only wants the path returned, so lets call a method that returns the path.
* Regenerate sid when sbdy tries to fixate the sessionSantiago Pastorino2014-08-041-3/+3
| | | | | | Fixed broken test. Thanks Stephen Richards for reporting.
* Using no_result_var in Journey's parser generatorJack Danger Canty2014-08-032-43/+33
| | | | | | | | | | | Previously the generated parser had an intermediate local variable `result` that really useful if you're building up a stateful object but Journey always discards the result argument to the reduce functions. This produces a simpler parser for anybody who actually wants to read the thing. Sadly, there's no real performance speedup with this change.
* always return a string from find_script_nameAaron Patterson2014-08-012-7/+9
| | | | this allows us to avoid nil checks on the return value
* use `get` instead of accessing the named routes internalsAaron Patterson2014-07-311-1/+1
|
* invert check so we fail fasterAaron Patterson2014-07-311-1/+1
| | | | | there's no reason to to_sym the string if it doesn't match the regexp anyway
* do a hash lookup for collision detectionAaron Patterson2014-07-312-1/+5
| | | | hash lookup should be faster than searching an array.
* Realign assignments :scissors:Carlos Antonio da Silva2014-07-311-5/+5
|
* Do not reassign variable when mutation is happeningCarlos Antonio da Silva2014-07-311-8/+5
| | | | | These methods mutate the path variable/argument so there is no need to reassign it every time.
* Only concatenate path if it was given rather than converting blindlyCarlos Antonio da Silva2014-07-311-1/+1
|
* Rename variable to better show its intentCarlos Antonio da Silva2014-07-311-12/+12
|
* Simplify conditionalCarlos Antonio da Silva2014-07-311-3/+2
|
* Push options check up so we can simplify internal methodsCarlos Antonio da Silva2014-07-311-13/+10
|
* remove useless deupAaron Patterson2014-07-301-1/+1
| | | | | every call to default_resources_path_names allocates a new hash, no need to dup
* push options inside the scope objectAaron Patterson2014-07-301-4/+9
|
* turn scope in to a linked listAaron Patterson2014-07-301-15/+36
| | | | this makes scope rollback much easier
* remove alias_method_chainAaron Patterson2014-07-301-4/+2
| | | | we can `super` in to the previous implementation.
* avoid instrospection on the moduleAaron Patterson2014-07-301-1/+2
| | | | | we already know what helpers are path helpers, so just iterate through that list and define the helpers with warnings
* fix variable nameAaron Patterson2014-07-301-3/+3
|
* split path_helpers and url_helpersAaron Patterson2014-07-301-18/+25
| | | | | this lets us avoid hard coding a regexp for separating path and url helpers in the clear! method.
* `add` will remove the method if it exists alreadyAaron Patterson2014-07-301-1/+0
|
* Deprecate `*_path` methods in mailers@schneems and @sgrif2014-07-301-48/+72
| | | | | | | | | | | Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
* Revert "Merge pull request #15305 from tgxworld/remove_unnecessary_require"Santiago Pastorino2014-07-301-0/+1
| | | | | | | This reverts commit f632f79b8dcd144408c66a544984b2ba9cf52f87, reversing changes made to 98c7fe87690ca4de6c46e8f69806e82e3f8af42d. Closes #16343
* oops! :bomb:Aaron Patterson2014-07-291-1/+1
| | | | use helpers.include? so we don't get any false positives
* ask the named routes collection if the route is definedAaron Patterson2014-07-292-1/+5
| | | | | we should not be accessing internals to figure out if a method is defined.
* helpers should be a Set so it doesn't grow unboundedAaron Patterson2014-07-291-4/+12
| | | | | since helpers is a set, we can be confident about when to remove methods from the module.
* pass the module to define_named_route_methodsAaron Patterson2014-07-291-7/+7
| | | | after this, we can disconnect @module from the instance
* only ask for the routes module onceAaron Patterson2014-07-291-2/+4
| | | | we can cache the module on the stack, then reuse it
* eval_block should be privateAaron Patterson2014-07-291-0/+1
|
* remove the mounted? methodAaron Patterson2014-07-282-6/+2
| | | | | we know the routes should not be "optimized" when mounting an application
* remove some cachingAaron Patterson2014-07-281-2/+1
| | | | | this caching doesn't increase performance, but does increase complexity. remove it for now and find better ways to speed up this code.
* Fix AC::TemplateAssertions instance variables not resetting.Guo Xiang Tan2014-07-211-0/+1
| | | | Fixes https://github.com/rails/rails/issues/16119.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 00:36:01 +0000