Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Remove unnecessary empty line | José Valim | 2012-04-25 | 1 | -1/+0 | |
| | | ||||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -2/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | |||||
* | | Merge pull request #5961 from bogdan/routes | Jeremy Kemper | 2012-04-24 | 1 | -20/+26 | |
|\ \ | | | | | | | Refactor ActionDispatch::HTTP::Url#url_for | |||||
| * | | ActionDispatch::HTTP::Url#url_for refactor method | Bogdan Gusiev | 2012-04-24 | 1 | -20/+26 | |
| | | | | | | | | | | | | | | | Separated right side url generation(before query string) from left side url generation(after query string) | |||||
* | | | Refactor hash creation in routeset | Carlos Antonio da Silva | 2012-04-24 | 1 | -3/+4 | |
|/ / | ||||||
* | | RouteSet: decomplecting a way to handle positional args | Bogdan Gusiev | 2012-04-24 | 1 | -26/+20 | |
| | | ||||||
* | | RouteSet: simplify routes helpers generation code | Bogdan Gusiev | 2012-04-24 | 1 | -13/+21 | |
| | | ||||||
* | | Add missing requires in routes | Bogdan Gusiev | 2012-04-23 | 2 | -0/+3 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-21 | 1 | -2/+2 | |
|\ | ||||||
| * | Fix formatting | Oscar Del Ben | 2012-04-18 | 1 | -2/+2 | |
| | | ||||||
* | | Freeze the middleware stack after it's built | Jeremy Kemper | 2012-04-20 | 1 | -1/+1 | |
|/ | | | | | | So apps that accidentally add middlewares later aren't unwittingly dumping them in a black hole. Closes #5911 | |||||
* | let's keep the slash in the return value instead of the path variable [ci skip] | Vijay Dev | 2012-04-18 | 1 | -2/+2 | |
| | ||||||
* | Warn about do end syntax in redirect option | Oscar Del Ben | 2012-04-17 | 1 | -0/+3 | |
| | ||||||
* | Fix redirect with block example | Alexey Vakhov | 2012-04-17 | 1 | -3/+3 | |
| | ||||||
* | Fix example in flash middleware | Alexey Vakhov | 2012-04-17 | 1 | -1/+1 | |
| | ||||||
* | Fix comment in AD http response | Alexey Vakhov | 2012-04-13 | 1 | -1/+1 | |
| | | | | response in integration test accessible without @ via attr_reader | |||||
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 | |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-07 | 1 | -1/+1 | |
|\ | ||||||
| * | Fix example action dispatch in mime type | Alexey Vakhov | 2012-04-07 | 1 | -1/+1 | |
| | | ||||||
* | | documents the contract for the argument of AD::Routing::RouteSet#url_for | Xavier Noria | 2012-04-05 | 1 | -0/+1 | |
| | | ||||||
* | | Make url_for work when option is nil and default_url_options has | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 | |
| | | | | | | | | stringified keys | |||||
* | | Fix url_for when options is nil | Rafael Mendonça França | 2012-04-05 | 1 | -1/+1 | |
|/ | | | | | RouteSet#url_for was modifying the options hash that belong to the caller | |||||
* | url_for: avoid a nil check. unroll a loop. handle most common case 1st. | ara.t.howard | 2012-04-05 | 1 | -18/+13 | |
| | ||||||
* | carefully and quickly merge url_for options | ara.t.howard | 2012-04-04 | 1 | -1/+17 | |
| | ||||||
* | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 2 | -3/+3 | |
|\ | | | | | Updated/changed unneeded tr/gsubs | |||||
| * | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 2 | -3/+3 | |
| | | ||||||
* | | No need to extend ActiveSupport::Extend here | Oscar Del Ben | 2012-04-04 | 1 | -2/+0 | |
|/ | ||||||
* | Merge pull request #5694 from hardipe/master | Santiago Pastorino | 2012-04-01 | 1 | -4/+0 | |
|\ | | | | | Tidy up cookies.rb a bit | |||||
| * | Useless/Confusing method definition removed | hardi | 2012-04-01 | 1 | -4/+0 | |
| | | ||||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-01 | 1 | -1/+1 | |
|\ \ | |/ |/| | ||||||
| * | :success includes the whole 200 range, not just 200. | Erich Menge | 2012-04-01 | 1 | -1/+1 | |
| | | | | | | | | | | # File lib/rack/response.rb, line 114 114: def successful?; @status >= 200 && @status < 300; end | |||||
* | | Remove not needed requires | Santiago Pastorino | 2012-03-31 | 1 | -1/+0 | |
| | | ||||||
* | | Remove the leading \n added by textarea on assert_select | Santiago Pastorino | 2012-03-30 | 1 | -0/+1 | |
| | | ||||||
* | | adds delegetion for eof? to AD::Http::UploadedFile | Jens Fahnenbruck | 2012-03-27 | 1 | -1/+1 | |
|/ | | | | | if you want to read the file you may need to ask if there is something to read from | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-03-27 | 1 | -0/+19 | |
|\ | ||||||
| * | add missing do [ci skip] | Vijay Dev | 2012-03-27 | 1 | -1/+1 | |
| | | ||||||
| * | added shallow_prefix option description in documantation | Lukasz Sarnacki | 2012-03-27 | 1 | -0/+19 | |
| | | | | | | | | It is in response for confusion in issue #5301 | |||||
* | | Return the same session data object when setting session id | Carlos Antonio da Silva | 2012-03-26 | 1 | -1/+2 | |
| | | ||||||
* | | Allow a defining custom member field on resources | Jamie Macey | 2012-03-25 | 1 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | By default, resources routes are created with :resource/:id. A model defining to_param can make prettier urls by using something more readable than an integer ID, but since the route picks it up as :id you wind up with awkward User.find_by_username(params[:id]) calls. By overriding the key to be used in @request.params you can be more obvious in your intent. | |||||
* | | Revert "Return an actual boolean from xml_http_request?" | Xavier Noria | 2012-03-25 | 1 | -1/+1 | |
|/ | | | | | | | | | | | | | | Reason: This commit changes code that was committed some year and a half ago. The original code is an ordinary predicate that delegates straight to a boolean operator with no further unnecessaru adorments, as clearly explained in #5329. This change also may confuse users who may now believe they can rely now on singletons, while predicates in Rails rely on standard Ruby semantics for boolean values and guarantee no singletons whatsover. This reverts commit 6349791d5aaf652631b29f1371701fc2985fda83. | |||||
* | Return an actual boolean from xml_http_request? | Tim Pope | 2012-03-23 | 1 | -1/+1 | |
| | ||||||
* | Fix secure cookies when there are more than one space before the secure | Rafael Mendonça França | 2012-03-19 | 1 | -1/+1 | |
| | | | | keyword | |||||
* | Remove exclude option from ActionDispatch::SSL | Rafael Mendonça França | 2012-03-19 | 1 | -7/+0 | |
| | ||||||
* | Whitespaces :scissors: | Rafael Mendonça França | 2012-03-17 | 1 | -1/+1 | |
| | ||||||
* | Some refactoring and update ActionDispatch::SSL code to use the Rack 1.4.x | Rafael Mendonça França | 2012-03-17 | 1 | -23/+13 | |
| | ||||||
* | Rack::SSL -> ActionDispatch::SSL | Rafael Mendonça França | 2012-03-17 | 1 | -0/+87 | |
| | ||||||
* | Add missing require | Santiago Pastorino | 2012-03-17 | 1 | -0/+1 | |
| | ||||||
* | Remove unused require | Santiago Pastorino | 2012-03-17 | 1 | -1/+0 | |
| | ||||||
* | strip null bytes from Location header as well | Brian Lopez | 2012-03-15 | 1 | -1/+1 | |
| | | | | add tests for stripping \r\n chars since that's already happening | |||||
* | Merge pull request #5337 from mreinsch/static_invalid_byte_sequence | Aaron Patterson | 2012-03-15 | 1 | -0/+1 | |
|\ | | | | | fix ArgumentError being raised in case of invalid byte sequences |