Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | nodoc the helper classes, cache stuff for optimized helper | Aaron Patterson | 2013-01-30 | 1 | -13/+17 | |
| | | ||||||
* | | cache path parts in the instance | Aaron Patterson | 2013-01-30 | 1 | -2/+3 | |
| | | ||||||
* | | stop evaling a string every time | Aaron Patterson | 2013-01-30 | 1 | -4/+4 | |
| | | ||||||
* | | moving helper classes outside the private block | Aaron Patterson | 2013-01-30 | 1 | -90/+88 | |
| | | ||||||
* | | pushing specialization down to the optimized class | Aaron Patterson | 2013-01-30 | 1 | -23/+25 | |
| | | ||||||
* | | use polymorphism to remove conditional | Aaron Patterson | 2013-01-30 | 1 | -35/+27 | |
| | | ||||||
* | | move conditionals to instance | Aaron Patterson | 2013-01-30 | 1 | -6/+16 | |
| | | ||||||
* | | pull stuff out of the caller and hide in the instance | Aaron Patterson | 2013-01-30 | 1 | -4/+3 | |
| | | ||||||
* | | moving more stuff on to the instance | Aaron Patterson | 2013-01-30 | 1 | -18/+18 | |
| | | ||||||
* | | move optimize_helper? to the helper instance | Aaron Patterson | 2013-01-30 | 1 | -9/+12 | |
| | | ||||||
* | | moving more stuff to the instance | Aaron Patterson | 2013-01-30 | 1 | -6/+6 | |
| | | ||||||
* | | moving some stuff to the initializer | Aaron Patterson | 2013-01-30 | 1 | -14/+38 | |
| | | ||||||
* | | moved more evald code | Aaron Patterson | 2013-01-30 | 1 | -8/+7 | |
| | | ||||||
* | | factored out some of the dynamic code | Aaron Patterson | 2013-01-30 | 1 | -19/+31 | |
| | | ||||||
* | | Add 'X-UA-Compatible' => 'chrome=1' to default headers | Guillermo Iguaran | 2013-01-29 | 1 | -1/+2 | |
| | | ||||||
* | | Remove BestStandardsSupport middleware | Guillermo Iguaran | 2013-01-29 | 2 | -31/+0 | |
| | | ||||||
* | | Use Encoding::UTF_8 constant :do_not_litter: | Akira Matsuda | 2013-01-28 | 3 | -3/+3 | |
| | | ||||||
* | | add fetch to CookieJar | Aaron Patterson | 2013-01-27 | 1 | -0/+4 | |
| | | ||||||
* | | Merge remote-tracking branch 'docrails/master' | Xavier Noria | 2013-01-26 | 1 | -2/+14 | |
|\ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb | |||||
| * | | generic pass before merging docrails | Xavier Noria | 2013-01-26 | 1 | -5/+7 | |
| | | | ||||||
| * | | Add documentation to ActionDispatch::Response | Matthew Stopa | 2013-01-20 | 1 | -0/+7 | |
| | | | ||||||
| * | | Fix typo introduced in 0004ca3a | Carlos Antonio da Silva | 2013-01-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | [ci skip] | |||||
| * | | More documentation for ActionDispatch::Response | Matthew Stopa | 2013-01-16 | 1 | -1/+3 | |
| | | | | | | | | | | | | [ci skip] | |||||
| * | | Document ActionDispatch::Response#body method | Matthew Stopa | 2013-01-16 | 1 | -0/+1 | |
| | | | ||||||
* | | | Integrate Action Pack with Rack 1.5 | Carlos Antonio da Silva | 2013-01-25 | 1 | -0/+4 | |
| | | | | | | | | | | | | | | | | | | All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino] | |||||
* | | | use the helpers list rather than getting the methods from the module | Aaron Patterson | 2013-01-24 | 1 | -1/+1 | |
| | | | ||||||
* | | | module_eval is not necessary here | Aaron Patterson | 2013-01-24 | 1 | -3/+1 | |
| | | | ||||||
* | | | don't need to eval everything | Aaron Patterson | 2013-01-24 | 1 | -1/+1 | |
| | | | ||||||
* | | | Duplicate possible frozen string from route | Andrew White | 2013-01-21 | 1 | -2/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 1.9 freezes Hash string keys by default so where a route is defined like this: get 'search' => 'search' then the Mapper will derive the action from the key. This blows up later when the action is added to the parameters hash and the encoding is forced. Closes #3429 | |||||
* | | | In Browser Path Matching with Javascript | schneems | 2013-01-20 | 3 | -12/+121 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When debugging routes ,it can sometimes be difficult to understand exactly how the paths are matched. This PR adds a JS based path matching widget to the `/rails/info/routes` output. You can enter in a path, and it will tell you which of the routes that path matches, while preserving order (top match wins). The matching widget in action: ![](http://f.cl.ly/items/3A2F0v2m3m1Z1p3P3O3k/path-match.gif) Prior to this PR the only way to check matching paths is via mental math, or typing in a path in the url bar and seeing where it goes. This feature will be an invaluable debugging tool by dramatically decreasing the time needed to check a path match. ATP actionpack | |||||
* | | | Merge pull request #8977 from Soylent/master | Aaron Patterson | 2013-01-18 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Resovled issue rails#7774 | |||||
| * | | | Fix ActionDispatch::Request#formats when HTTP_ACCEPT header is empty string | Konstantin Papkovskiy | 2013-01-17 | 1 | -1/+1 | |
| | |/ | |/| | ||||||
* | | | Fix syntax error :grin: | Guillermo Iguaran | 2013-01-18 | 1 | -1/+1 | |
| | | | ||||||
* | | | Remove "Application" section title from routes | schneems | 2013-01-18 | 1 | -6/+13 | |
|/ / | | | | | | | | | | | | | | | | | This PR standardizes the output of the HTML and console based routes to not include the title for "Application Routes" those that are defined by the application. Instead only routes defined in engines get any special treatment. Based on this conversation: https://github.com/rails/rails/commit/af5c0fd85fce1adb311083dd1ecf96432ee8caa3#commitcomment-2458823 ATP actionpack /cc @carlosantoniodasilva | |||||
* | | Merge pull request #8958 from balexand/strong_parameters_exception_handling | Rafael Mendonça França | 2013-01-15 | 1 | -1/+2 | |
|\ \ | | | | | | | Strong parameters exception handling | |||||
| * | | strong parameters exception handling | Brian Alexander | 2013-01-15 | 1 | -1/+2 | |
| | | | ||||||
* | | | Remove header bloat introduced by BestStandardsSupport middleware | Edward Anderson | 2013-01-15 | 1 | -1/+3 | |
|/ / | | | | | | | The same headers were being duplicated on every request. | |||||
* | | Change the behavior of route defaults | Andrew White | 2013-01-15 | 3 | -6/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit changes route defaults so that explicit defaults are no longer required where the key is not part of the path. For example: resources :posts, bucket_type: 'posts' will be required whenever constructing the url from a hash such as a functional test or using url_for directly. However using the explicit form alters the behavior so it's not required: resources :projects, defaults: { bucket_type: 'projects' } This changes existing behavior slightly in that any routes which only differ in their defaults will match the first route rather than the closest match. Closes #8814 | |||||
* | | Add support for other types of routing constraints | Andrew White | 2013-01-15 | 3 | -113/+174 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This now allows the use of arrays like this: get '/foo/:action', to: 'foo', constraints: { subdomain: %w[www admin] } or constraints where the request method returns an Fixnum like this: get '/foo', to: 'foo#index', constraints: { port: 8080 } Note that this only applies to constraints on the request - path constraints still need to be specified as Regexps as the various constraints are compiled into a single Regexp. | |||||
* | | Ensure port is set when passed via the process method | Andrew White | 2013-01-15 | 1 | -1/+1 | |
| | | ||||||
* | | Raise correct exception now Journey is integrated. | Andrew White | 2013-01-15 | 2 | -5/+8 | |
| | | | | | | | | | | | | | | Now that Journey has been integrated into ActionDispatch we can raise the exception ActionController::UrlGenerationError directly rather than raising the internal Journey::Router::RoutingError and then have ActionDispatch::Routing::RouteSet#generate re-raise the exception. | |||||
* | | Fix regression introduced in pull request 8812 | Sam Ruby | 2013-01-11 | 1 | -1/+2 | |
| | | | | | | | | See https://github.com/rails/rails/pull/8812#commitcomment-2416514 | |||||
* | | Merge pull request #8882 from goshakkk/clearer-conditional | Carlos Antonio da Silva | 2013-01-11 | 1 | -3/+3 | |
|\ \ | | | | | | | Clearer conditional in constraint match check | |||||
| * | | clearer conditional in constraint match check | Gosha Arinich | 2013-01-10 | 1 | -3/+3 | |
| | | | ||||||
* | | | Fix json params parsing regression for non-object JSON content. | Dylan Smith | 2013-01-11 | 1 | -2/+2 | |
|/ / | | | | | | | Fixes #8845. | |||||
* | | extract PerformanceTest into rails-performance_tests gem | Yves Senn | 2013-01-10 | 1 | -10/+0 | |
| | | ||||||
* | | adding missing requires | Aaron Patterson | 2013-01-09 | 2 | -0/+9 | |
| | | ||||||
* | | Merge pull request #8824 from mjtko/fix/cookie-store-inheritance | Santiago Pastorino | 2013-01-08 | 2 | -5/+26 | |
|\ \ | | | | | | | Modify CookieStore middleware inheritance to avoid subclassing Rack::Session::Cookie [Fix for #7372] | |||||
| * | | Revert cb3181e - no longer required. | Mark J. Titorenko | 2013-01-08 | 1 | -2/+0 | |
| | | | ||||||
| * | | Fix CookieStore middleware inheritance hierarchy s.t. it inherits from ↵ | Mark J. Titorenko | 2013-01-08 | 1 | -3/+26 | |
| | | | | | | | | | | | | Rack::Session::Abstract::ID rather than Rack::Session::Cookie. |