aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8783 from goshakkk/refactor-journey-routesRafael Mendonça França2013-01-061-12/+11
|\ | | | | Refactor Journey::Routes
| * refactor Journey::RoutesGosha Arinich2013-01-071-12/+11
| | | | | | | | | | * prefer do-end for multiline blocks * prefer or-equals over returns with checks
* | fix for rbxtank-bohr2013-01-071-2/+2
|/ | | | | | | | | Rubinius returns a boolean after such assingment response = (_, headers, body = @app.call(env)) see https://github.com/rubinius/rubinius/issues/2117 get rid of a local variable
* Needless requiresAkira Matsuda2013-01-061-4/+0
|
* Missing requiresAkira Matsuda2013-01-061-0/+1
|
* Rename route_wrapper partial layout to tableCarlos Antonio da Silva2013-01-062-1/+1
| | | | | | It is used by the table formatter only, and it's already inside a routes directory that namespaces it properly, so calling it just "table" seems simpler.
* Move table routes formatter class to the inspector and rename itCarlos Antonio da Silva2013-01-063-19/+19
| | | | | | | It feels more consistent to have this class called "HtmlTableFormatter", and to have it here with the routes inspector and console formatter, since it's used for both routing error exceptions and the rails info page.
* Refactor to not call path.ast twiceCarlos Antonio da Silva2013-01-061-2/+3
|
* refactor Route#ast to use or-equals and block, instead of return with a condGosha Arinich2013-01-061-5/+4
|
* Remove unnecessary begin..rescue..end, use only rescueAkira Matsuda2013-01-061-5/+3
|
* Merge pull request #8766 from jcoglan/session_token_docsAndrew White2013-01-051-7/+4
|\ | | | | | | | | Remove suggestion that Procs can be used as session secrets. [ci skip]
| * Remove suggestion that Procs can be used as session secrets.James Coglan2013-01-051-7/+4
| |
* | Remove warning, remove not used variable, and make methods privateCarlos Antonio da Silva2013-01-051-3/+5
|/ | | | Warning: "shadowing outer local variable - routes".
* Close container div tag in routing error pageCarlos Antonio da Silva2013-01-051-9/+11
|
* Move style to head to make routes page valid html5Carlos Antonio da Silva2013-01-052-4/+6
|
* display mountable engine routes on RoutingError.Yves Senn2013-01-052-8/+23
|
* split formatting concerns from RoutesInspectorYves Senn2013-01-051-20/+42
|
* Allow use of durations for ActionDispatch::SSL configurationAndrew White2013-01-041-1/+1
|
* Remove unnecessary `ERB::Util::h`Ryunosuke SATO2013-01-057-17/+17
| | | | It is automatically applied when strings is unsafe for html.
* Suppress warning about IO#lines in Ruby 2.0Ryunosuke SATO2013-01-041-1/+1
| | | | actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead
* Merge pull request #8723 from goshakkk/refactor-error-pageGuillermo Iguaran2013-01-033-5/+27
|\ | | | | Move error page js into script tag
| * move error page js into script tagGosha Arinich2013-01-043-5/+27
| |
* | Add documentation to ActionDispatch::Http::UploadedFile#headersRafael Mendonça França2013-01-031-0/+1
| | | | | | | | [ci skip]
* | Remove a useless TODO commentRobin Dupret2013-01-031-1/+0
|/
* Merge pull request #8713 from goshakkk/better-error-pageGuillermo Iguaran2013-01-032-12/+10
|\ | | | | Fix env toggling, improve error page styling
| * fix env toggling, improve error page stylingGosha Arinich2013-01-032-12/+10
| |
* | Merge pull request #8715 from goshakkk/refactor-mapperCarlos Antonio da Silva2013-01-031-9/+4
|\ \ | | | | | | Refactor Routing::Mapper#matches?
| * | refactor Routing::MapperGosha Arinich2013-01-031-9/+4
| |/
* | Explain the possible precautionsAndre Arko2013-01-021-3/+4
| |
* | Restore original remote_ip algorithm.Andre Arko2013-01-021-53/+112
|/ | | | | | | | | | | Proxy servers add X-Forwarded-For headers, resulting in a list of IPs. We remove trusted IP values, and then take the last given value, assuming that it is the most likely to be the correct, unfaked value. See [1] for a very thorough discussion of why that is the best option we have at the moment. [1]: http://blog.gingerlime.com/2012/rails-ip-spoofing-vulnerabilities-and-protection/ Fixes #7979
* Merge pull request #8697 from goshakkk/undupRafael Mendonça França2013-01-021-5/+3
|\ | | | | Remove another unnecessary dup
| * remove another unnecessary dupGosha Arinich2013-01-021-5/+3
| |
* | Merge pull request #8701 from senny/8700_double_slash_with_trailing_slashRafael Mendonça França2013-01-021-1/+5
|\ \ | | | | | | do not append a second slash when using `trailing_slash: true`
| * | do not append a second slash when usingYves Senn2013-01-021-1/+5
| |/
* | Fixing closing </p>Guillermo Iguaran2013-01-021-1/+1
| |
* | Fix a number of validation/style errors:Sam Ruby2013-01-022-8/+7
|/ | | | | | | | | | * <pre> is not allowed to be nested inside of <p> elements in HTML * Indentation of </p> doesn't match corresponding <p> * <p> element not explicitly closed * One more </div> than <div> In each case, the template was fixed to match how a HTML5 parser would "see" the resulting page.
* Merge pull request #8694 from goshakkk/undupCarlos Antonio da Silva2013-01-021-2/+1
|\ | | | | Remove unnecessary #dup
| * remove unnecessary #dupGosha Arinich2013-01-021-2/+1
| |
* | Merge pull request #8688 from goshakkk/error-page-toggleGuillermo Iguaran2013-01-021-3/+3
|\ \ | |/ |/| Allow toggling dumps on error page
| * allow toggling dumps instead of just showingGosha Arinich2013-01-021-3/+3
| |
* | Cleanup some unnecessary CSS on the new error page and reformat some lines.Lucas Mazza2013-01-021-12/+13
| |
* | add source line paddingGosha Arinich2013-01-021-0/+4
|/
* remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-021-1/+0
|
* Fix indent in UnknownAction templateGuillermo Iguaran2013-01-011-1/+1
|
* Summary and Details HTML elements aren't supported in all modern browsersGuillermo Iguaran2012-12-312-12/+12
|
* Add style to AV::Template::Error exception pageGuillermo Iguaran2012-12-312-14/+42
|
* Improve line-height to have better line spacing in exception messageGuillermo Iguaran2012-12-311-0/+1
|
* Add new style to Routing Error pageGuillermo Iguaran2012-12-311-19/+22
|
* Styling for exception pageGuillermo Iguaran2012-12-316-29/+150
|
* Add source extract to detailed exception pageGuillermo Iguaran2012-12-314-2/+34
|