Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | @_etag is not used anywhere. | José Valim | 2010-09-29 | 1 | -2/+0 | |
| | ||||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 4 | -3/+11 | |
| | | | | everyone calls super as expected. | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 10 | -16/+21 | |
|\ | ||||||
| * | Remove more warnings on AP. | Emilio Tagua | 2010-09-28 | 2 | -3/+4 | |
| | | ||||||
| * | Use redefine_method instead define_method, it may be already defined. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | | ||||||
| * | Remove method if exists, avoid calling Array#first so many times. | Emilio Tagua | 2010-09-28 | 1 | -3/+5 | |
| | | ||||||
| * | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @compiled_at if it is not. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 | |
| | | ||||||
| * | Remove warings from rescues: don't define more than once debug_hash method ↵ | Emilio Tagua | 2010-09-28 | 1 | -2/+2 | |
| | | | | | | | | and ask if @response if defined. | |||||
| * | Remove remaining warnings on _trace by adding parenthesis to gsub arguments. | Emilio Tagua | 2010-09-28 | 1 | -3/+3 | |
| | | ||||||
| * | Use parenthesis to avoid ambiguous first argument warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | | ||||||
| * | Avoid more uninitialized variable warnings. | Emilio Tagua | 2010-09-28 | 1 | -1/+2 | |
| | | ||||||
| * | @selected may not be defined here, avoid warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | | ||||||
| * | No need to call super here. Use yield instead block.call | Emilio Tagua | 2010-09-28 | 1 | -3/+2 | |
| | | ||||||
| * | Initialize @app if it doesn't exists. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 | |
| | | ||||||
| * | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-27 | 1 | -8/+2 | |
| | | ||||||
* | | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-28 | 1 | -8/+2 | |
| | | ||||||
* | | Fix tests on 1.9.2. | José Valim | 2010-09-28 | 1 | -5/+0 | |
| | | ||||||
* | | Properly initialize variables inside the initialize method. | José Valim | 2010-09-27 | 1 | -3/+8 | |
|/ | ||||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 2 | -2/+1 | |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 1 | -4/+2 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 8 | -35/+55 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | |||||
| * | _routes must be inside @controller conditional. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Refactor method to avoid warnings and not run unnecessary code. | Emilio Tagua | 2010-09-27 | 1 | -11/+11 | |
| | | ||||||
| * | Initialize @cookies. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 | |
| | | ||||||
| * | Don't shadow outer local variables. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Avoid uninitialized variable warning, reuse @integration_session. | Emilio Tagua | 2010-09-27 | 1 | -8/+14 | |
| | | ||||||
| * | Ask is @controller is defined to avoid warning. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
| * | Initialize @_routes if it doesn't exists. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove warning "too many arguments for format string" when interpolating ↵ | Emilio Tagua | 2010-09-27 | 1 | -1/+1 | |
| | | | | | | | | with empty hash. | |||||
| * | Initialize @_etag. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Initialize @as before plural method is called. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 | |
| | | ||||||
| * | Remove old method before redefining it. | Emilio Tagua | 2010-09-27 | 1 | -0/+2 | |
| | | ||||||
| * | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 2 | -11/+19 | |
| | | ||||||
* | | Convert unless/else into if/else. | thedarkone | 2010-09-27 | 1 | -4/+4 | |
| | | ||||||
* | | Hash#empty? is faster than Enumerable#any? when used on a Hash. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | options[:action] is very likely to be nil. | thedarkone | 2010-09-27 | 1 | -1/+1 | |
| | | ||||||
* | | Cache 2 of Request's commonly called methods. | thedarkone | 2010-09-27 | 1 | -2/+2 | |
| | | ||||||
* | | No need to create a separate lambda for each call. | thedarkone | 2010-09-27 | 1 | -15/+14 | |
|/ | ||||||
* | Fix the precedence issue here | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | Not need to do this double ternary | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 | |
| | ||||||
* | port is appended twice to HTTP_HOST when host already has the port | Santiago Pastorino | 2010-09-26 | 1 | -3/+3 | |
| | ||||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -2/+2 | |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | |||||
* | Don't duplicate Rack::Response functionality. [#5320 state:resolved] | John Firebaugh | 2010-09-25 | 1 | -18/+4 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Improve performance of applications using file uploads by not busting the ↵ | Carl Lerche | 2010-09-22 | 1 | -29/+20 | |
| | | | | method cache on every request containing a file upload. | |||||
* | fixing bug with rails use of rack-test | Aaron Patterson | 2010-09-22 | 1 | -2/+4 | |
| | ||||||
* | Refactor routing methods. | Emilio Tagua | 2010-09-22 | 2 | -11/+2 | |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Raise ArgumentError instead of normalizing controller name when there is a ↵ | Andrew White | 2010-09-18 | 1 | -1/+5 | |
| | | | | leading slash [#5651 state:resolved] |