aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #14619 from winston/enhance-routing-error-htmlRafael Mendonça França2014-04-111-63/+119
|\ | | | | | | Enhance routing error html page
| * Split search results into 'exact matches' and 'fuzzy matches'.Winston2014-04-111-60/+96
| | | | | | | | - also refactored the javascript.
| * Improve CSS styling for routing error html page.Winston2014-04-111-7/+25
| |
| * Implement fuzzy matching for route search on routing error html page.Winston2014-04-111-8/+10
| |
* | Only make deeply nested routes shallow when parent is shallowAndrew White2014-04-111-1/+14
|/ | | | | | | | | | Since `:shallow` may be set at any point in the resource nesting we should only make the new and collection routes shallow when the parent is shallow. This is a bit of a hack but until the mapper is refactored to an object graph instead of a hash of merged values it's the best we can do. Fixes #14684.
* Avoid URI parsingAndriel Nuernberg2014-04-091-5/+8
| | | | | This parsing is unecessary once the Request object already has the needed information.
* push move_string in to `move`Aaron Patterson2014-04-011-14/+12
|
* combine move_regexp and move_string so we only loop over states onceAaron Patterson2014-04-011-9/+6
|
* do not create memo objects since we'll just throw them awayAaron Patterson2014-04-012-9/+11
|
* only ask if `t` is empty once.Aaron Patterson2014-04-011-4/+1
|
* Merge pull request #13890 from achempion/syntax-error-backtraceYves Senn2014-03-291-0/+8
|\ | | | | append link to bad code when error type is SyntaxError
| * Append link to bad code to backtrace when exception is SyntaxErrorBoris Kuznetsov2014-03-271-0/+8
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-291-0/+4
|\ \
| * | Mention required glob param name in match docs for mapperEarl St Sauver2014-03-201-0/+4
| | | | | | | | | | | | | | | | | | | | | THe match documentation doesn't mention any requirement of the parameter name requirement for matches. However, including a bare glob character without a variable assignment causes a parse error.
* | | Replace trivial regexp with string or index, twice as fastKelley Reynolds2014-03-281-1/+1
| |/ |/|
* | Swapped parameters of assert_equal in assert_selectVishal Lal2014-03-221-1/+1
| |
* | The digest option is no longer honoured since Rails 3.0 [ci skip]Godfrey Chan2014-03-201-1/+1
| | | | | | | | Closes #8513
* | Use nested_scope? not shallow? to determine whether to copy optionsAndrew White2014-03-161-1/+5
| | | | | | | | | | | | | | | | The method `shallow?` returns false if the parent resource is a singleton so we need to check if we're not inside a nested scope before copying the :path and :as options to their shallow equivalents. Fixes #14388.
* | use the body proxy to freeze headersAaron Patterson2014-03-121-5/+32
| | | | | | | | | | | | avoid freezing the headers until the web server has actually read data from the body proxy. Once the webserver has read data, then we should throw an error if someone tries to set a header
* | only write the jar if the response isn't committedAaron Patterson2014-03-122-5/+20
| | | | | | | | | | | | | | | | | | | | | | when streaming responses, we need to make sure the cookie jar is written to the headers before returning up the stack. This commit introduces a new method on the response object that writes the cookie jar to the headers as the response is committed. The middleware and test framework will not write the cookie headers if the response has already been committed. fixes #14352
* | Merge pull request #14291 from laurocaetano/doc-for-original-fullpathYves Senn2014-03-121-0/+7
|\ \ | | | | | | Add documentation for original_fullpath. [ci skip]
| * | [ci skip] Add documentation for original_fullpath.Lauro Caetano2014-03-111-0/+7
| | |
* | | Merge pull request #14262 from sferik/flat_mapAndrew White2014-03-097-18/+18
|\ \ \ | | | | | | | | Replace additional instances of map.flatten with flat_map
| * | | Replace map.flatten with flat_map in actionpackErik Michaels-Ober2014-03-037-18/+18
| |/ /
* | | Copy shallow options from normal options when using scopeAndrew White2014-03-081-1/+2
| | | | | | | | | | | | | | | | | | If the options :shallow_prefix and :shallow_path are not set in the scope options then copy them from the normal :as and :path options if they are set.
* | | Pull namespace defaults out of the options hashAndrew White2014-03-081-3/+10
| | | | | | | | | | | | | | | | | | | | | If a developer has specified either :path or :as in the options hash then these should be used as the defaults for :shallow_path and :shallow_prefix. Fixes #14241.
* | | Only use shallow nested scope when depth is > 1Andrew White2014-03-081-20/+23
| | | | | | | | | | | | | | | | | | | | | | | | By tracking the depth of resource nesting we can push the need for nested shallow scoping to only those routes that are nested more than one deep. This allows us to keep the fix for #12498 and fix the regression in #14224. Fixes #14224.
* | | Move setting :scope_level_resource to resource_scopeAndrew White2014-03-081-7/+7
| |/ |/| | | | | | | | | | | | | Originally with_scope_level was exclusively for managing scope levels with resources, however it is now used for other things so it makes more sense to move the responsibility for setting the :scope_level_resource to the resource_scope method. This eliminates repeatedly setting it to the same resource as each resource method scope is evaluated.
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-071-1/+1
|\ \ | | | | | | | | | | | | Conflicts: guides/source/4_1_release_notes.md
| * | :scissors:Zachary Scott2014-02-231-1/+1
| | | | | | | | | | | | This commit also addresses rails/docrails#169 and rails/rails#14159
* | | Do note remove `Content-Type` when `render :body`Prem Sichanugrist2014-03-051-12/+1
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | `render :body` should just not set the `Content-Type` header. By removing the header, it breaks the compatibility with other parts. After this commit, `render :body` will returns `text/html` content type, sets by default from `ActionDispatch::Response`, and it will preserve the overridden content type if you override it. Fixes #14197, #14238 This partially reverts commit 3047376870d4a7adc7ff15c3cb4852e073c8f1da.
* | Replace map.flatten(1) with flat_mapErik Michaels-Ober2014-02-282-5/+5
|/
* Add `#no_content_type` attribute to `AD::Response`Prem Sichanugrist2014-02-181-2/+13
| | | | | Setting this attribute to `true` will remove the content type header from the request. This is use in `render :body` feature.
* Introduce `render :body` for render raw contentPrem Sichanugrist2014-02-181-1/+1
| | | | | | | | | | | | This is an option for sending a raw content back to browser. Note that this rendering option will unset the default content type and does not include "Content-Type" header back in the response. You should only use this option if you are expecting the "Content-Type" header to not be set. More information on "Content-Type" header can be found on RFC 2616, section 7.2.1. Please see #12374 for more detail.
* Fix parameter naming in RemoteIp middleware constructor methodKalabiYau2014-02-181-2/+2
| | | | | Was custom_proxies in inline docs, but should be and defined in constructor as custom_proxies
* Check if variant array contains only symbolsŁukasz Strzałkowski2014-02-131-2/+2
|
* Variant negotiationLukasz Strzalkowski2014-02-131-2/+4
| | | | | | | | | | | | | | Allow setting `request.variant` as an array - an order in which they will be rendered. For example: request.variant = [:tablet, :phone] respond_to do |format| format.html.none format.html.phone # this gets rendered end
* rm warning about variable shadowingGodfrey Chan2014-02-111-2/+2
|
* Migrate hash-based cookie values correctlyGodfrey Chan2014-02-111-2/+4
|
* Missed FlashHash#replaceGodfrey Chan2014-02-111-1/+1
|
* Fixed broken flash testsGodfrey Chan2014-02-111-1/+1
|
* Re-write legacy (marshal) cookies on readGodfrey Chan2014-02-111-20/+40
|
* Stringify the incoming hash in FlashHashGuillermo Iguaran2014-02-111-1/+3
| | | | | Stringify the incoming as well to handle incoming symbol keys from marshalled sessions
* Convert FlashHash in a Hash with indifferent accessGuillermo Iguaran2014-02-111-4/+15
|
* Added HybridSerializer to upgrade existing marshal cookies (wip: need tests)Godfrey Chan2014-02-111-0/+14
|
* Renamed session_serializer option to cookies_serializerGodfrey Chan2014-02-113-42/+30
|
* Set the :shallow_path as each scope is generatedAndrew White2014-02-091-1/+12
| | | | | | | | | | | | | | | | If we set :shallow_path when shallow is called it can result in incorrect paths if the resource is inside a namespace because namespace itself sets the :shallow_path option to the namespace path. We fix this by removing the :shallow_path option from shallow as that should only be turning shallow routes on and not otherwise affecting the scope. To do this we need to treat the :shallow option to resources differently to other scope options and move it to before the nested block is called. This change also has the positive side effect of making the behavior of the :shallow option consistent with the shallow method. Fixes #12498.
* Prevent [response].flatten from recursing infinitely.Dan Kang2014-02-081-1/+1
| | | | | | Returning `self` from within the array returned by `to_ary` caused this. Instead, we can just substitute another object. It provides the `each` behavior required by the rack spec.
* Updated the cookie docs to use the safer JSON.{generate,parse}Godfrey Chan2014-02-081-5/+5
| | | | cc @senny
* Rely on backticks instead of tt tags [ci skip]Robin Dupret2014-02-081-2/+2
| | | | | Since the language in code blocks is inferred, if the code contains tt tags, the block will be parsed as XML for instance while it is Ruby.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 03:10:25 +0000