aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Fix bug where cookies mutated by request were not persistedeileencodes2015-09-011-0/+7
| | | | | | | | | | | | | | | With changes made in 8363b8 and ae29142 cookies that are mutated on the request like `cookies.signed = x` were not retained in subsequent tests, breaking cookie authentiation in controller tests. The test added demonstrates the issue. The reason we need to select from non-deleted cookies is because without checking the `@delete_cookies` the `cookie_jar` `@cookies` will send the wrong cookies to be updated. The code must check for `@deleted_cookies` before sending an `#update` with the requests cookie_jar cookies. This follows how the cookie_jar cookies from the request were updated before these changes.
* Merge pull request #19788 from cmdrclueless/actionpack_http_url_ipv6Rafael Mendonça França2015-09-011-1/+1
|\ | | | | Fix broken IPv6 addresses handling
| * Fix broken IPv6 addresses handlingBrian Weaver2015-04-161-1/+1
| |
* | add a method for getting the http auth saltAaron Patterson2015-08-291-0/+4
| |
* | Merge pull request #21396 from rodzyn/code-cleanupGuillermo Iguaran2015-08-282-13/+2
|\ \ | | | | | | Code cleanup
| * | Code cleanupMarcin Olichwirowicz2015-08-272-13/+2
| | | | | | | | | | | | | | | | | | | | | | | | Cleanup for `ActionDispatch::Http::Parameters` - no need for required libraries and remove not used private method. Apparently this method was used in `ActionDispatch::Http::Request` - fixed by calling `Request::Utils` explicitly (as was done in other parts of the codebase)
* | | remove dependency on `@cache_control` ivarAaron Patterson2015-08-271-6/+6
| | | | | | | | | | | | | | | eventually we'll remove this instance variable, but this is the first step
* | | remove `@etag` ivarAaron Patterson2015-08-271-5/+7
| | | | | | | | | | | | | | | we're storing the value in the headers hash, so lets just store the value in one place.
* | | use the abstract API in modulesAaron Patterson2015-08-272-14/+15
| | | | | | | | | | | | | | | Modules should be using the API that the abstract modules use so that we can move these modules between implementations
* | | remove useless conditionalAaron Patterson2015-08-271-2/+0
| | | | | | | | | | | | | | | cookies are always stored as a string in the header hash, so it will not need to be joined.
* | | implement the API required by the abstract Rack request.Aaron Patterson2015-08-271-16/+8
| | |
* | | use the non-hash dependent Rack utils APIAaron Patterson2015-08-271-2/+2
|/ / | | | | | | eventually we will refactor this to not know about header hashes
* | remove redefined methodAaron Patterson2015-08-261-3/+0
| | | | | | | | | | Rack::Response::Helpers implements this method, so we can safely remove it
* | provide a request and response to all controllersAaron Patterson2015-08-252-5/+8
| | | | | | | | | | | | | | | | | | | | Controllers should always have a request and response when responding. Since we make this The Rule(tm), then controllers don't need to be somewhere in limbo between "asking a response object for a rack response" or "I, myself contain a rack response". This duality leads to conditionals spread through the codebase that we can delete: * https://github.com/rails/rails/blob/85a78d9358aa728298cd020cdc842b55c16f9549/actionpack/lib/action_controller/metal.rb#L221-L223
* | adding a direct dispatch method to controller classesAaron Patterson2015-08-251-1/+1
| | | | | | | | This saves a lambda and request allocation on each request.
* | always dispatch to controllers the same wayAaron Patterson2015-08-252-7/+25
| | | | | | | | | | controllers should always go through the `action` class method so that their middleware is respected.
* | always return a controller class from the `controller_class` methodAaron Patterson2015-08-252-9/+14
| | | | | | | | | | now the caller can just treat it like a regular controller even though it will return a 404
* | Remove unused requiresMarcin Olichwirowicz2015-08-251-2/+0
| | | | | | | | They are already required in `actionpack/lib/action_dispatch.rb` (L25-L26)
* | Make `assert_index` privateMarcin Olichwirowicz2015-08-251-3/+1
| | | | | | | | | | This `protected` keyword looks like some leftover, since we are not using explicit receiver, this should go under `private`
* | Remove unused block argumentsAnshul Sharma2015-08-251-1/+1
| |
* | Remove unused block argumentsamitkumarsuroliya2015-08-251-1/+1
| |
* | remove another `@env` accessAaron Patterson2015-08-241-1/+1
| |
* | remove more direct access to `env`Aaron Patterson2015-08-242-3/+4
| |
* | fewer calls to `env`Aaron Patterson2015-08-241-2/+2
| | | | | | | | We don't want to directly access the env hash
* | stop using `@env` in the GET / POST methodsAaron Patterson2015-08-242-4/+11
| | | | | | | | | | I want to implement this with something besides `@env` in the future, so lets stop directly referencing it.
* | pull up dispatcher allocationAaron Patterson2015-08-242-5/+1
| | | | | | | | | | the dispatcher class isn't configurable anymore, so pull up allocation to the method that needs it.
* | directly ask the request for the controller classAaron Patterson2015-08-241-6/+1
| | | | | | | | | | | | Now that we don't have subclasses depending on this method (they augment the request class instead of the dispatch class) we can remove this method and directly ask the request object for the controller class
* | remove useless ivarAaron Patterson2015-08-241-2/+1
| |
* | remove setter for the dispatcher classAaron Patterson2015-08-241-2/+2
| | | | | | | | we don't need it anymore. We always use the same dispatcher in tests.
* | use a custom request class to determine the controller classAaron Patterson2015-08-241-2/+7
| | | | | | | | | | | | controller class resolution has been moved to the request object, so we should override that method instead of relying on the RouteSet to generate the controller class.
* | Merge pull request #21339 from deepj/unused-block-argumentsCarlos Antonio da Silva2015-08-241-2/+2
|\ \ | | | | | | Remove unused block arguments
| * | Remove unused block argumentsdeepj2015-08-231-2/+2
| | |
* | | use methods on the request object instead of accessing envAaron Patterson2015-08-231-7/+7
| | |
* | | use `Request#path_info` instead of direct ENV accessAaron Patterson2015-08-231-1/+1
| | | | | | | | | | | | | | | we already have a request, so we should use the methods on the request to access the path info information
* | | remove env access from debug_exceptionsAaron Patterson2015-08-231-10/+9
| | | | | | | | | | | | Creates fewer request objects and helps to abstract away from internals
* | | convert more `@env` access to get / set headerAaron Patterson2015-08-231-11/+13
| | |
* | | remove usage of `@env`Aaron Patterson2015-08-231-3/+5
|/ / | | | | | | | | try to remove dependencies on `@env` so we can have more flexible internals
* | use a request object in the session middlewareAaron Patterson2015-08-225-46/+50
| | | | | | | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
* | move more `@env` access to method callsAaron Patterson2015-08-221-16/+16
| | | | | | | | | | We're going to implement storing env values differently in the future, so let's disconnect these methods from the instance variables
* | move ORIGINAL_SCRIPT_NAME to the metaprogrammed methodsAaron Patterson2015-08-221-4/+1
| |
* | metaprogram the HTTP_X_REQUEST_ID methodAaron Patterson2015-08-221-6/+1
| | | | | | | | we're already doing this with a bunch of other header data.
* | use `body_stream` instead of getting the env value ourselvesAaron Patterson2015-08-221-1/+1
| | | | | | | | we have a method that knows how to get rack.input, so lets use that.
* | convert `@env` use to get / set headerAaron Patterson2015-08-221-16/+16
| | | | | | | | | | | | We need to abstract the internals of the request object away from this instance variable so that the values for `@env` can be calculated in a different way.
* | use get / set header to avoid depending on the `env` ivarAaron Patterson2015-08-221-11/+14
| |
* | Fix Railties test failure for asset routeseileencodes2015-08-221-1/+5
| | | | | | | | | | | | | | | | | | Since none of the action pack tests failed without this conditional it didn't seem necessary. This fixes the build because it correctly returns a 404 instead of a 500 for the asset routes test. Test that was failing was in the `assets_test.rb` file and was the test named `test_assets_routes_are_not_drawn_when_compilation_is_disabled`.
* | Refactor to remove controller class from route to requesteileencodes2015-08-222-40/+20
| | | | | | | | | | | | | | | | | | | | This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
* | set cached values in the env hashAaron Patterson2015-08-211-6/+9
| |
* | stop directly accessing `@env` in mime_negotiationAaron Patterson2015-08-211-8/+8
| | | | | | | | | | we want to go through methods to access `env` because in the future that ivar may not be available, or may be calculated lazily
* | use public API to fetch the parameter filterAaron Patterson2015-08-211-2/+2
| | | | | | | | | | now the parameter filter doesn't need to know about the env hash in these two methds.
* | use methods on the request object to implement `fetch`Aaron Patterson2015-08-211-2/+8
| | | | | | | | Now the Headers internals don't depend on the env hash.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 12:01:40 +0000