Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | make sure request parameters are accessible after rack throws an exception ↵ | Miles Egan | 2010-10-12 | 1 | -2/+2 |
| | | | | | | parsing the query string [#3030 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor resource action scope methods | Andrew White | 2010-10-08 | 1 | -38/+20 |
| | |||||
* | only forwarding enough methods to work. People should grab the delegate ↵ | Aaron Patterson | 2010-10-04 | 1 | -5/+8 |
| | | | | tempfile if they really need to do hard work | ||||
* | making sure respond_to? works properly | Aaron Patterson | 2010-10-04 | 1 | -0/+5 |
| | |||||
* | raising an argument error if tempfile is not provided | Aaron Patterson | 2010-10-04 | 1 | -0/+1 |
| | |||||
* | delegate to the @tempfile instance variable | Aaron Patterson | 2010-10-04 | 1 | -13/+5 |
| | |||||
* | avoid method call to compact | Aaron Patterson | 2010-10-04 | 1 | -4/+4 |
| | |||||
* | Ensure the proper content type is returned for static files. | José Valim | 2010-10-04 | 1 | -3/+3 |
| | |||||
* | Initialize sid should just skip instance variables. | José Valim | 2010-10-04 | 1 | -0/+7 |
| | |||||
* | Solve some warnings and a failing test. | José Valim | 2010-10-03 | 1 | -1/+1 |
| | |||||
* | Move ETag and ConditionalGet logic from AD::Response to the middleware stack. | José Valim | 2010-10-03 | 2 | -22/+2 |
| | |||||
* | Rely on Rack::Session stores API for more compatibility across the Ruby world. | José Valim | 2010-10-03 | 4 | -326/+76 |
| | |||||
* | removing AS::Testing::Default in favor of just undefing default_test | Aaron Patterson | 2010-10-01 | 1 | -2/+1 |
| | |||||
* | Properly reload routes defined in class definition | Piotr Sarnacki | 2010-09-30 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | Sometimes it's easier to define routes inside Engine or Application class definition (e.g. one file applications). The problem with such case is that if there is a plugin that has config/routes.rb file, it will trigger routes reload on application. Since routes definition for application is not in config/routes.rb file routes_reloader will fail to reload application's routes properly. With this commit you can pass routes definition as a block to routes method, which will allow to properly reload it: class MyApp::Application < Rails::Application routes do resources :users end end | ||||
* | Allow mounting engines at '/' | Piotr Sarnacki | 2010-09-30 | 1 | -1/+1 |
| | | | | | Without that commit script_name always become '/', which results in paths like //posts/1 instead of /posts/1 | ||||
* | Use .find here as it is simpler and faster. | José Valim | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | avoid creating a block if possible | Aaron Patterson | 2010-09-29 | 1 | -2/+2 |
| | |||||
* | fixing regexp warnings | Aaron Patterson | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | no need to check for nil? | Neeraj Singh | 2010-09-30 | 1 | -1/+1 |
| | |||||
* | dry up method checking in the request object | Aaron Patterson | 2010-09-29 | 1 | -10/+9 |
| | |||||
* | _ is not a valid scheme name character, \w includes it and also is redundant ↵ | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | | | | | | with \d. 'The scheme name consists of a letter followed by any combination of letters, digits, and the plus ("+"), period ("."), or hyphen ("-") characters; and is terminated by a colon (":").' | ||||
* | Remove redundant conditional. | Emilio Tagua | 2010-09-29 | 1 | -5/+1 |
| | |||||
* | Don't try to interpolate string if there's no interpolation point at all. | Emilio Tagua | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | Ensure that named routes do not overwrite previously defined routes. | José Valim | 2010-09-29 | 1 | -10/+13 |
| | |||||
* | Fix an error on 1.8.7. | José Valim | 2010-09-29 | 1 | -1/+1 |
| | |||||
* | @_etag is not used anywhere. | José Valim | 2010-09-29 | 1 | -2/+0 |
| | |||||
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 4 | -3/+11 |
| | | | | everyone calls super as expected. | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-29 | 10 | -16/+21 |
|\ | |||||
| * | Remove more warnings on AP. | Emilio Tagua | 2010-09-28 | 2 | -3/+4 |
| | | |||||
| * | Use redefine_method instead define_method, it may be already defined. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Remove method if exists, avoid calling Array#first so many times. | Emilio Tagua | 2010-09-28 | 1 | -3/+5 |
| | | |||||
| * | Remove more warnings on variables. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | |||||
| * | Initialize @compiled_at if it is not. | Emilio Tagua | 2010-09-28 | 1 | -0/+1 |
| | | |||||
| * | Remove warings from rescues: don't define more than once debug_hash method ↵ | Emilio Tagua | 2010-09-28 | 1 | -2/+2 |
| | | | | | | | | and ask if @response if defined. | ||||
| * | Remove remaining warnings on _trace by adding parenthesis to gsub arguments. | Emilio Tagua | 2010-09-28 | 1 | -3/+3 |
| | | |||||
| * | Use parenthesis to avoid ambiguous first argument warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Avoid more uninitialized variable warnings. | Emilio Tagua | 2010-09-28 | 1 | -1/+2 |
| | | |||||
| * | @selected may not be defined here, avoid warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | No need to call super here. Use yield instead block.call | Emilio Tagua | 2010-09-28 | 1 | -3/+2 |
| | | |||||
| * | Initialize @app if it doesn't exists. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | | |||||
| * | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-27 | 1 | -8/+2 |
| | | |||||
* | | Move uri parser to AS as URI.parser method to reuse it in AP and ARes. | Emilio Tagua | 2010-09-28 | 1 | -8/+2 |
| | | |||||
* | | Fix tests on 1.9.2. | José Valim | 2010-09-28 | 1 | -5/+0 |
| | | |||||
* | | Properly initialize variables inside the initialize method. | José Valim | 2010-09-27 | 1 | -3/+8 |
|/ | |||||
* | Define @_routes inside method, makes more sense and will be initialized when ↵ | Emilio Tagua | 2010-09-27 | 2 | -2/+1 |
| | | | | | | called anywhere. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove warning "URI.unescape is obsolete" from actionpack. | Emilio Tagua | 2010-09-27 | 1 | -4/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge remote branch 'miloops/warnings' | José Valim | 2010-09-27 | 8 | -35/+55 |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb | ||||
| * | _routes must be inside @controller conditional. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | | |||||
| * | Refactor method to avoid warnings and not run unnecessary code. | Emilio Tagua | 2010-09-27 | 1 | -11/+11 |
| | |