Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #6131 from schneems/schneems/routes_backtrace | Santiago Pastorino | 2012-05-02 | 1 | -1/+3 |
|\ | | | | | Add backtrace to development routing error page | ||||
| * | Add backtrace to development routing error page | schneems | 2012-05-02 | 1 | -1/+3 |
| | | | | | | | | | | | | If a user gets a routing error due to a view helper such as using user_path without an :id they must go to their logs to see the backtrace. By adding in the trace template, a user can see which line the error occurred on without leaving the browser. When a routing error occurs outside of the view the application trace will be blank and will not confuse developers. | ||||
* | | Reset the request parameters after a constraints check | Andrew White | 2012-05-02 | 2 | -0/+6 |
|/ | | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510. | ||||
* | Merge pull request #6122 from amerine/add_fetch_to_actiondispatch_http_headers | Aaron Patterson | 2012-05-02 | 1 | -7/+8 |
|\ | | | | | Enable ActionDispatch::Http::Headers to support fetch | ||||
| * | Enable ActionDispatch::Http::Headers to support fetch | Mark Turner | 2012-05-02 | 1 | -7/+8 |
| | | |||||
* | | * move exception message to exception constructor | Aaron Patterson | 2012-05-02 | 1 | -5/+11 |
|/ | | | | | * save original exception * keep original backtrace | ||||
* | ActionPack routes: remove some useless code. | Bogdan Gusiev | 2012-05-02 | 1 | -26/+4 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-01 | 4 | -17/+15 |
|\ | |||||
| * | Fix rdoc formatting in Mime::Type | Mark Rushakoff | 2012-04-29 | 1 | -5/+5 |
| | | |||||
| * | Reword polymorphic routes + mounted engine rdoc | Mark Rushakoff | 2012-04-29 | 1 | -8/+6 |
| | | | | | | | | Also correctly indent its example code. | ||||
| * | Code-format references to config settings | Mark Rushakoff | 2012-04-27 | 2 | -2/+2 |
| | | |||||
| * | More using <tt>x</tt> instead of +x+ when the latter renders improperly. | Mark Rushakoff | 2012-04-27 | 1 | -2/+2 |
| | | |||||
* | | Merge pull request #6084 from brainopia/support_for_magic_domain_on_all_stores | José Valim | 2012-04-30 | 1 | -0/+7 |
|\ \ | | | | | | | Support cookie jar options for all cookie stores | ||||
| * | | Support cookie jar options for all cookie stores | brainopia | 2012-04-30 | 1 | -0/+7 |
| |/ | |||||
* | | Merge pull request #6082 from brainopia/smarter_cookie_jar | José Valim | 2012-04-30 | 1 | -7/+10 |
|\ \ | | | | | | | Stream cookies only if needed | ||||
| * | | Dont stream back cookie value if it was set to the same value | brainopia | 2012-04-30 | 1 | -4/+6 |
| | | | |||||
| * | | Dont set cookie header for deletion of unexisting data | brainopia | 2012-04-30 | 1 | -1/+2 |
| | | | |||||
| * | | Simplify matching with array of possible domains | brainopia | 2012-04-30 | 1 | -1/+1 |
| | | | |||||
| * | | Use more appropriate one-liner for class declaration | brainopia | 2012-04-30 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #6083 from brainopia/remove_unused_closed_ivars | José Valim | 2012-04-30 | 2 | -2/+0 |
|\ \ \ | |/ / |/| | | Remove a couple of unused ivars left from previous refactoring | ||||
| * | | Remove unused ivars left from close checks | brainopia | 2012-04-30 | 2 | -2/+0 |
| |/ | | | | | | | These ivars were missed in d142572567 when close checks were removed | ||||
* | | Merge pull request #6034 from ↵ | Piotr Sarnacki | 2012-04-30 | 1 | -6/+3 |
|\ \ | | | | | | | | | | | | | willbryant/flash_must_not_load_session_on_every_request_master Fix the Flash middleware loading the session on every request | ||||
| * | | fix the Flash middleware loading the session on every request (very ↵ | Will Bryant | 2012-04-28 | 1 | -6/+3 |
| |/ | | | | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called | ||||
* | | Merge pull request #6074 from mark-rushakoff/unused-variables | Jeremy Kemper | 2012-04-29 | 1 | -1/+0 |
|\ \ | | | | | | | Remove some unused variable assignments | ||||
| * | | Remove unused assignments | Mark Rushakoff | 2012-04-29 | 1 | -1/+0 |
| |/ | |||||
* | | Restore interpolation of path option in redirect routes | Andrew White | 2012-04-29 | 1 | -0/+10 |
| | | |||||
* | | Escape interpolated params when redirecting - fixes #5688 | Andrew White | 2012-04-29 | 1 | -1/+7 |
|/ | |||||
* | Shadowing variable warning removed | Arun Agrawal | 2012-04-26 | 1 | -3/+3 |
| | |||||
* | Allow loading external route files from the router | Jose and Yehuda | 2012-04-25 | 2 | -0/+18 |
| | | | | | | | | | This feature enables the ability to load an external routes file from the router via: draw :filename External routes files go in +config/routes+. This feature works in both engines and applications. | ||||
* | Merge pull request #5980 from gazay/valid_ips | Jeremy Kemper | 2012-04-25 | 1 | -22/+68 |
|\ | | | | | Remote ip logic and validation. IPv6 support. | ||||
| * | Valid ips v4 and v6. Right logic for working with X-FORWARDED-FOR header and ↵ | Alexey Gaziev | 2012-04-25 | 1 | -22/+68 |
| | | | | | | | | tests. | ||||
* | | Remove unnecessary empty line | José Valim | 2012-04-25 | 1 | -1/+0 |
| | | |||||
* | | Remove default match without specified method | Jose and Yehuda | 2012-04-24 | 1 | -2/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964 | ||||
* | | Merge pull request #5961 from bogdan/routes | Jeremy Kemper | 2012-04-24 | 1 | -20/+26 |
|\ \ | | | | | | | Refactor ActionDispatch::HTTP::Url#url_for | ||||
| * | | ActionDispatch::HTTP::Url#url_for refactor method | Bogdan Gusiev | 2012-04-24 | 1 | -20/+26 |
| | | | | | | | | | | | | | | | Separated right side url generation(before query string) from left side url generation(after query string) | ||||
* | | | Refactor hash creation in routeset | Carlos Antonio da Silva | 2012-04-24 | 1 | -3/+4 |
|/ / | |||||
* | | RouteSet: decomplecting a way to handle positional args | Bogdan Gusiev | 2012-04-24 | 1 | -26/+20 |
| | | |||||
* | | RouteSet: simplify routes helpers generation code | Bogdan Gusiev | 2012-04-24 | 1 | -13/+21 |
| | | |||||
* | | Add missing requires in routes | Bogdan Gusiev | 2012-04-23 | 2 | -0/+3 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-21 | 1 | -2/+2 |
|\ | |||||
| * | Fix formatting | Oscar Del Ben | 2012-04-18 | 1 | -2/+2 |
| | | |||||
* | | Freeze the middleware stack after it's built | Jeremy Kemper | 2012-04-20 | 1 | -1/+1 |
|/ | | | | | | So apps that accidentally add middlewares later aren't unwittingly dumping them in a black hole. Closes #5911 | ||||
* | let's keep the slash in the return value instead of the path variable [ci skip] | Vijay Dev | 2012-04-18 | 1 | -2/+2 |
| | |||||
* | Warn about do end syntax in redirect option | Oscar Del Ben | 2012-04-17 | 1 | -0/+3 |
| | |||||
* | Fix redirect with block example | Alexey Vakhov | 2012-04-17 | 1 | -3/+3 |
| | |||||
* | Fix example in flash middleware | Alexey Vakhov | 2012-04-17 | 1 | -1/+1 |
| | |||||
* | Fix comment in AD http response | Alexey Vakhov | 2012-04-13 | 1 | -1/+1 |
| | | | | response in integration test accessible without @ via attr_reader | ||||
* | Revert "Merge pull request #5750 from ahoward/master" | Santiago Pastorino | 2012-04-08 | 1 | -10/+1 |
| | | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement. | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-07 | 1 | -1/+1 |
|\ | |||||
| * | Fix example action dispatch in mime type | Alexey Vakhov | 2012-04-07 | 1 | -1/+1 |
| | |