aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #6131 from schneems/schneems/routes_backtraceSantiago Pastorino2012-05-021-1/+3
|\ | | | | Add backtrace to development routing error page
| * Add backtrace to development routing error pageschneems2012-05-021-1/+3
| | | | | | | | | | | | If a user gets a routing error due to a view helper such as using user_path without an :id they must go to their logs to see the backtrace. By adding in the trace template, a user can see which line the error occurred on without leaving the browser. When a routing error occurs outside of the view the application trace will be blank and will not confuse developers.
* | Reset the request parameters after a constraints checkAndrew White2012-05-022-0/+6
|/ | | | | | | | | | | | | A callable object passed as a constraint for a route may access the request parameters as part of its check. This causes the combined parameters hash to be cached in the environment hash. If the constraint fails then any subsequent access of the request parameters will be against that stale hash. To fix this we delete the cache after every call to `matches?`. This may have a negative performance impact if the contraint wraps a large number of routes as the parameters hash is built by merging GET, POST and path parameters. Fixes #2510.
* Merge pull request #6122 from amerine/add_fetch_to_actiondispatch_http_headersAaron Patterson2012-05-021-7/+8
|\ | | | | Enable ActionDispatch::Http::Headers to support fetch
| * Enable ActionDispatch::Http::Headers to support fetchMark Turner2012-05-021-7/+8
| |
* | * move exception message to exception constructorAaron Patterson2012-05-021-5/+11
|/ | | | | * save original exception * keep original backtrace
* ActionPack routes: remove some useless code.Bogdan Gusiev2012-05-021-26/+4
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-014-17/+15
|\
| * Fix rdoc formatting in Mime::TypeMark Rushakoff2012-04-291-5/+5
| |
| * Reword polymorphic routes + mounted engine rdocMark Rushakoff2012-04-291-8/+6
| | | | | | | | Also correctly indent its example code.
| * Code-format references to config settingsMark Rushakoff2012-04-272-2/+2
| |
| * More using <tt>x</tt> instead of +x+ when the latter renders improperly.Mark Rushakoff2012-04-271-2/+2
| |
* | Merge pull request #6084 from brainopia/support_for_magic_domain_on_all_storesJosé Valim2012-04-301-0/+7
|\ \ | | | | | | Support cookie jar options for all cookie stores
| * | Support cookie jar options for all cookie storesbrainopia2012-04-301-0/+7
| |/
* | Merge pull request #6082 from brainopia/smarter_cookie_jarJosé Valim2012-04-301-7/+10
|\ \ | | | | | | Stream cookies only if needed
| * | Dont stream back cookie value if it was set to the same valuebrainopia2012-04-301-4/+6
| | |
| * | Dont set cookie header for deletion of unexisting databrainopia2012-04-301-1/+2
| | |
| * | Simplify matching with array of possible domainsbrainopia2012-04-301-1/+1
| | |
| * | Use more appropriate one-liner for class declarationbrainopia2012-04-301-1/+1
| | |
* | | Merge pull request #6083 from brainopia/remove_unused_closed_ivarsJosé Valim2012-04-302-2/+0
|\ \ \ | |/ / |/| | Remove a couple of unused ivars left from previous refactoring
| * | Remove unused ivars left from close checksbrainopia2012-04-302-2/+0
| |/ | | | | | | These ivars were missed in d142572567 when close checks were removed
* | Merge pull request #6034 from ↵Piotr Sarnacki2012-04-301-6/+3
|\ \ | | | | | | | | | | | | willbryant/flash_must_not_load_session_on_every_request_master Fix the Flash middleware loading the session on every request
| * | fix the Flash middleware loading the session on every request (very ↵Will Bryant2012-04-281-6/+3
| |/ | | | | | | dangerous especially with Rack::Cache), it should only be loaded when the flash method is called
* | Merge pull request #6074 from mark-rushakoff/unused-variablesJeremy Kemper2012-04-291-1/+0
|\ \ | | | | | | Remove some unused variable assignments
| * | Remove unused assignmentsMark Rushakoff2012-04-291-1/+0
| |/
* | Restore interpolation of path option in redirect routesAndrew White2012-04-291-0/+10
| |
* | Escape interpolated params when redirecting - fixes #5688Andrew White2012-04-291-1/+7
|/
* Shadowing variable warning removedArun Agrawal2012-04-261-3/+3
|
* Allow loading external route files from the routerJose and Yehuda2012-04-252-0/+18
| | | | | | | | | This feature enables the ability to load an external routes file from the router via: draw :filename External routes files go in +config/routes+. This feature works in both engines and applications.
* Merge pull request #5980 from gazay/valid_ipsJeremy Kemper2012-04-251-22/+68
|\ | | | | Remote ip logic and validation. IPv6 support.
| * Valid ips v4 and v6. Right logic for working with X-FORWARDED-FOR header and ↵Alexey Gaziev2012-04-251-22/+68
| | | | | | | | tests.
* | Remove unnecessary empty line José Valim2012-04-251-1/+0
| |
* | Remove default match without specified methodJose and Yehuda2012-04-241-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964
* | Merge pull request #5961 from bogdan/routesJeremy Kemper2012-04-241-20/+26
|\ \ | | | | | | Refactor ActionDispatch::HTTP::Url#url_for
| * | ActionDispatch::HTTP::Url#url_for refactor methodBogdan Gusiev2012-04-241-20/+26
| | | | | | | | | | | | | | | Separated right side url generation(before query string) from left side url generation(after query string)
* | | Refactor hash creation in routesetCarlos Antonio da Silva2012-04-241-3/+4
|/ /
* | RouteSet: decomplecting a way to handle positional argsBogdan Gusiev2012-04-241-26/+20
| |
* | RouteSet: simplify routes helpers generation codeBogdan Gusiev2012-04-241-13/+21
| |
* | Add missing requires in routesBogdan Gusiev2012-04-232-0/+3
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-211-2/+2
|\
| * Fix formattingOscar Del Ben2012-04-181-2/+2
| |
* | Freeze the middleware stack after it's builtJeremy Kemper2012-04-201-1/+1
|/ | | | | | So apps that accidentally add middlewares later aren't unwittingly dumping them in a black hole. Closes #5911
* let's keep the slash in the return value instead of the path variable [ci skip]Vijay Dev2012-04-181-2/+2
|
* Warn about do end syntax in redirect optionOscar Del Ben2012-04-171-0/+3
|
* Fix redirect with block exampleAlexey Vakhov2012-04-171-3/+3
|
* Fix example in flash middlewareAlexey Vakhov2012-04-171-1/+1
|
* Fix comment in AD http responseAlexey Vakhov2012-04-131-1/+1
| | | | response in integration test accessible without @ via attr_reader
* Revert "Merge pull request #5750 from ahoward/master"Santiago Pastorino2012-04-081-10/+1
| | | | | | | This reverts commit 174cf8b22064c3999dfa685014d5b31ac993bb54, reversing changes made to 7ecd6a731bd60665bc6de94095137f0b2c4ada2a. The reverted commit improved the performance in the wrong place, now we have added this 6ddbd1844a6fd6aca2992f5f75c9f605cf89808f improvement.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-04-071-1/+1
|\
| * Fix example action dispatch in mime typeAlexey Vakhov2012-04-071-1/+1
| |