Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use custom visitor class for optimized url helpers | Andrew White | 2013-03-03 | 3 | -9/+13 |
| | | | | | | | | Rather than trying to use gsub to remove the optional route segments, which will fail with nested optional segments, use a custom visitor class that returns a empty string for group nodes. Closes #9524 | ||||
* | Remove redundant method | Andrew White | 2013-02-28 | 1 | -8/+0 |
| | |||||
* | `format: true` does not override existing format constraints. | Yves Senn | 2013-02-27 | 1 | -1/+1 |
| | | | | | | | Closes #9466. Passing `format: true` used to override the constraints: { format: /json/ } with `/.+/`. This patch only sets the format if there is no constraint present. | ||||
* | allow non-String default params in the router. | Yves Senn | 2013-02-26 | 1 | -0/+2 |
| | | | | | | | Closes #9435. Skip valid encoding checks for non-String parameters that come from the matched route's defaults. | ||||
* | the router allows String contraints. | Yves Senn | 2013-02-26 | 1 | -11/+17 |
| | | | | Closes #9432. | ||||
* | Merge pull request #9434 from zires/dev | Rafael Mendonça França | 2013-02-26 | 1 | -1/+1 |
|\ | | | | | Journey::Path::Pattern#new raise more meaningful exception message. | ||||
| * | Make ActionDispatch::Journey::Path::Pattern#new raise more meaningful ↵ | zires | 2013-02-27 | 1 | -1/+1 |
| | | | | | | | | exception message. | ||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-26 | 2 | -2/+2 |
|\ \ | |||||
| * | | Typo fix. | Carson McDonald | 2013-02-21 | 1 | -1/+1 |
| | | | |||||
| * | | improve grammar describing ActionDispatch::Cookies::CookieJar#delete | Weston Platter | 2013-02-19 | 1 | -1/+1 |
| | | | |||||
| * | | improve grammar describing ActionDispatch::Cookies::CookieJar#delete | Weston Platter | 2013-02-19 | 1 | -1/+1 |
| | | | |||||
* | | | Allow both a path and an option on root in config/routes | Sam Ruby | 2013-02-26 | 1 | -2/+9 |
| |/ |/| | |||||
* | | determine the match shorthand target early. | Yves Senn | 2013-02-21 | 1 | -14/+12 |
| | | | | | | | | | | | | | | | | Closes #7554. This patch determines the `controller#action` directly in the `match` method when the shorthand syntax is used. this prevents problems with namespaces and scopes. | ||||
* | | Remove XML Parser from ActionDispatch | Prem Sichanugrist | 2013-02-20 | 1 | -23/+3 |
| | | | | | | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem. | ||||
* | | InvalidMessage is in ActiveSupport::MessageEncryptor namespace | Santiago Pastorino | 2013-02-19 | 1 | -1/+1 |
| | | | | | | | | Closes #9302 | ||||
* | | Add missing require to routes inspector | Carlos Antonio da Silva | 2013-02-19 | 1 | -0/+1 |
| | | |||||
* | | Require AS deps in ActionDispatch::Http::URL | Miha Filej | 2013-02-19 | 1 | -0/+3 |
| | | | | | | | | Allows us to use url_for and friends in isolation. | ||||
* | | Duck typing is hard. Add header to HtmlTableFormatter. | Steve Klabnik | 2013-02-18 | 1 | -0/+4 |
| | | | | | | | | | | | | | | Somehow I missed this method, which was then throwing an error when viewing routes as HTML. Make @rubys happy: ✔ | ||||
* | | editorial tweaks | Xavier Noria | 2013-02-19 | 1 | -3/+6 |
| | | |||||
* | | use strip_heredoc to keep indentation consistent. | Steve Klabnik | 2013-02-18 | 1 | -12/+12 |
| | | | | | | | | Thanks @sikachu. :heart: | ||||
* | | Add message when you have no routes defined. | Steve Klabnik | 2013-02-18 | 1 | -0/+25 |
| | | | | | | | | | | | | Print a message in both `rake routes` and at GET "/rails/info/routes" that lets you know you have no routes defined, as well as linking to the Rails Guide on the topic. | ||||
* | | Add headings to rake routes table | Steve Klabnik | 2013-02-18 | 1 | -3/+19 |
| | | |||||
* | | Gist URLs are now namespaced | Akira Matsuda | 2013-02-18 | 1 | -1/+1 |
| | | | | | | | | see: https://github.com/blog/1406-namespaced-gists | ||||
* | | Return false on toggle on error pages | Bartlomiej Kozal | 2013-02-17 | 2 | -6/+7 |
| | | |||||
* | | Merge pull request #9307 from wangjohn/remove_unneeded_md5_digest | Xavier Noria | 2013-02-16 | 1 | -1/+0 |
|\ \ | |/ |/| | Removed an old require of an MD5 digest which is no longer used. | ||||
| * | Removed an old require of an MD5 digest which is no longer used. | wangjohn | 2013-02-15 | 1 | -1/+0 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 1 | -1/+1 |
|\ \ | |/ |/| | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | ||||
| * | Fix typo. | Carson McDonald | 2013-02-11 | 1 | -1/+1 |
| | | | | | | | | [ci skip] | ||||
* | | Merge pull request #8704 from senny/remove_regexp_global_from_url_for | Aaron Patterson | 2013-02-14 | 1 | -2/+6 |
|\ \ | | | | | | | replace regexp global in #url_for | ||||
| * | | replace regexp global in #url_for | Yves Senn | 2013-01-16 | 1 | -2/+6 |
| | | | |||||
* | | | Avoid to_sym calls | Santiago Pastorino | 2013-02-13 | 1 | -1/+1 |
| | | | |||||
* | | | the `:controller` option for routes can contain numbers. closes #9231. | Yves Senn | 2013-02-09 | 1 | -1/+1 |
| | | | |||||
* | | | Add missing require to AP | Carlos Antonio da Silva | 2013-02-08 | 1 | -0/+1 |
| | | | |||||
* | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 1 | -4/+8 |
| | | | |||||
* | | | ruby constant syntax is not supported as routing `:controller` option. | Yves Senn | 2013-02-06 | 1 | -0/+6 |
| |/ |/| | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide. | ||||
* | | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 3 | -0/+4 |
| | | |||||
* | | remove dead code | Aaron Patterson | 2013-01-30 | 1 | -4/+1 |
| | | |||||
* | | change parameter name for positional args | Aaron Patterson | 2013-01-30 | 1 | -2/+1 |
| | | |||||
* | | nodoc the helper classes, cache stuff for optimized helper | Aaron Patterson | 2013-01-30 | 1 | -13/+17 |
| | | |||||
* | | cache path parts in the instance | Aaron Patterson | 2013-01-30 | 1 | -2/+3 |
| | | |||||
* | | stop evaling a string every time | Aaron Patterson | 2013-01-30 | 1 | -4/+4 |
| | | |||||
* | | moving helper classes outside the private block | Aaron Patterson | 2013-01-30 | 1 | -90/+88 |
| | | |||||
* | | pushing specialization down to the optimized class | Aaron Patterson | 2013-01-30 | 1 | -23/+25 |
| | | |||||
* | | use polymorphism to remove conditional | Aaron Patterson | 2013-01-30 | 1 | -35/+27 |
| | | |||||
* | | move conditionals to instance | Aaron Patterson | 2013-01-30 | 1 | -6/+16 |
| | | |||||
* | | pull stuff out of the caller and hide in the instance | Aaron Patterson | 2013-01-30 | 1 | -4/+3 |
| | | |||||
* | | moving more stuff on to the instance | Aaron Patterson | 2013-01-30 | 1 | -18/+18 |
| | | |||||
* | | move optimize_helper? to the helper instance | Aaron Patterson | 2013-01-30 | 1 | -9/+12 |
| | | |||||
* | | moving more stuff to the instance | Aaron Patterson | 2013-01-30 | 1 | -6/+6 |
| | | |||||
* | | moving some stuff to the initializer | Aaron Patterson | 2013-01-30 | 1 | -14/+38 |
| | |